From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791F4C3DA6E for ; Wed, 3 Jan 2024 23:56:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D7356B034A; Wed, 3 Jan 2024 18:56:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 087EF6B034C; Wed, 3 Jan 2024 18:56:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB8756B034D; Wed, 3 Jan 2024 18:56:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D9C966B034A for ; Wed, 3 Jan 2024 18:56:15 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AF04BC0213 for ; Wed, 3 Jan 2024 23:56:15 +0000 (UTC) X-FDA: 81639661110.08.CB29E62 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id A6CD44001A for ; Wed, 3 Jan 2024 23:56:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F11Gw5sb; spf=pass (imf04.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704326174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3vq5JnjQLOvesNb0kVZ1aPrWIhAVbIzD97teanE60PY=; b=zxhjGigPYW5EeU4RylYI6lE/x2CuImsttdAEBJjACk8Tm7DPoN57722VMkZ4F2XWDs0Kp+ TcIqJwWoYPRvrxYTeYrTvSotx6khewwTKWNV60EQfuXunXNpEbZQs0Zr0xxaRJ6u+4naa+ zDwwZA7zgKTWr82GTNHlzprfGiPbp1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704326174; a=rsa-sha256; cv=none; b=SJIYVpbpyxIM02ySSLq20/RVagifVdSD4g08BTMsY2/Ung5lV0Xv1KoExiBfsQB2+J/zFY WuyuHw+3BslG8XzbSoQ4UkqO1aFij5OFbfNn/IeE/8byiBRTBO4MHoH86RlA9BIfz1/Mu/ 1K2YkyMzlPChuYyKEBhmPTgzLRrr9mU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F11Gw5sb; spf=pass (imf04.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 63D86CE13A2; Wed, 3 Jan 2024 23:56:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E5FAC433C7; Wed, 3 Jan 2024 23:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704326169; bh=7gY9azDXC9s5u4QlwSCz7zweBOkdXj1buGS+XsT4Zng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F11Gw5sbrV0JLSIqxUYLyApLxiQQN7NlooAvghxI/6N1JYwNDYo7X6TABP24qC41h 2FveKS4QuvHN9s/76KNBxFI4xc5umjaEliG9R39n86fBGlwxSCGIiefpqkCoFBwC6S /7t6EpyzSV6TlaZlKC3RPCy45VltcOPXarWYPG6VZjKY9R6qf0aMMI71PLEHPc5OzJ DgcP1482QdsvamB5ry2l2piTDGgvoL4tw6SWLqJKXnkgVIHZR4O24KQZLGJ8pvFcGo blBQr13bNpC5ZXYs2xEQPjvCuOsgjCpogo7JdsC+VQjXijS3+bbUIakcoGpsiCyzsT WiYvoZQ59JSSw== Date: Wed, 3 Jan 2024 15:56:09 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/15] xfs: shmem_file_setup can't return NULL Message-ID: <20240103235609.GA361584@frogsfrogsfrogs> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103084126.513354-8-hch@lst.de> X-Rspamd-Queue-Id: A6CD44001A X-Rspam-User: X-Stat-Signature: f61yya4icre8a5zqnmnkr5fwfj595tmb X-Rspamd-Server: rspam03 X-HE-Tag: 1704326173-369764 X-HE-Meta: U2FsdGVkX1+h0YIEn8ZgLYf2JR67VHSUZb0XQJYjpdYd1kLc+6lxwLjyY9vhJtiokXmwc8lB/GM+G+EBatqaUzR1zx17xXo9GtXnIabbaVrKb2RuY3Nj9VHfYNi/dVyzGu9lw2ux5nqrEcQc8pXLLpH6g+/EHQbtw/0Bo9XejPEMpbmCHiDJQtViqfBfDs6qwaWLIfGVM8xAi1MhIloOuUpfLOWFyLOyISRPVcPBQgfaIveW28/rF4K7CZ3qveNgSD5ucnTQLpEFQtJ4/V2jpgqDLlG3LDTT6J4xluG9W1JguN7tNA+r1md7wSZDEhVWLI4ONre60XXeIUXSyyyldyD/IUrjxSCU4PhEw+nrd3c7AMxTaZZwa00hMZKW6jTsebL0i8l1ioDvyApJ3NU7CMY2k3s9I3N2W09E+k7eJLRE0yLn7B4OPutGueBfqBHHwW0xibvFPB/tnwIl8Iwn8IN7JE2fQeASbrWJmE0cuG7EauMI51UKckaUJsg3IScnQGDHTKn1suvDa+DWWFIOxrCBrasD7F0TUtAHbfwzqwiQxgn+pEnCtJyQLZMHpyyyPUE/9YKKNQqUhFLPySUoePIq7vFwUvGXDyMOZvDRPwqmciGG0lmMehSF8hMIbUu7mC26CpvnjB3oAVE/hnNwUqcjn/UWkcUSrcsvtCufqe7ZrRHBSoraX2ae/5jxxqY/y+Ln3lBNcBEcVc2eN6kc0efWXoXHckBmiKzCb0oeglldaH3RHk6Cq5gj/PyRKna26efErvMoOepLUQEyG7YEvXQ5tNVSoekjo9zD8VZWiPOqIY7ovAbZHPXLEXafrUXOhsdC7gNxm2bOqHA0kYB/KwBZ1jOCkF7YOC3TQsp+J9eOWGQNt2oqOO8ceAV/mL6MybuQL25fQfy4JSbyWRJcDxXBaGuP/ZYUJvfyRjwFA4/D32QUzLiYUAmv35Vr3jhnZ9dZZy6CCstqIIEdSC4 /tY7lMhi KN31Hpj4Z8SpxUrAPvZ+uVlUMxpReWmjJwD4hcEgCngJThVrxJ/5namWOGHsQBaeOgVl20zyL1LuqVP0ggMZVNNf23//v2VZ/WjIgPaLOajMey1KLXCx2eGKF+oDrZKqH1sWaRswxCsZSZ3DKEF4kK5JJ25qUtH3g0YMegctcGIw7ZUWjI1G7b8dBEQC3BpcRLfmS9Gydw/RSCfzwjrh9khZgeupqW6NZ3nG509JL2/xCEtNxSqwvDP6gBw8dB+Q+RhUCyYweQgwtUEsfRLzRYP+aM2JGRtpA6W61 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 08:41:18AM +0000, Christoph Hellwig wrote: > shmem_file_setup always returns a struct file pointer or an ERR_PTR, > so remove the code to check for a NULL return. > > Signed-off-by: Christoph Hellwig I guess the bots will stop hassling me about this if I say Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/scrub/xfile.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index 46f4a06029cd4b..ec1be08937977a 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -62,15 +62,13 @@ xfile_create( > { > struct inode *inode; > struct xfile *xf; > - int error = -ENOMEM; > + int error; > > xf = kmalloc(sizeof(struct xfile), XCHK_GFP_FLAGS); > if (!xf) > return -ENOMEM; > > xf->file = shmem_file_setup(description, isize, 0); > - if (!xf->file) > - goto out_xfile; > if (IS_ERR(xf->file)) { > error = PTR_ERR(xf->file); > goto out_xfile; > -- > 2.39.2 > >