From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5256C3DA6E for ; Wed, 3 Jan 2024 22:42:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 448AD6B01AE; Wed, 3 Jan 2024 17:42:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F8EC6B01B1; Wed, 3 Jan 2024 17:42:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29ADA6B01B3; Wed, 3 Jan 2024 17:42:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1B01C6B01AE for ; Wed, 3 Jan 2024 17:42:44 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 059DC1A0961 for ; Wed, 3 Jan 2024 22:42:44 +0000 (UTC) X-FDA: 81639475848.17.3DB3165 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf05.hostedemail.com (Postfix) with ESMTP id 2517910000C for ; Wed, 3 Jan 2024 22:42:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SZ1rXI8a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704321762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R+2gqGxCQVVJrCooIPs7Fc2JoxPo3Bt1g3/hDzEpuj8=; b=okD8wS5OPcPHFE7HJ/oUolkGxGHOx+ZffRn+6qHCTs01DAfWctABngqqDKxBvhqsaeDv/1 bGC+nQ5cecXq8FjrOpsijktJZvE77RAMoi7m6wkjpfl0ZZefDD3WVrIQqkXK/80468XYWl lM8DYrJIF2oEtwyBUr9rhgUbtCX9cbE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SZ1rXI8a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704321762; a=rsa-sha256; cv=none; b=KE3osfzMSvUcJP8wrK5FS04gLwgrIzzer0mKiE5h2nfxx+hWW+V7/ll/fkShtw/wW7Ehbc TFem0W1NEu1xKf1tlbGFhv8ef456GJK26+DCQTvg2XBPIyP7Qj6z7yp+JrcjWwqUOorHqm 2tb+4qCo4SAnYu6VQq3RXFbITlbndBw= Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-1d426ad4433so44923815ad.0 for ; Wed, 03 Jan 2024 14:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704321761; x=1704926561; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R+2gqGxCQVVJrCooIPs7Fc2JoxPo3Bt1g3/hDzEpuj8=; b=SZ1rXI8a6EFVAHhxXemSjIZYAP6Abg1kYvdRU5w2KAESRN2QO86Rd5Mb7tn27FdBZg nKJyvxTH8FVhTplqk346b/OtNGqy3EMDkgn/HlToYqPNCBFbf6bdRs3gYoVySwxEB5t8 xEcdunq1DMrqNM524ankhY5Jz+5ucYNRq1aJqoM0+V/43B9G+ZzrlQhk5rpxMoZtjcPx 21eTJJgNPCdOCbVh5VO/BL2CRd9g68sLBuKDoaGsYU7iyxXOvYbDeJFeH62Aed7y6Wjk 4foDogBftUDOeP9DGnunb+hcZgX2h7JoOp8kHUzUD731UuBnuy6iNpvs2fJarp6qKgul Bfwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704321761; x=1704926561; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R+2gqGxCQVVJrCooIPs7Fc2JoxPo3Bt1g3/hDzEpuj8=; b=UUzzvkkRagt8PUdqquAhObor0V5U8BVxsLazvObWCxvHgsHJ/10z1RWCgRDUIDnkec yLJkmmiJwVJrfgjKkp71og2G+tNmxpr82NWkenpgSEojIEtEREMdx5VNTTZ4Dqx0NlTA gifJ803BDDcNdgYUYj4PBl+txNgOp+brCL1GV62xJyuESLrwKFNMOl4Nb64SE6glv1OX ipDmXXwQp//cW4wo2qQJSWOesc2Z/OVaXXHdAvjp0V0tz/k8Eap07diVGIRV83jud9Nv yjEiApWqOBJnGTuMrE/ZZk5HSvdUO4WgVLOvDx0bhe0WxkYhJ3YJEgdReaOcjuEzEgVD 38Kw== X-Gm-Message-State: AOJu0Yzp7k1NCk+ljSHMH083R/B/a2kBf5DFx5Swn3Hu7N3/O6dhmkm7 wEAAbHow/DJ4Xl/RWR7SlclnCUcwXHd41is= X-Google-Smtp-Source: AGHT+IFnOwL88aJ7puwINYSQH+GK5aFsJocJT3yRJ9rZ9oLHhwfKfEgPNmLvb6n4zqZvaSRmEBRslg== X-Received: by 2002:a17:902:ecce:b0:1d4:35ad:41cd with SMTP id a14-20020a170902ecce00b001d435ad41cdmr7934219plh.108.1704321760933; Wed, 03 Jan 2024 14:42:40 -0800 (PST) Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id g1-20020a170902fe0100b001d36df58ba2sm24269426plj.308.2024.01.03.14.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 14:42:40 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-mm@kvack.org Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com, gregory.price@memverge.com, corbet@lwn.net, rakie.kim@sk.com, hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com, peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com Subject: [PATCH v6 02/12] mm/mempolicy: refactor a read-once mechanism into a function for re-use Date: Wed, 3 Jan 2024 17:41:59 -0500 Message-Id: <20240103224209.2541-3-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240103224209.2541-1-gregory.price@memverge.com> References: <20240103224209.2541-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2517910000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: h4xwxnr7r3m91m4jg3k14zkhe7mttxys X-HE-Tag: 1704321761-961661 X-HE-Meta: U2FsdGVkX1+XdzoEVICbiN7q/BKaSFCWcszGjWb0UqD2OKF3PISOL6R1FEfE7mgDvABtNsQSTvzo9z9r7Wb23JbsfMS9KyD5TT6DwkPJB8kqNtu1tHBWwxbAqO/fcor6vMibtboEW/4RSWOPASttI4/chtQdEw2PAxiZaNHy7Sp1XW2fiHnJg13brzH7qPLvbZYrDPZwek3HRtylms4FOfxTNXBURtkOVxVtWlq7SDyqOJ6gvI8ussVRhiFUjdf79SHkj9cIVt4xdxp17K41HmLMXiU4GwHAWE4WHSmAddtuSyok9odJs5p3Z07a/sxPF5VbM11Ek87tUtp1q8CsOyNWSDx2B2KWzbXJHaVfv6QldKO2gqpUG2A3qpYgdRTEarokoVvt4RB/GHv0MzZuUokFFKqDQnchC9UvyzqYqCmPLKqbBkZ0m/H1OH2f25kiK+sN0DlAD8FupOwIB7B1XdWc20Vjs0owHpot6kmsBSM6Jn8KEpyNvNfZECDJs/LuRg3G5UsZg6Uxs0oqsMhZkG9ZAW0VcfbLmIN4U5n0cqOrSajrB8LYSMKlzIiHM+PsYL25UUZHH5OBSQXfD5Ol8qF5TbY7YCyXPYow8Rdj9g9IPPIgLvjUFEmWM98wzQ611MTSLtwifOUhikLo70FLWsBeIUsZTz9i613xuVfwWNXxEDeTrvMXsZ+pIne5t/e9StqZ0G0ut3bpLRw0PRBNZ2hSJqrLBCSMCdypE55guI8OPr23MAPpai979HmDtke5p0OyT5thIyjkix4mTftInAUAKFhwuEBHpWKFepFaDbNwA8rcQr7s7IcbNe9wy/JLg6Gbkvr8ImDpxSETgLoikn2lU8R3UYUg5qaxYgwAu/DqlKZ2CJKv0oCDxrOi0/n/p2Utp+99frCK133r+LiNI7ay7ySMYFQBo2JwC7pNw4TYCnRtigDgSKSN/WIP7Rf/EWtedBWW7uck8FVHxq3 0f8wC9Av 3hADWkYova3ia5T54sqUT7pzxEhCvlED9vhmeM9FLIJCsXIHcxm82yRhNr0U/9+1Kunvw43TrnGfVVDQIGSsqB2fd09jlW3PCmfPsxk8RIpNjs12p9lKc/gL65fNELuWa/p0bpFQjebHvsAkRrwaUk8pJyjl8EVi3VsarIQ4l/sFw8Rij8rFS6bymqx7SKC5cWI4oU39+aI7CZgD7B8Q3+sdMbGxx0RbFzL/wlEYdt0HW4ZOZZOy9VHg4Gj8iUH++Bjjec3VN0uWR3AtlkTyZjA2LkP1dkwZVENcaZs8izv1c2AkNasgoA8Uaid3eVUVhIxAalPw8+TvaN7u8qQhpUA7ESxpqYyBY+kZJ9VIfNblzyy7g53c/Qgu+Xa+feYZB0uhrWaLx8XV/Ex9kkmhG8YnT6T+fwwG6eNy9ovDoSW4o3Rtt5KT6L9hwBWbu/d8aUp4UJPXDHRv8cwBJsAvYL7gakQYrjlqozMHuaozYGwIMiGE8ojQA0ZVxZfPMX23VimvChHfB+BMyPk3hyGkhAaP7PcVbu+/7u8/T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: move the use of barrier() to force policy->nodemask onto the stack into a function read_once_policy_nodemask so that it may be re-used. Suggested-by: Huang Ying Signed-off-by: Gregory Price --- mm/mempolicy.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 30da1a1be707..6cdb00acb86b 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1900,6 +1900,20 @@ unsigned int mempolicy_slab_node(void) } } +static unsigned int read_once_policy_nodemask(struct mempolicy *pol, + nodemask_t *mask) +{ + /* + * barrier stabilizes the nodemask locally so that it can be iterated + * over safely without concern for changes. Allocators validate node + * selection does not violate mems_allowed, so this is safe. + */ + barrier(); + __builtin_memcpy(mask, &pol->nodes, sizeof(nodemask_t)); + barrier(); + return nodes_weight(*mask); +} + /* * Do static interleaving for interleave index @ilx. Returns the ilx'th * node in pol->nodes (starting from ilx=0), wrapping around if ilx @@ -1907,20 +1921,12 @@ unsigned int mempolicy_slab_node(void) */ static unsigned int interleave_nid(struct mempolicy *pol, pgoff_t ilx) { - nodemask_t nodemask = pol->nodes; + nodemask_t nodemask; unsigned int target, nnodes; int i; int nid; - /* - * The barrier will stabilize the nodemask in a register or on - * the stack so that it will stop changing under the code. - * - * Between first_node() and next_node(), pol->nodes could be changed - * by other threads. So we put pol->nodes in a local stack. - */ - barrier(); - nnodes = nodes_weight(nodemask); + nnodes = read_once_policy_nodemask(pol, &nodemask); if (!nnodes) return numa_node_id(); target = ilx % nnodes; -- 2.39.1