From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CEFC3DA6E for ; Wed, 3 Jan 2024 12:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A6F8D0068; Wed, 3 Jan 2024 07:51:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 722298D0061; Wed, 3 Jan 2024 07:51:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E9A38D0068; Wed, 3 Jan 2024 07:51:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4BF948D0061 for ; Wed, 3 Jan 2024 07:51:07 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DF08802F1 for ; Wed, 3 Jan 2024 12:51:07 +0000 (UTC) X-FDA: 81637984974.25.41B6871 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf21.hostedemail.com (Postfix) with ESMTP id DCFE61C0011 for ; Wed, 3 Jan 2024 12:51:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ht1eqXA4; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704286264; a=rsa-sha256; cv=none; b=dZKhcC2rzgJUtJZhXCbb+zgqtw55FnEMz97xDNtol7gCj+6eZTUIT5Sz/rByjNmAcg8c8X sCLNdj3m46XZ38gYBp/6q7+ntXXziYc8QqRwiJ7EtBAKuQcU31EhbvLz02loJJreAK/VQ+ 6MXYlaP+rwM83AxGBTWnFz8nJ/iF2Z4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ht1eqXA4; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704286264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JLuZ9WMo4I79fc0IlLLTmPVbf1K91VLQfdnP8FlT44k=; b=p+yKQz4UXYK0gq9bsKKS9A+5/TRnf5L2kgKssgKkoNSQTiazz7QlqC7wixf+bBtGZCcPVr 1LvEl8mxRr4Ua5kuTDX55yXmmE5+LyBBVO3DUygcR0WgP6peheT+HZ3vV85v/9NK38SjGu gAo3ibyyKvrkbGW4514MYKlVa5dmshQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704286264; x=1735822264; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KYziqKdQfSgXfcOt7uAj0Nx4BYS3Yqk3BF3UVFmBCH0=; b=Ht1eqXA4WCsGgUFM9RVfaEEQ5QhVXedLQdti/+kl1RufeQg4LrkMIrss mooiH8qSIZTe37C/Aj7v2NXR8AONuXcIEpCebMJrMvgXcTO3Gta9VRZfD M1WtjKjO41C7kBBqXniIh53jdQB7qFIyQKOimgR/GZGau71abUoNBWpBo 9Y0dC74ccrnmFgUglvvWqOkfEpwaIdvAP2LgUuUPCCgQT0Mq9xaVA55Hy YBf3Qxu0JBIfats2Mau3NmaHrcA2JmMmmbf6KqOBPvtCAbHYqS5Ub3fyI wXbYsqG/RzsFCFIW7GWP4zVW0CLRbtg1rM90mcZb+vv2JbZlJpHc7tmnw Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="10606490" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="10606490" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2024 04:51:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="850430030" X-IronPort-AV: E=Sophos;i="6.04,327,1695711600"; d="scan'208";a="850430030" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 03 Jan 2024 04:50:58 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rL0i0-000M5f-0w; Wed, 03 Jan 2024 12:50:56 +0000 Date: Wed, 3 Jan 2024 20:50:45 +0800 From: kernel test robot To: Kairui Song , linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Chris Li , "Huang, Ying" , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH v2 7/9] mm/swap: avoid a duplicated swap cache lookup for SWP_SYNCHRONOUS_IO Message-ID: <202401032010.yrIDf885-lkp@intel.com> References: <20240102175338.62012-8-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102175338.62012-8-ryncsn@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DCFE61C0011 X-Stat-Signature: mcqmhigw3aeiif1xidzz3yh769cfwpwc X-Rspam-User: X-HE-Tag: 1704286263-791882 X-HE-Meta: U2FsdGVkX1/k7cCk/+DHudyiWq24e2+y1lp6lzD9wt4fAPWYN4kPc7mKc6nu6tGGFBV/VwtvXXlGxSQ4Wz0WTbAF506NCcZ5KnI7iIIP75oPdO/wc4Zabprqj0EdNR0qw46IKWWRvhoqSnBUcuhQMn/PLYr2Gz2RnxuXfkPGegkC1JZqAKuOvVMU5M28v/I9q21Hv6G2QQCH5/5NrHXKKhX+elRMP5LGJRFN6We5T0ALQFnnq9XnqsLb5g03rZ3/sOCsEdhb/fVvSbnajGcDv9asYWP4lk/6ln/vFhwIVBbsfAkoVxpfKxmtGkCuDk73vsacb7l+FZRsCQf8r2MxyUYgIaiY2yngj3OJN7olv4wTAk0fWMfdy3OvDBxHujjIi+DQkZHWyZdDkHpAVZPG3SdNlPiODOj3ki1jL/7xDv7KP+FMhbtbs59TOO8Dbbbn48wPBoGK+CUmIqRONhlOW1LFxY6abpeAgOAK4qeZvbN9ounOWepzuMnADLpYHI8xRmlFTjzO9XPEM3Q+/jH6UnADmR61nVIrdcwK/lpUD0PwkdjBr0zxg0xPSqvegqxZLV/XxnAcYChJ5fhn5mFRuoA6/kLydzCC0thC8VjK5Eboe8O4hyYM4LFw9CeL3AwbSr3a8J7OoVeEVOqgCBb02+ewyOrTKVm+rP0OdtX73mFqS0UB17SfhM0UFV9l89yJ2HYYHhg4/c62TT2/ZisG/qbbwvdNKwtYL/PNk6fQNwK67dapmSOO9lQxyrt9nRjINZACY3E/Wee7JhwmIz1xi64TqVSIS3ueKshg7UxwQb4s0R1M+QTLtcy7hBwWvh47lsOGiV+Jvtgcf9myrhEthmmXmlOtgmJwyuJx4xiwyvzmqz0O4exIpf7FQzJEfbUWZ9lZvXSC9L7x0DyOPExmBxJyMfjbjSTKp2d9L8+f44z+hPgtiLDf6Ozn91/shUMURQKBSGbT4JuRatE3kPd TAGEPohK Vl8NAw7g4MImjg6ERY6X0PTiAVV0fiCBPVNAaOzl9pJniH3VNGbrYSsKjJZwct0egEy9/m6DIzQz70WFXZw6kbPzew1Cakz5hLpmFjgr/CerMQaZs4JJCkAmQOSOlqM2s0XbnrocXjam7VrvVB5/t3fTPabxUYCRVzaIqbXEFcaHMjLiv57ans2yRLBM7BUF+RUA/9Lq70/pAVn09MnBn8mWi+BKwxt7RffYjKaGc+l5neIsFDf28xOeRVmubFy1+GDUnRhx/HT6gj9/HYBk8/ZDudFNasWFYM6ZWRvY/hA5QO1tQWgPqLcrCSLSzwlVUDzztCLQiUIeUGriJHVkdC5KMC6LHrqDqMZB/9i9o6P6BmxvvjId8UD8kdO+je9W3fOiJVuTBoBFowLfzumlGq5XjUqR5ER0IgpRpFEwgA/2Qo5fHtTw9vHOSHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on next-20240103] [cannot apply to linus/master v6.7-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-swapfile-c-add-back-some-comment/20240103-015650 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240102175338.62012-8-ryncsn%40gmail.com patch subject: [PATCH v2 7/9] mm/swap: avoid a duplicated swap cache lookup for SWP_SYNCHRONOUS_IO config: arc-vdk_hs38_smp_defconfig (https://download.01.org/0day-ci/archive/20240103/202401032010.yrIDf885-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240103/202401032010.yrIDf885-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202401032010.yrIDf885-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/swap_state.c:884: warning: Function parameter or member 'shadow' not described in 'swapin_direct' vim +884 mm/swap_state.c d9bfcfdc41e8e5 Huang Ying 2017-09-06 872 b16a5db0ccd159 Kairui Song 2024-01-03 873 /** b16a5db0ccd159 Kairui Song 2024-01-03 874 * swapin_direct - swap in folios skipping swap cache and readahead b16a5db0ccd159 Kairui Song 2024-01-03 875 * @entry: swap entry of this memory b16a5db0ccd159 Kairui Song 2024-01-03 876 * @gfp_mask: memory allocation flags b16a5db0ccd159 Kairui Song 2024-01-03 877 * @vmf: fault information b16a5db0ccd159 Kairui Song 2024-01-03 878 * b16a5db0ccd159 Kairui Song 2024-01-03 879 * Returns the struct folio for entry and addr after the swap entry is read b16a5db0ccd159 Kairui Song 2024-01-03 880 * in. b16a5db0ccd159 Kairui Song 2024-01-03 881 */ 983c0b807f7eda Kairui Song 2024-01-03 882 static struct folio *swapin_direct(swp_entry_t entry, gfp_t gfp_mask, cd81b9fd3de376 Kairui Song 2024-01-03 883 struct vm_fault *vmf, void *shadow) b16a5db0ccd159 Kairui Song 2024-01-03 @884 { b16a5db0ccd159 Kairui Song 2024-01-03 885 struct vm_area_struct *vma = vmf->vma; b16a5db0ccd159 Kairui Song 2024-01-03 886 struct folio *folio; b16a5db0ccd159 Kairui Song 2024-01-03 887 b16a5db0ccd159 Kairui Song 2024-01-03 888 /* skip swapcache */ b16a5db0ccd159 Kairui Song 2024-01-03 889 folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, b16a5db0ccd159 Kairui Song 2024-01-03 890 vma, vmf->address, false); b16a5db0ccd159 Kairui Song 2024-01-03 891 if (folio) { 9e22e4254bdb8c Kairui Song 2024-01-03 892 if (mem_cgroup_swapin_charge_folio(folio, NULL, 64ae20cbed3891 Kairui Song 2024-01-03 893 GFP_KERNEL, entry)) { b16a5db0ccd159 Kairui Song 2024-01-03 894 folio_put(folio); b16a5db0ccd159 Kairui Song 2024-01-03 895 return NULL; b16a5db0ccd159 Kairui Song 2024-01-03 896 } 64ae20cbed3891 Kairui Song 2024-01-03 897 64ae20cbed3891 Kairui Song 2024-01-03 898 __folio_set_locked(folio); 64ae20cbed3891 Kairui Song 2024-01-03 899 __folio_set_swapbacked(folio); 64ae20cbed3891 Kairui Song 2024-01-03 900 b16a5db0ccd159 Kairui Song 2024-01-03 901 mem_cgroup_swapin_uncharge_swap(entry); b16a5db0ccd159 Kairui Song 2024-01-03 902 b16a5db0ccd159 Kairui Song 2024-01-03 903 if (shadow) b16a5db0ccd159 Kairui Song 2024-01-03 904 workingset_refault(folio, shadow); b16a5db0ccd159 Kairui Song 2024-01-03 905 b16a5db0ccd159 Kairui Song 2024-01-03 906 folio_add_lru(folio); b16a5db0ccd159 Kairui Song 2024-01-03 907 b16a5db0ccd159 Kairui Song 2024-01-03 908 /* To provide entry to swap_read_folio() */ b16a5db0ccd159 Kairui Song 2024-01-03 909 folio->swap = entry; b16a5db0ccd159 Kairui Song 2024-01-03 910 swap_read_folio(folio, true, NULL); b16a5db0ccd159 Kairui Song 2024-01-03 911 folio->private = NULL; b16a5db0ccd159 Kairui Song 2024-01-03 912 } b16a5db0ccd159 Kairui Song 2024-01-03 913 b16a5db0ccd159 Kairui Song 2024-01-03 914 return folio; b16a5db0ccd159 Kairui Song 2024-01-03 915 } b16a5db0ccd159 Kairui Song 2024-01-03 916 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki