From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A51EC3DA6E for ; Wed, 3 Jan 2024 10:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 790E06B00CF; Wed, 3 Jan 2024 05:49:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE4A6B00D3; Wed, 3 Jan 2024 05:49:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58F616B00D2; Wed, 3 Jan 2024 05:49:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4358D6B00C4 for ; Wed, 3 Jan 2024 05:49:31 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0BD64140200 for ; Wed, 3 Jan 2024 10:49:31 +0000 (UTC) X-FDA: 81637678542.23.C407857 Received: from mail115-76.sinamail.sina.com.cn (mail115-76.sinamail.sina.com.cn [218.30.115.76]) by imf15.hostedemail.com (Postfix) with ESMTP id AB8C1A0013 for ; Wed, 3 Jan 2024 10:49:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.76 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704278969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPXXGZLs5IIgEZFBg2tw2MQtwvdpYyw829YihYX2Wpo=; b=wEp/E3UA3dwkobelXhf5p9G/YymAoyKhZWuFKmBVMxnYF2ZZGIZmcwnj+yXo928ZusdrAh fooQHFphv8fShgEHe8ajDmITMuUpipVRBRLlCjSZQXhNUDmpKtED/heNxJrDCOmNiu/0Fp NxXEHT2joriIvJKiLz/+ba3ns/WU8XY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.76 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704278969; a=rsa-sha256; cv=none; b=aw0mxpu6kP+JHhRrnVzqkwLhpvbRefiaFrj7Cd3wOqiCErrpv9ovxxJlxc9pjGeywfyc0j lDCd/1TNitIRfTdsJR9IE0cKOPZOon8Mt0gkj7Og5AAfD4bb58vxQ7H/XnO6i99O0vavQH GQnA7jbPldiIdJPFeOjrNtj/vuuhWvs= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.88.51.3]) by sina.com (10.75.12.45) with ESMTP id 65953BAD00004F0F; Wed, 3 Jan 2024 18:49:20 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 77753331457868 X-SMAIL-UIID: CDA513BA0B8741509C75670EC74D7D86-20240103-184920-1 From: Hillf Danton To: Matthew Wilcox Cc: Genes Lists , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: 6.6.8 stable: crash in folio_mark_dirty Date: Wed, 3 Jan 2024 18:49:07 +0800 Message-Id: <20240103104907.2657-1-hdanton@sina.com> In-Reply-To: References: <8bb29431064fc1f70a42edef75a8788dd4a0eecc.camel@sapience.com> <20231231012846.2355-1-hdanton@sina.com> <20240101015504.2446-1-hdanton@sina.com> <20240101113316.2595-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AB8C1A0013 X-Rspam-User: X-Stat-Signature: jopsnru8anotn4rbyaqtts6pnm4cm9k7 X-Rspamd-Server: rspam01 X-HE-Tag: 1704278966-135054 X-HE-Meta: U2FsdGVkX19Xv5wT4sG3scvYUF6L2UIaeYar4Gz7dWaxM/gQxBe5Md7e5+BIfuxkBSXhH4RAjbzudrz4KYJj+/j9eDOqp5I/DqTORpCZzZxDFyqX7C6j1ceVaUl6OTxSKaYGCFSGn8I6XmVnRMOmd1v6zsuhTBcqyH7BhezI/UF/Y3pvzlQwFb6QQa5ckDX5jOKJTO/QO2nk699t1boiTnCHojapnOVNq4ubg5yDKOmP8iEPN7HceoF/plg31Lj1jL9S5t/F4rSPHcksmk+93dgebCnm5p0iWEaob4NvimvjkXTvyX2Z9EoeLKjhIN9Z2YvW53ZbDKY9K8J4JPxBtbBNg36tlTjtW9l2NIP9UOIumk5HIgc+Wbzq1KyhYPyJ+DmXcsyD8UBW9cVDX05M+t0Gec/XzOzUZ9KJJXeiyGGlrKKxTmNqLajqwAIw41ytV9t30mZSwlCpGyuiY8fegIWV22rS2bbeZGT/xyaDv6bBme+fGFg+ZqufOo8on5VwQIS+3g254341QfrRR6zC7Y2yKT+I5srMHjBFdb3L72DzqD9sBno4K1mzMYkGbYvLfIQwcfWE5P+2zvfNr4qIZ3GkjOEtH5BnubFJk6yFhaKJwemROOb/GsWmuJt7U1RQRhxGwEF/dFYd+1aNG2QkejY4X373cHtlTlFvvh4Yp53UJcGtO0FZoJTK+0ZUfbuNZvqShBsAwz1O/aNNaZCU+kiXwyN6qrgSURzDbLq2s6D+gbQ0WEk17f/GGQLY1jz5d9z85pIV8EFlQ+ikSjBY1j1Xxz4tqyuaPEV8mlqDJNqRrBj4bATxKbx4ziTtx+iaEGjbhPOhgZcM87yQULK7mLkQpKZbqiCIhaaK8NLeHCH6jZR9Tf5gSZ5Pvl+BMTna5YvD4rOEjowRHpeqLH+G/qD6KlJjlO8X15wRLOYJj2i7hhzkiqeiXBXA5DQI4lBEb3j6If6untb31eSFVsp 7lbfz2nR 9TtIUz+a0yvcmiHZYp2QPqkyLqTV8Swq9MlFHi8fqj/fd1PXq+5BaHcuH1pBJrll2k0LId/rcxpHU2f/9pPeWCbQYIJiwtli1veP+4xomKmDeomF7FEQtQR+uSRqTHu1KlDyy X-Bogosity: Ham, tests=bogofilter, spamicity=0.109412, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 1 Jan 2024 14:11:02 +0000 Matthew Wilcox > > From an mm point of view, what is implicit is that truncate calls > unmap_mapping_folio -> unmap_mapping_range_tree -> > unmap_mapping_range_vma -> zap_page_range_single -> unmap_single_vma -> > unmap_page_range -> zap_p4d_range -> zap_pud_range -> zap_pmd_range -> > zap_pte_range -> pte_offset_map_lock() > > So a truncate will take the page lock, then spin on the pte lock > until the racing munmap() has finished (ok, this was an exit(), not > a munmap(), but exit() does an implicit munmap()). > But ptl fails to explain the warning reported, while the sequence in __block_commit_write() mark_buffer_dirty(); folio_mark_uptodate(); hints the warning is bogus.