From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF887C3DA6E for ; Wed, 3 Jan 2024 08:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52EDF6B0324; Wed, 3 Jan 2024 03:41:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DDF56B0325; Wed, 3 Jan 2024 03:41:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A4E66B0327; Wed, 3 Jan 2024 03:41:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2483F6B0324 for ; Wed, 3 Jan 2024 03:41:42 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E86D740147 for ; Wed, 3 Jan 2024 08:41:41 +0000 (UTC) X-FDA: 81637356402.02.14A72E1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id BD590100015 for ; Wed, 3 Jan 2024 08:41:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rytIOVbX; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+f852f126c6d693376302+7437+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852f126c6d693376302+7437+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704271300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=9h8TFr0Cvw76++DeXKTV5CGshHC+4DLFSq++7+O27NI=; b=JmncTlKJBpRzbUDd+dgQIRKmD0pMAe4ds8iN7kEeC+zeXN/MyiYTcl1/lMkgUbcIIefnMI /5tHgTEnuC+XzPMiPXPkiKyUKofCY88GRroxL9yaN8PRKa+r+9MplQC1VKjibPmgnR4WTX FaIEgmIENVnOvv66mheW3Ox14A9I5Ik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rytIOVbX; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+f852f126c6d693376302+7437+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852f126c6d693376302+7437+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704271300; a=rsa-sha256; cv=none; b=F4EB36Vf24NdeHkOIqTZRUpE8CMNAXUL4QuhpKjgsNlTSH6qBbWQ4FcVg2ndiyqe8DgAeT TNGFsfwJFLWtGme7BWS8XIBwakBE5OmQhyh6G664MY3J55XUifxW9/22UH/lqTAc7wZkZd iB13ocjbOZbKNc0okiuGU4FJUUtq7KI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=9h8TFr0Cvw76++DeXKTV5CGshHC+4DLFSq++7+O27NI=; b=rytIOVbXITitsD4JrjhfxDefMM XkWDvDldEp8F0JkBa6JFYiSmXSlIBm761r0gVFmPk4uDvdJX0UQE4mPEPCmxJASlskDwlOpMVe+/p lW1F5qHot8BhUtYSYaMC/z2WfxKJrFJaZOGbQMSfB/EX4e/M6/D2GtL5BWBWlQXq6IFaQyNgthVfT x7PoJ5ULq7szMJVbLKFJrj5GNfRLQGnYrmtW7AUueU2CkAsZ6Esp419UpCNUe7NiiPJUlM+27wnQS egsb0P3op9ZnLMMpvr9GSJNPYzuJGUewN9taKkATTznOHOr4Ng2R5ksSf8tCjLEnZGiTJ/YZTd8vl WDcMLUcg==; Received: from [89.144.222.185] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rKwod-00A6TX-1H; Wed, 03 Jan 2024 08:41:32 +0000 From: Christoph Hellwig To: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: put the xfs xfile abstraction on a diet Date: Wed, 3 Jan 2024 08:41:11 +0000 Message-Id: <20240103084126.513354-1-hch@lst.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: BD590100015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wcypxeomschqgi4tuz3mjrzebnnbatew X-HE-Tag: 1704271298-823074 X-HE-Meta: U2FsdGVkX1+otrEvs1R+FhmaGtnPv7yvMUG2Lr8UTmVSMnCHNjY/d0rBDXBBjZgh72OWM1loBCO/Hs5+GbTXVP8qLDNFMIq2oBAUIukD9tm6wX+EdJVeE7I8bcCvndbBLDYhLZpVjD1ruAuHv6oOwgdxWvSeuJh8OVhx2m5OUXsLSGmYNvqYf0SpEehjiGhT1tKdQ6Y5hkez8HWiEK7KlDz04NkPbhzOja80gyU1Nw+p8bw+6StGsKXQTorTjmmu2KJwoVhJ5yKUeDcr2Utrm3tjFJxwfNGSRzKOEWMDo4NvhCR+ZXb3ssZq13fQrgtRUqCucK7/MydgHson/KINHd4GrG6wE+Vq2TJYVFNoWDeUCs47B2WpyFmu/kv4hUITByy3vJkqYEnzSmCP8CUn2V6/0Hv/bt/Y3iomSo4OeBG+FIHTwm3DfcQwQGR/o6jQHa7aclRzr80wvRN0IrxW1a45FPE6ZNgIAKpEvNAhcoDyaBkVDyKDvQUTAq2ftXWgAAspownvU2Gm3kCW6LVd8I7nO03BFpqu1uLUtj0aBCb8rvopBIgmUPkZYOEljeXnLMF/Zzn5927rrRcanNiBFaCPB1EVEpCbf/wIaJ3K5tPj0+6iVEEx2N0jVCV/HSCImhQtCfnsHitSotYLCVq/6b1T8hEHOJ4POyjDOBLWSnSsmqHpxsVc9os3C4EBUxGPXKJb5YY8Y970a+0KDrdy5aSwlIRNIjqyAfEQrovZog+m3fT+bndGxC9NEm9SlJyGsMpZHmKUt/KD7pJ6iDSa9AGyxMdf6t1qLdY7SFZ4q5K4oW5qocPqGbOHTDD3BXMfwMxI7frfQK8FyPaRJe3vbEE4YmwXTxWLRyX84VGrqgO/aYHItmSqf72qmfcw28SVXKZaj9DnmDYNMCX3kcVtXpI0S3nN9YlLonJ3PwKqMQqWM4tujPgS6W+FafpBd3niZ1MfeJd3VKnPNEzYnSx iovlYcrX ZXqi593g4lgMAgV9fs0nuwvC4HwfH8iABZOwdHy64Ec8ik4JFQ8E7JaOUgFVBYOOJiZ0wjn8YMJ0n4cytRvzn7p4sfY3BPf89OIwOxZJr9cUdDd+pofWPUliu/i0B79YEj70g4IYBbYEOAAGr2OO16VUkJB11F4aUC9U6Yk3oyS890Jxm0FXz6TgapmMGw0ntAKrur4Z8VuuTDjye3dJ3AnwfDzLyCUsJM3QDf9SVrTdzLCsO6osF1G81ihwkZ/U8Btf8P8tryCqRobGe6dgWI0D9J2lix5Agxr91TLijGNLrLXRHQQKiCWxaS+8OznZkXtE2RE598oy+Gy/MXVwiQDtRVAxfBvq4P2oHzJ3WFcv3TEYA+T0PvkxGW4fu5h0a1w+G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all, this series refactors and simplifies the code in the xfs xfile abstraction, which is a thing layer on a kernel-use shmem file. Do do this is needs a slighly lower level export from shmem.c, which I combined with improving an assert and documentation there. One thing I don't really like yet is that xfile is still based on folios and not pages. The main stumbling block for that is the mess around the hwpoison flag - that one still is per-file and not per-folio, and shmem checks it weirdly often and not really in at the abstractions levels where I'd expect it and feels very different from the normal page cache code in filemap.c. Maybe I'm just failing to understand why that is done, but especially without comments explaining it it feels like it could use some real attention first. Diffstat: Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 10 fs/xfs/scrub/trace.h | 38 - fs/xfs/scrub/xfarray.c | 60 -- fs/xfs/scrub/xfarray.h | 3 fs/xfs/scrub/xfile.c | 311 +++------------ fs/xfs/scrub/xfile.h | 62 -- mm/shmem.c | 24 + 7 files changed, 143 insertions(+), 365 deletions(-)