From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4398BC46CD2 for ; Tue, 2 Jan 2024 16:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF44E6B0182; Tue, 2 Jan 2024 11:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4D06B0184; Tue, 2 Jan 2024 11:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45AB6B0185; Tue, 2 Jan 2024 11:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 948BF6B0182 for ; Tue, 2 Jan 2024 11:26:35 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 62FD640735 for ; Tue, 2 Jan 2024 16:26:35 +0000 (UTC) X-FDA: 81634899150.29.1E9EFEB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id CF23FA0014 for ; Tue, 2 Jan 2024 16:26:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AW/E0A4I"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="r1j/YhHD"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AW/E0A4I"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="r1j/YhHD"; dmarc=none; spf=pass (imf25.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704212793; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k+3oH/iPMNT8bmBQskJIGpXoOt3U91w4qjWruS8V3Ko=; b=wA4XQNAon0JdwERWJYbg/LAIfpytCMUUZQmdROi1PsYaFmy16dPn682Ko5NN2MYwqICyyg /8QXwRI+rBCM6xRqRL+F+ZLNTVX6ck6E0zISe5WtEnPzK/29aZr6laZDLo8fus7BK/YpDS w9sAy0hG2EzBk2i6JsliI1/WIF+r6Uc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AW/E0A4I"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="r1j/YhHD"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AW/E0A4I"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="r1j/YhHD"; dmarc=none; spf=pass (imf25.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704212793; a=rsa-sha256; cv=none; b=10Dy8PiyBfEK2HIu3g6c8SJlKfggocbAHmO496bnU2Sknb799FtYhmzmj4MeXrDrcoZ+OH 9rCCZr23Vjox2B6Kh2YD4Cv7l2u55FxgG0x7pge3wk3y0N4w9oAX3/qAqRVVl2PzlPcmq6 +w4AZdn0BZyi2Px/5I0ivYmvKY+oRsY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD5F71F391; Tue, 2 Jan 2024 16:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704212790; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k+3oH/iPMNT8bmBQskJIGpXoOt3U91w4qjWruS8V3Ko=; b=AW/E0A4If4dx2OTElxgbDKLJwhpwlqewuqaE6LoJpKPjCXtW50uG/qnMjAlM+SG8pecLIa 1xsx8m5ygGDha/eVrVNZjX7/dD8TfvuqRzdoya/7KiFLTHgCGhh17oEYDPddqoh6s6OAoi JDjR/YNNEI6Q6l34GQi/j99eK7QOvW0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704212790; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k+3oH/iPMNT8bmBQskJIGpXoOt3U91w4qjWruS8V3Ko=; b=r1j/YhHDT/utugSFInrLSWVygnXjma1/M8zLTQLWAtexA1sOPfcxaenTHVkMSFwxDqo6+3 4VdrN6AKmFjftGCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704212790; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k+3oH/iPMNT8bmBQskJIGpXoOt3U91w4qjWruS8V3Ko=; b=AW/E0A4If4dx2OTElxgbDKLJwhpwlqewuqaE6LoJpKPjCXtW50uG/qnMjAlM+SG8pecLIa 1xsx8m5ygGDha/eVrVNZjX7/dD8TfvuqRzdoya/7KiFLTHgCGhh17oEYDPddqoh6s6OAoi JDjR/YNNEI6Q6l34GQi/j99eK7QOvW0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704212790; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k+3oH/iPMNT8bmBQskJIGpXoOt3U91w4qjWruS8V3Ko=; b=r1j/YhHDT/utugSFInrLSWVygnXjma1/M8zLTQLWAtexA1sOPfcxaenTHVkMSFwxDqo6+3 4VdrN6AKmFjftGCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C210A1340C; Tue, 2 Jan 2024 16:26:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tKs7LzY5lGWZfgAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 16:26:30 +0000 Date: Tue, 2 Jan 2024 17:26:20 +0100 From: David Sterba To: kernel test robot Cc: Qu Wenruo , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , David Sterba , linux-btrfs@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [btrfs] 8d99361835: stress-ng.link.ops_per_sec -18.0% regression Message-ID: <20240102162620.GA15380@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <202312221750.571925bd-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202312221750.571925bd-oliver.sang@intel.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspam-User: X-Stat-Signature: pezr95t895y4eiwpyf8kj5nssziy9omn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CF23FA0014 X-HE-Tag: 1704212792-518252 X-HE-Meta: U2FsdGVkX19ImNIqa9+P9i2N3jcy54Se3IZPfpnPekeC6MqQCgAXv+WMduzPxUfAEy9yDBuEzj8tXnY1TvskYAK0wYyCCIES/LttDkejQg5w5xbqTqxi9gJF+KpMJz+aklf+R9GUPY04Thcmz24qbo8A4U6263KoAIxCpmy63RtMtnEtB2TaEuaNs/ncR/QkCoPrjsRNgK1HmdH/T7nWCZ3xE8uoM8uVb5/Xm5kLL7sf/7LuGfoTEHe/XcnE/qi+HWSFD1OJ3vNLNEYgTfetmx7lMnOua5ecSpkW0b+zdy65HQBQ65ooessKB6lvSzko5yuu2ED4V9Fz/Z2SScyQyI7fvn7V/0ee7Kx0AcUiOWoijcq9An0Dx5HN96PyGUqO83wpe/u185CVXBvPbOirTfCfwLkvH/DAbbIGtfmcZruEA8q9+xtUGRgLWNx6WqIJ/7fj9z5r6epSEof7TXMUKAopLWd19GfKMqeKx5rR/ALUpvFyJP67cBlTngCi+waWItIc79ecVQMgPniEew0F8C7elyzgSDFwOdaWm2pfRtVK5JOSqxMUZ7M9/jD75A0kliiUHlWTy8XAv+BDGaE/E2XwVlKKQ/EMtus0yD+b78/9DNq1RV9dNg0tNaqPMh8x2kHWt0FUzWitcG/zTsOwGG+F/x8WfQsxn/D9YcqUvlRBgzzVy6ucO8VIHgaS1NBw5kbwKpY+JsFcMUAEhaqZzFVlSqPRLWE2OuZG8REqhTteCAwOiheYyYoBRcxGCJcH23WK/8JItLf2nrdEcxv6w8EYNlrL0UR0Ft10j6mQNo3lQjsMaxFifmelBRvDsXTv+n4RqBfQxpIDGkCegbUnvSG37rSj1LSfE/Ucx1ztcTkBi0nZZXz1faQTuy2eibKk8qDDWu9OUjZ4gQzA5uucbF/AJLbF3jHRZKHsQ6p/F1dFGM0ih0uxDEyxbIGisFe3S6HELEJI+ZTDUYtN/fC 5jba2ohb uFArfPmZpVMGcAUQXxp8QfDA/xzdcCD3xm9PO1rqs9J0ZkdXFGHbO5+tZHiENTVaFaQpavAnWOz6lsiO/1sV9kWYwoNOGDfO4DC+i0KCIvi0fdjDkucBIwnZfXi5TuK2q7sZfjO3k6lyo7zH1gGp8M+/X10HG3rQzepjAR2IstV+TF1ABEgUPm+uLeWceIFj3chtPmndwltInZcyL65JhZbz2/tDkYRfx4p0+QuMySiB+ixiGvjLypNTSRxAw0o0d1OK+jGsfV+0dNE/4fza9dKnAWrAR1NDvkTlyDHUTgy/sfWRsr1iGCeMWma4p+Prt7r+3oV7x0bNIcgnmGQ2kIo1kPJ8uPc+0mPBB9uX9bAH0SegRLafrCvO3qcYivecbzwnl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 05:59:34PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed a -18.0% regression of stress-ng.link.ops_per_sec on: > > > commit: 8d993618350c86da11cb408ba529c13e83d09527 ("btrfs: migrate get_eb_page_index() and get_eb_offset_in_page() to folios") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master Unfortunatelly the conversion to folios adds a lot of assembly code and we can't rely on constants like PAGE_SIZE anymore. The calculations in extent buffer members are therefore slower, 18% is a lot but within my expected range for metadta-only operations. This could be improved by caching some values, like folio_size, so it's a dereference and not a calculation of "PAGE_SIZE << folio_order" with conditionals around.