From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66426C46CD2 for ; Tue, 2 Jan 2024 14:57:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B6D8D0010; Tue, 2 Jan 2024 09:57:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F068E8D0006; Tue, 2 Jan 2024 09:57:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D801B8D0010; Tue, 2 Jan 2024 09:57:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C346E8D0006 for ; Tue, 2 Jan 2024 09:57:06 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8037F1207D4 for ; Tue, 2 Jan 2024 14:57:06 +0000 (UTC) X-FDA: 81634673652.29.95304EE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id 2D85940027 for ; Tue, 2 Jan 2024 14:57:03 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UPkFrzD5; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704207424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lsm9Z8oSWVZr6wzE5pLu0Eka6uF10LkWTmR40tX3qI4=; b=d9URcfbwwE7DGkdXwjjAm7cwGuGSV6wJXEy4cbNv5PEE7e4PRy/HlgETzS+MoH6xSk1Lj+ Uu+YU9sToj9awZPZ+xS5zoKN3n1SoGq/dAqpFi1Su3d3lkWq4sM4uf9R2kcmCMp7gTvgAx qzr6vOiEuYJYqP5YdJfbRLh5ZsgWuuk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UPkFrzD5; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704207424; a=rsa-sha256; cv=none; b=DWI1K9LbIyRgL2elnE/+j+ZfTcbuEVC7FaJZBNXmlWgfGnvXDhrVDsMIzd5pN2Tyg0dD4t p/8LElvtOd1nUmk39NHSUh3yo2z9lUZWbDJ1WOw6gRGD1dRMMn4gMwry4s07VEvQDFOzBz hXA2Vf7X2FVsEZVLj4A2qLEurskMKJI= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 402DiYWJ028306; Tue, 2 Jan 2024 14:56:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=lsm9Z8oSWVZr6wzE5pLu0Eka6uF10LkWTmR40tX3qI4=; b=UPkFrzD59Aq9QpPotaEKCmGGdd48wOVkpsN/+sKlWlyzH/BgAL+J8V/hik+EZZ19tTR5 IcMaxoe79klGubMjJBol10TIoDSWV1xZ3IQCd1TYnkEM0rw6bhkNvCxbCdk5x8U87qO3 ErN6FRxXvGfjzUal1+zT2Itf5pUGDtalbQ9iu1gpNk2KFhxe+BbMfryaFGxS5P++memF J2XrJZYcMKt8gCPKyqV4igNdGdtJF0a1W/zjcJgFu6EcIYkiI+eOm4wCvto6HQSnsZZE YEwrSVXgSYcXjmTnxR51KDWatQAh/8+J22E+SttKfA8OD4ptVWiAiaZTHv73bftBAhpf 0g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vcjquu2mv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:57 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 402DifJu029532; Tue, 2 Jan 2024 14:56:56 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vcjquu2kf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:56 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 402EUC52007568; Tue, 2 Jan 2024 14:56:54 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vaxhnwena-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:54 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 402EupRq9503450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Jan 2024 14:56:51 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 752C820043; Tue, 2 Jan 2024 14:56:51 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 582982004D; Tue, 2 Jan 2024 14:56:50 +0000 (GMT) Received: from osiris (unknown [9.171.22.30]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 2 Jan 2024 14:56:50 +0000 (GMT) Date: Tue, 2 Jan 2024 15:56:48 +0100 From: Heiko Carstens To: Ilya Leoshkevich Cc: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v3 26/34] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() Message-ID: <20240102145648.6306-D-hca@linux.ibm.com> References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-27-iii@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213233605.661251-27-iii@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0mYsWeZo8_mKnSAkujm5HJyJGjjC43NV X-Proofpoint-ORIG-GUID: 8KZKMcBNnDM3yBYkxj3czEh8Z83hu_tr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-02_04,2024-01-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxlogscore=704 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401020115 X-Rspamd-Queue-Id: 2D85940027 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1r5j448i55zuhmq8wh8rn7otu1tf35kx X-HE-Tag: 1704207423-970599 X-HE-Meta: U2FsdGVkX19b3uF0X3vlF+5KEWDXmlSYpsHfneTpHwiQ0dI6GAR86FpXCxBJmFucaAdgserkvtO0bK1OhgmmsKwkFW+D1meUbychMMvcXNTF/KZF1/qzhngPaOyB2LKkE9wqeJr3wwdd1m/pEqnx/tAPeePtVUod+juGUCu6N76dPvl9sR6PdIcRWeL4mkG620VcVi6KvNy7PVXKD5hsJOnYg7qYXEC7xRA8zvyfcOp0NiUuqbHmLTtP5565OH8Qhp6TJBppElDK/9e5qRCOCZtAoTMppXTA1jZv/lxE6CiGmRAPdJyuAXkos+a5xRH25jSal5Fr66FZ6/9sFJU2yNtyd7bJlAuBtD9jfMJ5oaVs5NDByjtj3XK6yDrqxpH5yp9lo7cupLueMD7TwCLpa5zyVNAqop5R5/JxNjCkyapS9bOgFh2r2w6cpTyOlqe0/0kJfGJnZeOiOfxjDrizGZk5ahlvnsi6XNC/vdwFjPS6KUgiaab4bTd7lW/LYRlOKVx8ktCamc/J7mIFctWpen+1RZKpgZArKiGAtG7aBifDme7ojd+2VIPd3mOgJ5t0OgMYxbUFXXgchsquL+IG3axLXKgaqPmU2osQv03ZIP6CYk89XXuzgQ4q4ZqPXJ0fyAe6PvTn3Z9TnSXLfU7s9PE/qx8SaDCfWDuWYSTPagJWRPXIGKVjH04ypDdj0ml4k0Puv7KqpkvAN8GUh0IYX1uPvy0htPW5qbfAlNL60bLUWMrUuUTKzf57RhaDXDSDimdqYhKenryJwAGll00LIPCFM/UKU5arG7w1UjgYDXLqO7/pBj03MkQ5B1A+w0783SPbNmzDsBpYQQpdogm1fcUxRjoi9rnvlci5RfJ9iXQQO3n3/mfC7sHVPnh7kbjRrbPkcOY5G51bARkIgWwaVYLDQGvC7wJ2n1eADGxD0TUkJi/fwKaT0mpEIyn8GBikOevfuZMtHew8oGaOk7f oOL0QNnX EeZVLr7njHnF18G9o/VFIYj+JbzKaXhkeXX6LbppzHd2HiljhRvWjeXiRKcd/S1i1TiH0YgdhmKBR1bB8tb2rxhl1g6d63kJF8vHTAmjhCkIPITA2b7bK8rZ0vaphZ+hDkNVUSG8qk3Ott6fRRs2t8dz7fQEYAXtJ0W7HHXkh+SPvGvYvC9AYtbP6oHULdlfqX0RFTJEPQYBZAArdN9lzetXO7oQxGdrh5XV8mViMS8UhfjGzV1uWU3S2OR74zo71uwGDn71o6cHCw+7YTcT/Ao4ksGXyRz2NW+S9/nSs4E2FL70= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 12:24:46AM +0100, Ilya Leoshkevich wrote: > s390 uses assembly code to initialize ftrace_regs and call > kprobe_ftrace_handler(). Therefore, from the KMSAN's point of view, > ftrace_regs is poisoned on kprobe_ftrace_handler() entry. This causes > KMSAN warnings when running the ftrace testsuite. > > Fix by trusting the assembly code and always unpoisoning ftrace_regs in > kprobe_ftrace_handler(). > > Reviewed-by: Alexander Potapenko > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/kernel/ftrace.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Heiko Carstens