From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9965BC47074 for ; Tue, 2 Jan 2024 14:57:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285988D0011; Tue, 2 Jan 2024 09:57:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C0B38D0006; Tue, 2 Jan 2024 09:57:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2F4F8D0011; Tue, 2 Jan 2024 09:57:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D9FF18D0006 for ; Tue, 2 Jan 2024 09:57:09 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AD5C0407D2 for ; Tue, 2 Jan 2024 14:57:09 +0000 (UTC) X-FDA: 81634673778.16.CE16DE5 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 73589120005 for ; Tue, 2 Jan 2024 14:57:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=FXbIqg4H; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704207427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bL+ZIKl6ttywS56QSUlX/YXzFOtll+hBW6t6aAV1Vp0=; b=KlPiFRSmaBKJz3wiYVRYlMB68+EsbO3d9uv/NYNiSZT+dnAiGuUTY+xj4pszLdp8gArpYu k1XXMZRRWONKCFZXoSSeG+w+oQlVIeESxa2KF7dL3UiAnc+iKjEHu1Z4+ivyJJevNwFwMe JqKFEjfTXbFY0kpT3XDMV8sQniNZQIk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704207427; a=rsa-sha256; cv=none; b=ZgGECaeamcob2mRt8Avjtt/sD6tp0J4L8XufQOrRQSFYRVOGH0XY17XGxFWFscsCX6unmo GhokIcJmrS7A8cywZBbKiLfqAsy5gdB6l9WaUz9CKGsij0YPeGIeJ85v2Mvc4leIWZ9yip hvBZ5Xp2UfEnN1eHOOfJn2qO62ooyXs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=FXbIqg4H; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 402EhEM2021402; Tue, 2 Jan 2024 14:57:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=bL+ZIKl6ttywS56QSUlX/YXzFOtll+hBW6t6aAV1Vp0=; b=FXbIqg4H6uJbPylH7RCPxkCCPirilzNe8hKTNicaeuAWBCv7bk14cvJG7UG6Wj6pzOqG 0MV1LxQTX10AhZ056a++KwE4/uQwt6gkeShrymB5sEeYt9T8WTLwoHx+KMNiIstjgX96 gqhM+2MdedhFfefj4k/fiOjfZxJfbl3tsitdBcT1/t8sLGnYHXwigZL8z3cTaOuDKe3R /gDW0xNyfeiOsOSKg1bSzE3eKXp7RObaTpHpGRfca3i7SandTgvPNsLFI4Ucl77ksyX0 5V8+XdJvDyK2zhylYrT8qWzuSD2Fo3wF72lpZhRWPxMuC3zpFYy+rSJtTe9/g136ORzM wg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vcmg7re0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:59 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 402EjXkx029393; Tue, 2 Jan 2024 14:56:56 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vcmg7rdpv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:56 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 402ED398007417; Tue, 2 Jan 2024 14:56:29 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vaxhnweh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Jan 2024 14:56:29 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 402EuQBv58393020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Jan 2024 14:56:26 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65FF320063; Tue, 2 Jan 2024 14:56:26 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 546F42004D; Tue, 2 Jan 2024 14:56:25 +0000 (GMT) Received: from osiris (unknown [9.171.22.30]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 2 Jan 2024 14:56:25 +0000 (GMT) Date: Tue, 2 Jan 2024 15:56:23 +0100 From: Heiko Carstens To: Ilya Leoshkevich Cc: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v3 25/34] s390/diag: Unpoison diag224() output buffer Message-ID: <20240102145623.6306-C-hca@linux.ibm.com> References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-26-iii@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213233605.661251-26-iii@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: RUOkeM2Jhk_VjhploDiahEDWYEBVFPeb X-Proofpoint-GUID: _T0ziB-ASJYSISr80eNxgXOERvkM-ZsL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-02_04,2024-01-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401020115 X-Stat-Signature: 39o51o9ghth1dd3qufnbkf5imqc4314i X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 73589120005 X-Rspam-User: X-HE-Tag: 1704207427-549696 X-HE-Meta: U2FsdGVkX187dEbgRiCU+ymKuuKlrpR8Mjdgfj7xhzhFakA6w3AT6f6BZwmKu2cbE8xKXHk3WNqwN++QcL1hLb7FTvJoHOse07fWAkL+qt1M4QNqm69ZizA4xOZqiMDwjucuUDI4lFHWgU+3sezrRMeAS+XV3NsrOnHqVYLxhMHjcY+R0LEr1znFcVx+wEtMNfOSO167SdDEMp33T8O62Oxv+ixkSnM19aMlezzzMc87R07YbX3J5MwD6nSKrNvtbvBOsDoD0vVA5vQHSXTTbmpsIrtzrJEFuzqENOdbTHmZh4NLpACBeDPMACRi0rSO4y6Kxl8o0y9C0UUEX42mZPrQuKXvDNhp/kU/o0WqA9J5aw+Pnv3obEDV0Oyi3/Ff9Gh88rMdbdCTeO0ci5yxoEAvOlpuUmmeFoZ1hUb/KbFoD36xEwNpupqceb+y7uuwBU9JsnbyhNrh9V19EpxVD+ZneTcPVJ7LtS72/PBRjRl6B0u2/aOQIuxmN9xuAnw4jA2JCkrsCShcKRdXM6Y1frwdTY4f/MuztBa8qBK88K9106Q1xGu0W+0trzjyURPPZhFGxjqSpidEBlMlWCcHWuaTsEceHFSNWO1Y3vqCniozzKBInYRRZkkuBo6o4m85rLGfBcS15bb5TxGswSjxEVqcOXZq7dJAygTTMFzr2EfB897IPZMFAwfDTB363srSMcFfmXyGwgbBDe69smm9Kl4AyyRtzikx45JkzZmkQ7zbz6MroTkekXrLWgVBxY3leui58AerCN4n3I2VakwDyCrJ3DGo9/M8mxQvBcAFd+9qJ9jHjgnCixLZoMc0qSezFe2nSd1aya5jOja+89SzRHsj23rttPQeW1ntVjsWsLcxfE5/acayviJ+9qTaDAhAlftlNJUPpIfcU2WaHE6GlUpMW2CpBJ9/b5wYmVfbG3Y1UXo9eDKa3oROFLZHqXyY00/eNPOvgY98lAJOsv9 yVCKccYD /NspTcVTUHjqLsg2vz9xkzLUb40o9C5iK/+CVX7zgvJ8Imt1xCoo+WcSDc0BpLfof9w7XQ9lwUjVzPWRB4AYQYQkyqxSqXg4XrlX0aBWjZvcjQDxiZ0Q0Bg9Kl69UcKXQbdkLHmhuc3Ss8Pzq2O3CHtJIfRT1zMn6GiyqXL9l+1CEVbXJCs4Zt2oNmjMGEp2JJb9Vx2+KEiFIKE56OwLZpIlRr77Zs+rMXkSF4l2a9AeyTe+b1shwY7NJNDGkCyR1d+UN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 12:24:45AM +0100, Ilya Leoshkevich wrote: > Diagnose 224 stores 4k bytes, which cannot be deduced from the inline > assembly constraints. This leads to KMSAN false positives. > > Unpoison the output buffer manually with kmsan_unpoison_memory(). > > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/kernel/diag.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/s390/kernel/diag.c b/arch/s390/kernel/diag.c > index 92fdc35f028c..fb83a21014d0 100644 > --- a/arch/s390/kernel/diag.c > +++ b/arch/s390/kernel/diag.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -255,6 +256,7 @@ int diag224(void *ptr) > "1:\n" > EX_TABLE(0b,1b) > : "+d" (rc) :"d" (0), "d" (addr) : "memory"); > + kmsan_unpoison_memory(ptr, PAGE_SIZE); Wouldn't it be better to adjust the inline assembly instead? Something like this: diff --git a/arch/s390/kernel/diag.c b/arch/s390/kernel/diag.c index 92fdc35f028c..b1b0acda50c6 100644 --- a/arch/s390/kernel/diag.c +++ b/arch/s390/kernel/diag.c @@ -247,14 +247,18 @@ int diag224(void *ptr) { unsigned long addr = __pa(ptr); int rc = -EOPNOTSUPP; + struct _d { + char _d[4096]; + }; diag_stat_inc(DIAG_STAT_X224); - asm volatile( - " diag %1,%2,0x224\n" - "0: lhi %0,0x0\n" + asm volatile("\n" + " diag %[type],%[addr],0x224\n" + "0: lhi %[rc],0\n" "1:\n" EX_TABLE(0b,1b) - : "+d" (rc) :"d" (0), "d" (addr) : "memory"); + : [rc] "+d" (rc), "=m" (*(struct _d *)ptr) + : [type] "d" (0), [addr] "d" (addr)); return rc; } EXPORT_SYMBOL(diag224);