From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9567FC3DA6E for ; Mon, 1 Jan 2024 01:55:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FD6F6B0260; Sun, 31 Dec 2023 20:55:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AC816B0261; Sun, 31 Dec 2023 20:55:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79AFD6B0266; Sun, 31 Dec 2023 20:55:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A6F76B0260 for ; Sun, 31 Dec 2023 20:55:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30E2440269 for ; Mon, 1 Jan 2024 01:55:27 +0000 (UTC) X-FDA: 81629075094.29.1E7E6CC Received: from mail114-240.sinamail.sina.com.cn (mail114-240.sinamail.sina.com.cn [218.30.114.240]) by imf21.hostedemail.com (Postfix) with ESMTP id B9B341C0011 for ; Mon, 1 Jan 2024 01:55:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.240 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704074125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I2+jNtGi2lJvwWE37E3mOCVXAt6+YxJ9zI8dQK5wuz4=; b=r6FKndBrIPfi/nzDFwN6tOFSWbjxyXQzVZKpbQ9anmuQjsCNlC3HcqtF1Q5u5yT1jQvo8f QDqRuD+RxSa6cJbULLnHCTIeiJMBIGmUeQThvKdkT9JpIALWJjaYoK3Ldz/JiO0vP+U3nZ P+N/ndNu39jK0ixoDM9VL3mwmGGrZkk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.240 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704074125; a=rsa-sha256; cv=none; b=GDXqtitGeje9zUQEiV9oYL93G7bE5/iYH9Xh78KYIAhjgPrf6rbDGzqT34KTSW9uv8Bmhf bdhQyWrn3+xMFbEEu/lQ2hJC/gdPB5SrwLBqKRhEKG1ei99DlqP2WsyIBMUaSjyPVAuBPT qcCg+VV7aRXhdEJmyMSAPOJJSuUPGTw= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.70.64]) by sina.com (172.16.235.24) with ESMTP id 65921B8100004871; Mon, 1 Jan 2024 09:55:16 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 15200245089584 X-SMAIL-UIID: 0DEB7DF064144DCD825404CC9C1C793E-20240101-095516-1 From: Hillf Danton To: Matthew Wilcox Cc: Genes Lists , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: 6.6.8 stable: crash in folio_mark_dirty Date: Mon, 1 Jan 2024 09:55:04 +0800 Message-Id: <20240101015504.2446-1-hdanton@sina.com> In-Reply-To: References: <8bb29431064fc1f70a42edef75a8788dd4a0eecc.camel@sapience.com> <20231231012846.2355-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 9no9wywp9dg1xk73n5w9axki4krskixr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B9B341C0011 X-HE-Tag: 1704074123-685305 X-HE-Meta: U2FsdGVkX1+OwsAgTyup0f5kveP4qlCrMR6mIWC2O+mQURIUmt6wOQKjyUNgsFW5hylsqyNhZUCAZ8PaD9LAMrhMxPIgx4hMBn/AekMGyeTz0vxFC+FTU4fmquQI4cWXgTntIgNU8gs0nbpzDcgZmZW9KWKmXKJ1ZX2Tn6WwSsE9lbiNfuEpRi+qq77RueImVPoZx94WTAXTPwmCXEU6eS8XqKhZlAG6JGMN/xisr+uQFMNDTbD+6K5fHZMP5Oim2y/fBl5XwajYkkiden5wWR/jKZr5n9PGfNBPwKIqur84KmOrcKGr5p17mRH/uViRtzo8NDSsAmNCCbkNjYVaHbEycVPjVzCbhDKoXBPMVIeDz+bdPBj5JE9YdeQEOI3u7GlhLVFiSlv7iGHnR86zWePpA/iVr7swGCDXLmEzTAPe+U06V0k4koLXD2reF+ro9btO/jukXWSoBaQmnF/HZme/MW6GfUY2Ng0CYLCgz7K9C2f5Q4k8PbJspNahdbbiAzXnNV8nVCNQE9B4il8eZB1BMofVma3sTGM0vQcio/6+C5AZ2JEtrcx4ya42cBaN3rFCIcp3nikpP0ONlguGfGhFpJcyjSg4lOzI0q4zVlm9X6+edDGbq4nw+PeLsF6eGJYiG58i3pQz6YoPhlgA7r0xRnyBt6sWOy1amqO087JkdEMbgiukNfftV52IpjI5UB/b//4IXiWeqyThVDTSLHxgrFeNDd0mZA+S7FO1zuiJpHmmCOi28PrvaiaHhaJ3ZAoL8zUrA0jdy51UhjEbtVv4ZLIb3A2Wvx35ywVAbmqt8XE5PkV5GS8oLeawGFAQrkskL+FIU9NvzaCfrjTT6PLKDUwh7hUBNGwS31562g+PM7a5vMByqPtWJbT8ssnGjwfB0JJkTy3OMP5cHsbKALuNE/lgRgxYkiXuQKUVuxYFLMJonns/7/gAy2gpwq9xI3gwHpISAu3+ADPkmfB wgGCsJBN gvHnC8/vMFFQn6cjpf2AEbdn7IhJ/Iv7ZQ+HBuJfyyVzrJOW4gOiKnhcXRJL2UW2Z0g76sMuHzBwC9gKo/i0MRBptkMib3rLFdBYEnc18mi9SYcjjejji2pVp/fLhOTShqL7ordzvGmUvkIUQ8f+pjn5uGfCo6nWBFyrguTQj6uk+b7hQMWsH6zb7OoSoZi3HT6UNY4bv5loP59C8UHmu72gVxVgpbDuUll8yVEY964jq8D8MF0VAZWIiL/X6lyw82/atdmAV5Ms5PJgcCfqNwganJAB3ax6S5jx87e4zneoe6VtX+xwwUyA/lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 31 Dec 2023 13:07:03 +0000 Matthew Wilcox > On Sun, Dec 31, 2023 at 09:28:46AM +0800, Hillf Danton wrote: > > On Sat, Dec 30, 2023 at 10:23:26AM -0500 Genes Lists > > > Apologies in advance, but I cannot git bisect this since machine was > > > running for 10 days on 6.6.8 before this happened. > > > > > > Dec 30 07:00:36 s6 kernel: ------------[ cut here ]------------ > > > Dec 30 07:00:36 s6 kernel: WARNING: CPU: 0 PID: 521524 at mm/page-writeback.c:2668 __folio_mark_dirty (??:?) > > > Dec 30 07:00:36 s6 kernel: CPU: 0 PID: 521524 Comm: rsync Not tainted 6.6.8-stable-1 #13 d238f5ab6a206cdb0cc5cd72f8688230f23d58df > > > Dec 30 07:00:36 s6 kernel: block_dirty_folio (??:?) > > > Dec 30 07:00:36 s6 kernel: unmap_page_range (??:?) > > > Dec 30 07:00:36 s6 kernel: unmap_vmas (??:?) > > > Dec 30 07:00:36 s6 kernel: exit_mmap (??:?) > > > Dec 30 07:00:36 s6 kernel: __mmput (??:?) > > > Dec 30 07:00:36 s6 kernel: do_exit (??:?) > > > Dec 30 07:00:36 s6 kernel: do_group_exit (??:?) > > > Dec 30 07:00:36 s6 kernel: __x64_sys_exit_group (??:?) > > > Dec 30 07:00:36 s6 kernel: do_syscall_64 (??:?) > > > > See what comes out if race is handled. > > Only for thoughts. > > I don't think this can happen. Look at the call trace; > block_dirty_folio() is called from unmap_page_range(). That means the > page is in the page tables. We unmap the pages in a folio from the > page tables before we set folio->mapping to NULL. Look at > invalidate_inode_pages2_range() for example: > > unmap_mapping_pages(mapping, indices[i], > (1 + end - indices[i]), false); > folio_lock(folio); > folio_wait_writeback(folio); > if (folio_mapped(folio)) > unmap_mapping_folio(folio); > BUG_ON(folio_mapped(folio)); > if (!invalidate_complete_folio2(mapping, folio)) > What is missed here is the same check [1] in invalidate_inode_pages2_range(), so I built no wheel. folio_lock(folio); if (unlikely(folio->mapping != mapping)) { folio_unlock(folio); continue; } [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/truncate.c#n658