From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AD8C46CD2 for ; Sun, 31 Dec 2023 01:29:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5368D0027; Sat, 30 Dec 2023 20:29:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A548E8D0012; Sat, 30 Dec 2023 20:29:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F4B38D0027; Sat, 30 Dec 2023 20:29:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7AB018D0012 for ; Sat, 30 Dec 2023 20:29:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E3DE14021B for ; Sun, 31 Dec 2023 01:29:06 +0000 (UTC) X-FDA: 81625379892.30.EDCA8DB Received: from mail78-58.sinamail.sina.com.cn (mail78-58.sinamail.sina.com.cn [219.142.78.58]) by imf03.hostedemail.com (Postfix) with ESMTP id AACC320003 for ; Sun, 31 Dec 2023 01:29:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hdanton@sina.com designates 219.142.78.58 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703986144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1EpB+RIDaU569xr49ozEnq1A7im/xq7I6VKW7+mx0t8=; b=Qg4fAkw1f6+J4vNrjshYd4T3mBanw714Cdcnznpi6qf2lQmLfm0s3eX6uTFGYlK27jtwZQ ZL43E5wj6C3wQEFTqie13xwiI2/iDhd96iC0Lgm+nCTs4dZA2yjADqQV3XAMyMqXwVHVP9 fn5TstrZorz3kU1Q6QoKZf6AyjfOd5o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703986144; a=rsa-sha256; cv=none; b=wme7QxpeHvqkRgLOTINAPCMEdDNhHOKjY3p7C2bAbEK9S7WfONn/vaYJwrpB/xiAburvD+ OnamLtYSauBduUizPmxRRu+FMqQNZKD9+bWKP95OiXvEttuI4NvqyXjbd7vN45VdwqKZAv ZXF8TDjXO+nw/Ce5VOEiebUma7SdHZM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hdanton@sina.com designates 219.142.78.58 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.68.80]) by sina.com (172.16.235.25) with ESMTP id 6590C3D700005C47; Sun, 31 Dec 2023 09:28:58 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 34086234210350 X-SMAIL-UIID: 17A82AA05F31419BBB3E201479107F12-20231231-092858-1 From: Hillf Danton To: Genes Lists Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: 6.6.8 stable: crash in folio_mark_dirty Date: Sun, 31 Dec 2023 09:28:46 +0800 Message-Id: <20231231012846.2355-1-hdanton@sina.com> In-Reply-To: <8bb29431064fc1f70a42edef75a8788dd4a0eecc.camel@sapience.com> References: <8bb29431064fc1f70a42edef75a8788dd4a0eecc.camel@sapience.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: xwbg66kbr4mbpbfxsw5u93occrcapdrk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AACC320003 X-Rspam-User: X-HE-Tag: 1703986143-662495 X-HE-Meta: U2FsdGVkX19Ycy478Cct5awraG9MOjSynhCCJLudpQfwbEqwBIMA+AF3G8lWeIQGTRL0nY3qKIAaijxAVP7VxFhS7m4EuDdH1xKcLPUDP2U9M4s0hiihg1TDXacmz6OT/z1EABlB/2EJCb2bekZoNZ9ASmRSF3fSYxN5cFYZDirhuri/YESr7Y8MoxJ8aRALDLWEhAd4U2oiThMrOdjDfQF5qHnAZQJHE8GyiVrIBpkI1vBEMDNLFi+m8g7z+ISckGgafkM7x2uopnXVe9YgKRRQzWC3s0o51QcHA688aChVo7b4rFt6aUX+nYZ5jepyOojoqckF0YrYVuArllhwbkJGfELORzMKYUlR5hgm5OLQORe++h37Cuwy4nPO5cO+uQvB1NJQNp2ZQNGyN1T9wxrxeLje1vBb75UJbwxyF/Bci/aI5pdcnW9Jitq2N1FBAgPNCdGWVaNo1Zm+W4n1wigvwBGqSbXKL/nGYwEXZROSBSjEmI4yIDfWSXG6ckdQljwjibOzc7ZOv8mYX2rIrClc7WybQk6r4VRwccVQEnmiDbXApTcGeuFL5ZkPD3MulzbMJk7uHBXlDTeVosE0Dm+4n3aS3tWjET6ueXCTCthwMGPMQxCVGpVRDd/yYV3Cw+xLeVQidOfRelw3PL3XjlenAtbePWKGyCIbdDUciVf+VjbsrpmSjd8UeStV8Beyu3MqesAUAv7e/64mp37fPonJAJbGnfxcmbHVlc/Vx5Uu6aplrAbUS2mKGeG/phv4E7U0gnT6011kqS4OMM3TVCJZCls1Fss2k9IH7TbPI9e8zeL3hzUpIBpaxImSwn1pYpDw6oTN7pAJEpsoMB0N5EH73fxOQB5gfusVYmvmJQr6yhlIWKzXcl8ApIb9bNBsGkLDYgDlUQbbqJ58s79mXANXmqm1fdaFxWBI5gOQZReZsthy9m6m3EeIw37dA3mQ+rytcLW4pjEKfKVIYZZ UnU2vh9s nWR107lOWtUFRcTRpys+jQTGCzUYJE5r5V8cGeiwtL9dioab6Eq3TZY2RKaZSJlz9llYU9Wbfz3a4aZ89xVxt/il83wx1oUI+3B7EGmTOG4wDhvFJv6AjgBdncEZm2WIptCtAmUx2qTV4jDlsnUp3FaoBh40k6/1y1Vwq5ZVdJwCMEe6v0iuPvnkA4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:23:26AM -0500 Genes Lists > Apologies in advance, but I cannot git bisect this since machine was > running for 10 days on 6.6.8 before this happened. > > Dec 30 07:00:36 s6 kernel: ------------[ cut here ]------------ > Dec 30 07:00:36 s6 kernel: WARNING: CPU: 0 PID: 521524 at mm/page-writeback.c:2668 __folio_mark_dirty (??:?) > Dec 30 07:00:36 s6 kernel: CPU: 0 PID: 521524 Comm: rsync Not tainted 6.6.8-stable-1 #13 d238f5ab6a206cdb0cc5cd72f8688230f23d58df > Dec 30 07:00:36 s6 kernel: block_dirty_folio (??:?) > Dec 30 07:00:36 s6 kernel: unmap_page_range (??:?) > Dec 30 07:00:36 s6 kernel: unmap_vmas (??:?) > Dec 30 07:00:36 s6 kernel: exit_mmap (??:?) > Dec 30 07:00:36 s6 kernel: __mmput (??:?) > Dec 30 07:00:36 s6 kernel: do_exit (??:?) > Dec 30 07:00:36 s6 kernel: do_group_exit (??:?) > Dec 30 07:00:36 s6 kernel: __x64_sys_exit_group (??:?) > Dec 30 07:00:36 s6 kernel: do_syscall_64 (??:?) See what comes out if race is handled. Only for thoughts. --- x/mm/page-writeback.c +++ y/mm/page-writeback.c @@ -2661,12 +2661,19 @@ void __folio_mark_dirty(struct folio *fo { unsigned long flags; +again: xa_lock_irqsave(&mapping->i_pages, flags); - if (folio->mapping) { /* Race with truncate? */ + if (folio->mapping && mapping == folio->mapping) { WARN_ON_ONCE(warn && !folio_test_uptodate(folio)); folio_account_dirtied(folio, mapping); __xa_set_mark(&mapping->i_pages, folio_index(folio), PAGECACHE_TAG_DIRTY); + } else if (folio->mapping) { /* Race with truncate? */ + struct address_space *tmp = folio->mapping; + + xa_unlock_irqrestore(&mapping->i_pages, flags); + mapping = tmp; + goto again; } xa_unlock_irqrestore(&mapping->i_pages, flags); } --