From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF64C46CD2 for ; Sat, 30 Dec 2023 11:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EF5F6B010D; Sat, 30 Dec 2023 06:43:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A00A6B010F; Sat, 30 Dec 2023 06:43:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4684A6B0111; Sat, 30 Dec 2023 06:43:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 322696B010D for ; Sat, 30 Dec 2023 06:43:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D1599403CC for ; Sat, 30 Dec 2023 11:43:51 +0000 (UTC) X-FDA: 81623300262.25.4B5D62F Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf21.hostedemail.com (Postfix) with ESMTP id BE7D31C0016 for ; Sat, 30 Dec 2023 11:43:49 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=rtItvV3f; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=ZhOK0LBZ; spf=pass (imf21.hostedemail.com: domain of greg@kroah.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=pass (policy=none) header.from=kroah.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703936630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RDMzNXeoRcXtTozgalvQ1v7S9gcCF0W/23GWD67Yelg=; b=MvrVl2sJHNY4AxDwNnAmQl2PVeIP+EVbsEaRjs2kL5h0jooKghYFpSgP+YQ94wI/eWdRWq +T/6nd/qnNjZujoQ8qpNLNNred7XtnDg+VYajITFhT3aLX+Lv1NUFCO67TvbtS3FHlwxF/ hi6WxNWnNDbvv0q+xa5QWWY2Yaeul44= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703936630; a=rsa-sha256; cv=none; b=roH780gw+DU5rKP+KkijorlcIIiKdqO9C40+3W81k0kPX3euE5OnBd+7d7dCYtFOGoKZAY hXyWbboFajkwWqdaH1HbAOL99EPms2xPmkBlnl60iA6GJKIyft45u93bw6fg8C16WV8TmB GafeQKcP6coeWkAY6+kqxG3i21k2B58= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=rtItvV3f; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=ZhOK0LBZ; spf=pass (imf21.hostedemail.com: domain of greg@kroah.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=pass (policy=none) header.from=kroah.com Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D6BA85C0075; Sat, 30 Dec 2023 06:43:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 30 Dec 2023 06:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1703936628; x=1704023028; bh=RDMzNXeoRc XtTozgalvQ1v7S9gcCF0W/23GWD67Yelg=; b=rtItvV3fct9Ah3tKmTbcAT+uro /8gumEOF30bzbKOqwjqcRllVZmBQPkn99DlIR0/NHH1R8jkAjhlFp3/ncXdGdj3l A/6p1FANm2O5UE+zY60kaaUmMARtGeDgayCODji3pDdCso1b5qslEOQaZP88+24z Z0BkybZk7MfkpKuSCwzrc2ZhPG0CsAhZKdkqWK4XmnpqBYeLZRo2cOfVvBxTnfOK lfBo8HKZ4vteixcWMTmzZBlOzot3xWnBetFYT6pX4hBvT2N/i90/N7WlIlUtkdZb oj+GjB7lShuyQQtRCm4Uu9c4eebrxMSNrP8/SW32slFyozjYdGxSA9uJddfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703936628; x=1704023028; bh=RDMzNXeoRcXtTozgalvQ1v7S9gcC F0W/23GWD67Yelg=; b=ZhOK0LBZRGNZxTF7TQ9YpCn1UYZkqTyTW0WKhBC2Av8V zqhUAaCDhEMWP0uaRG2+RmIE+Ra/FAFT8esGtklM92Xdn5DMK4TP7KyGJb9AyHUd BfeFUwSigl/+srUQB0/VKpOWj92YJZpQRf5Ih2allHdvToJBONXrBy5OoNcajo8l siWvQw1tjOVNRPXoV1vJkoS2w1zWja8su73SkjyI90/iqFAdLaG3b5h3Tg8zAxsf 0XDDpx2/urcS5xv8hTtKiB+8ONfejWGyvgEeDdfuYUadt0BzY5r5zXwazhxCEYyD 3W3+xodNudClje4KKFMmowDaMNVMxaGWPLQpA+HP3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefhedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Dec 2023 06:43:47 -0500 (EST) Date: Sat, 30 Dec 2023 11:43:46 +0000 From: Greg KH To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, zhangpeng.00@bytedance.com, stable@vger.kernel.org Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores Message-ID: <2023123027-baffling-arise-63bf@gregkh> References: <20231212195255.219624-1-sidhartha.kumar@oracle.com> <2023121847-cope-surviving-26bf@gregkh> <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com> X-Rspamd-Queue-Id: BE7D31C0016 X-Rspam-User: X-Stat-Signature: 4ngwpb9fd314744iutknd3pw65mn4f7t X-Rspamd-Server: rspam03 X-HE-Tag: 1703936629-245569 X-HE-Meta: U2FsdGVkX1/bVf0cWcuKU9QuLbhGFirgq8jXvPdL0VcBT+x6VH97LOEu2FFwf1yR5XXesOpVDQY1qNKkVIrCFX5skqlX+Fx815lunR4+8kxwe+cvjNxCjZZ8cSItZsvkUqL/gutGvRN1JBk+R/zMLYjvbD8jafcazZtsKm+BJwLdGt5xyKWhICZzkLmkxR07Rp7OM86QutBuf3J74FcKC5XCVJyWJhdGpfmzNU6f+7iDiEQIjb+WHidXg1LVEMgR++0r9ivUt8IvCP5E58DClyMHa8zuKkuZ17fJjn/zafXJpu/OSpSD+jnlWMP/JzkN0RFjyLDuA2VWA5pqTySOL811K0OFPLR6sqxMWiUtmEhBjKUWv/hqmut7CzzFsfJ+bXey1S1nAxjplz22kvRYZxfy2Jm60ODMxPYawYzTtXcIxgJSQYEqfd0Wcw0k7xx2Jek8M1ARt/ts5WCSLjkatCzNKKqlMMKytrUY1zkdy8PmpdE9txghPV5uVC0dVwUd83DMEvhSURMlJx7HuijjZiAX02yC4MmwYUK2GaaZPWX6OtYsa3CbvIAt49+HhJdAqaMOP4s5lO1KEpMF+naUA4E5BxkHCw4ma6JiYiGyFa5/IujNIXmkzaeeO1Pn4nE6vMYI6QCrJw2XY9Dgim3LP5D1RbFubrEL6Kokl8YlBaiti5ObX3I/Fm7XGC2V0ZKOGZJSmVmNSBPv67uLnvqcQzUPnRPsrTrmjoWvHetrsGTP4///8K7ByRQGfbPVMmDjD1aol1xFggWpVW/9cDbwmBi801VlKQCcUw8Gt1VNEQ8BJ4B4DZwT2+P1G24scQvziptXpvLLhES7EH7nf/D4+B6dm4YfT28gAD1B+TM47sl6GB4KYsFYTtCqCdzB7b17BQTWl7Ci7do3zEPGERdKYH2hw5aPkyEqibjQqLLhUcBGcRApzU7e9adQ+MsaZBxU9bPFTCEcdzQUUTIK/A2 YHre1cLK yW3KeVZDv0pdGQrO9XRAwFtaAxfXjthe4/yeU+/XihLUf6upGZexx14Ovw3bh88tCtpeNkJVcc/CQYAu+LqAurk1AL0eY7pp8UD4S5EDET6WLl3kCvk7WbetPRumOLhjmqtE4pFknB7S/GI66N8x/CvFqClyf6+PihmzA/WzneY4HVSxOWWqTEMtS4hP4Xj53w6lAOZ1cfmdpOwRp0kb3M/qam4PHyYXekLVzr4GUTmHCXmvqGh/fhK0n/g38QBamL4FNQmXbac7AQW5IjQL005NsxwoI3mrUr55TD8RVtT7ecJwnUgWlNqvGtwGc8ftOeSYWJS9zqkxv0FdbEbopF2bScvHtQhwuVbW0cnHUAif+IH/usLosqEtvDaWi+w2HlVaF5DqBgRnQbho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 09:53:53AM -0800, Sidhartha Kumar wrote: > On 12/18/23 2:59 AM, Greg KH wrote: > > On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote: > > > mas_preallocate() defaults to requesting 1 node for preallocation and then > > > ,depending on the type of store, will update the request variable. There > > > isn't a check for a slot store type, so slot stores are preallocating the > > > default 1 node. Slot stores do not require any additional nodes, so add a > > > check for the slot store case that will bypass node_count_gfp(). Update > > > the tests to reflect that slot stores do not require allocations. > > > > > > User visible effects of this bug include increased memory usage from the > > > unneeded node that was allocated. > > > > > > Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing") > > > Cc: # 6.6+ > > > Signed-off-by: Sidhartha Kumar > > > --- > > > This is a modified backport as the patch to fix this in upstream does not > > > apply to 6.6 because the node_end field was moved from the ma_wr_state to > > > the ma_state after 6.6. > > > > What is the git commit id of this change in Linus's tree? > > The patch is in akpm's mm-hotfixes-unstable tree and has not made it to > Linus's tree yet. Ok, please resend when it hits Linus's tree.