[PATCH 1/2] mm/cma: Move opening brace to next line for coding style

[PATCH 1/2] mm/cma: Move opening brace to next line for coding style

[Malkoot Khan]

Move the opening brace of a function definition 'cma_for_each_area'
to the next line which resolved the error

Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
---
 mm/cma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/cma.c b/mm/cma.c
index 2b2494fd6b59..01ccd26e8bc2 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages,
 }
 
 int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
+
 {
 	int i;
 
-- 
2.34.1

[PATCH 2/2] mm/cma: Use 'unsigned int' for cma_area_count type clarity

[Malkoot Khan]

Replace 'unsigned' with 'unsigned int' for the variable cma_area_count.

Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index 01ccd26e8bc2..dd3c39d30ad6 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -37,7 +37,7 @@
 #include "cma.h"
 
 struct cma cma_areas[MAX_CMA_AREAS];
-unsigned cma_area_count;
+unsigned int cma_area_count;
 static DEFINE_MUTEX(cma_mutex);
 
 phys_addr_t cma_get_base(const struct cma *cma)
-- 
2.34.1

Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style

[Matthew Wilcox]

On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote:
> Move the opening brace of a function definition 'cma_for_each_area'
> to the next line which resolved the error

What error?  This seems like the _wrong_ coding style to me.

> Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
> ---
>  mm/cma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 2b2494fd6b59..01ccd26e8bc2 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages,
>  }
>  
>  int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
> +
>  {
>  	int i;
>  
> -- 
> 2.34.1
> 
> 

Re: [PATCH 2/2] mm/cma: Use 'unsigned int' for cma_area_count type clarity

[Matthew Wilcox]

On Fri, Dec 29, 2023 at 03:32:38PM +0000, Malkoot Khan wrote:
> Replace 'unsigned' with 'unsigned int' for the variable cma_area_count.

Please don't run coding style tools over other people's code.  Such
changes are generally unwelcome.

Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style

[malkoot khan]

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]

Dear  Matthew Wilcox,

I hope this email finds you well. My name is Malkoot Khan, and I am a new
member of the Linux Kernel contributor community. I am reaching out to
express my eagerness to contribute to the kernel and to kindly request your
guidance and assistance in this endeavor.

In my initial attempt to contribute, I encountered a situation where the
./scripts/checkpatch.pl tool flagged an error, specifically suggesting the
relocation of braces to the next line. Following this advice resolved the
issue, but I want to ensure that my approach aligns with the community's
best practices.

I would appreciate it if you could review my correction and provide any
insights or corrections if needed. I am keen on learning and adhering to
the community's coding standards.

Additionally, I recently watched one of your maintainer lectures on YouTube
("https://www.youtube.com/watch?v=LLBrBBImJt4"), which was highly
informative and inspiring. It played a significant role in guiding me
through the correction process.

Thank you for your time and consideration. I look forward to your valuable
guidance as I embark on my journey of contributing to the Linux Kernel.

Best regards,

Malkoot Khan



On Fri, Dec 29, 2023 at 3:38 PM Matthew Wilcox <willy@infradead.org> wrote:

> On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote:
> > Move the opening brace of a function definition 'cma_for_each_area'
> > to the next line which resolved the error
>
> What error?  This seems like the _wrong_ coding style to me.
>
> > Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
> > ---
> >  mm/cma.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/mm/cma.c b/mm/cma.c
> > index 2b2494fd6b59..01ccd26e8bc2 100644
> > --- a/mm/cma.c
> > +++ b/mm/cma.c
> > @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page
> *pages,
> >  }
> >
> >  int cma_for_each_area(int (*it)(struct cma *cma, void *data), void
> *data)
> > +
> >  {
> >       int i;
> >
> > --
> > 2.34.1
> >
> >
>


-- 
*Regards:*
*Malkoot Khan*

[-- Attachment #2: Type: text/html, Size: 2959 bytes --]

Re: [PATCH 2/2] mm/cma: Use 'unsigned int' for cma_area_count type clarity

[malkoot khan]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

Dear Matthew Wilcox,

I appreciate your feedback and understand the importance of respecting
coding style conventions. I apologize for any inconvenience caused.

As a newcomer to the Linux Kernel community, I am eager to contribute and
willing to learn from experienced members like yourself. If you could
provide some guidance on specific areas or types of code where
contributions are needed and welcomed, I would be grateful. I want to
ensure that my efforts align with the community's expectations.

Thank you for your understanding, and I look forward to your valuable
guidance.

Best regards,

Malkoot Khan

On Fri, Dec 29, 2023 at 3:39 PM Matthew Wilcox <willy@infradead.org> wrote:

> On Fri, Dec 29, 2023 at 03:32:38PM +0000, Malkoot Khan wrote:
> > Replace 'unsigned' with 'unsigned int' for the variable cma_area_count.
>
> Please don't run coding style tools over other people's code.  Such
> changes are generally unwelcome.
>


-- 
*Regards:*
*Malkoot Khan*

[-- Attachment #2: Type: text/html, Size: 1555 bytes --]