From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FB5C3DA6E for ; Thu, 28 Dec 2023 08:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4075E6B00A2; Thu, 28 Dec 2023 03:59:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B7A66B00A3; Thu, 28 Dec 2023 03:59:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27F8E6B00A4; Thu, 28 Dec 2023 03:59:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 189386B00A2 for ; Thu, 28 Dec 2023 03:59:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DE2B3C0816 for ; Thu, 28 Dec 2023 08:59:31 +0000 (UTC) X-FDA: 81615628542.07.6A0E736 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 18A3340014 for ; Thu, 28 Dec 2023 08:59:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="VPt/k23K"; spf=pass (imf04.hostedemail.com: domain of jszhang@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703753969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rbu3zDK4egabfYRNLq5ZDg2lMGMbWX/VoBKV5Lc26JI=; b=ntpS0Em+CGrLuxsaMBbesy2WeFqE+7iiqCORbnX/xK50sKazLNG474/Wmcib03KcKDScC+ ohF4dgZSZ24xTYzQ+BLlKM4PyHvS0PGHG7/zhUcJDjO0Nd8CmQQ4iQUsgk8IzP/x9DAHuI 0yAQL1TH1y5SZ7hSjdnUbuvygTtrIgU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="VPt/k23K"; spf=pass (imf04.hostedemail.com: domain of jszhang@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703753969; a=rsa-sha256; cv=none; b=QQLGm6DUXlZWV9CKXF10qbl4KvcAtfi9o2HJkrMioNmi83Q5qhvJ8D1Ecsn8NAOs9LJIm+ +qHd1J6cIT8YZR5IWRCLBYUtXfx+hBm4vBAAVdi146gQTkKwpd8KwBZNjHj7wIk4Iw0Ucr ajB+FKMRGnjqaRNGpB7jF76sx1NDAY0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 89025B80D97; Thu, 28 Dec 2023 08:59:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB820C433CA; Thu, 28 Dec 2023 08:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703753966; bh=16+Nu0Wb1JkSQStq2mcU9kdq58a4r2QX4o0XnGMbW1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VPt/k23KQR/ek+Wk4Mb0Ffgqjpr0C4tGoF8uMnFE+csMqgfr093NXmCFQN67kLxmg 2wX671IgLVNFprhYGlOqZT9sQd45M//tMA96Y48PuyxuAUw2YYrGJheIf3jUNzegsO oZr1LwJ+Pd98LSUtkZQ1GQJGY/kKAzRUqhRAQ2LGss8txZ4sD1RLgnpeb+dxBj+bEm lTFy+2WWHg42Kl6nbbR4U7U8bNB7+1AF95XqLf72vf4OQxZI1A08+R/V8QaP95mAv4 W39UhXGY1i/064M112ShThexcH0ieACEEyC3qc6Oesf9LT7f5gDAuaHeHCYJG86mq+ AIf2i7+FdSkcQ== From: Jisheng Zhang To: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Nadav Amit , Andrea Arcangeli , Andy Lutomirski , Dave Hansen , Thomas Gleixner , Yu Zhao , x86@kernel.org Subject: [PATCH 1/2] mm/tlb: fix fullmm semantics Date: Thu, 28 Dec 2023 16:46:41 +0800 Message-Id: <20231228084642.1765-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20231228084642.1765-1-jszhang@kernel.org> References: <20231228084642.1765-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 18A3340014 X-Rspam-User: X-Stat-Signature: 65rcaxzzopkg7fr4httxs81dmdj8biuu X-Rspamd-Server: rspam01 X-HE-Tag: 1703753968-457635 X-HE-Meta: U2FsdGVkX1/qj/TomgDKQbVtKlJ8ulwRxlXNBK1qjyV5j8961KLZxSi23e9UF0XFTZHo9Xg2hIfO9H+2/UprxJXZZ1PUy+baMACDj9xvA8Vt1o9mPkm7MnSiSiiVUZY5XIjpfBNqdbmX7d5kpPgD5yLoD/YUkQbvbV9PCnzF9xmw+osbYMvnc6vZg4tAjmptSuzzYsWLhHL5kPTMHrTNh4WEDkE95ZZa01ZnKYSneFOvGJSvX3AdoZSpakqyhitadC1uRDpZrKotw9LJ7c0BS6Y46xHjopxqftj5le49jDyUz4eFR/YYupLUHe/4HNXEy+pYm47i3foAog3wlbOtaCh6t7JJX0WYvM13cDcthfvI+nluNkQ/Ql0/pn53xxDijiLHUBFEky4UrszowiAH1v9bjUpqA5Y+sCkD+aosCS5llPm2U8IeVTw3Nkb8xNFg/zO7gamfbHv/Kp8amcECHJlVewqgSqlVM0hgNB0ixbatI5aavPK9ItpBNQVAu5CpBzrGex7OaVF1nCbj8JcctUukrfi3M0X2wRkmt5WegyATUtJZpcNmnQ1BjVqhW2HvQonC/GV0EUk/A5pTaYyA7F8Zw2194MY7ftl+avDA5Wexge0mf1Y+YNwuvGYYuXu0hEPDokaZygcTnuA7JWEGVx2TIFWJ9/3oUu2n0rqDWJZAPpjWs0FivfYfgJpCYHoETEU9Suv4WnrtGGxvnYBintQF6DQbFw/tkyovrnZ2gi0RIODSjLEx6Djd/apP4hzoGDNq9ecIo+Ql3qKttailv8Y5Fu9fQzH3nSIBXMpY4RqJsRlZOwmBv1VJCj70b7SNn3e9xcfs63AxWm2P2B14TLrU0q52PUf8767O9LmaHqjcNDRQWDWR2Ixt2MK+2eM0b4j8mR6BGnQ7Dg7BJwottO4hl4p75a3k8ERfxRq7T55XRm7ODMJQ/cHzzcZ7+kIfY6pR00lfxu9xsspXV3m fyf8fjai fxzfANJkp6MpcuUkI0rPzuDBh/oCfGxyIb3owZBbZKMoa3N2UgjuVNp5F6ahd9vMBzVLFT6ZmoEspAe3dTiW8In6rB1go+HjMmbESimDs9eVWt17ZeyUrg3lmgtAvMPM/6NVtta0lTAcyk2MJeifwDMvPaTC56av4afABRyxtGfNdzlXpzzj6RBHM/+J+PI1Crn5lg5TRHX3es3dGbtGSoE1yXeaKXQx7URm3KKNj6T2YJdJBMZ1XaKcoURuRgP8RSLLSK0/2hAkjhLA4YX5IEV6VMB4pgZmGuctUDmSXwG9ml4UfkYbXeTOg5lto+pdt/zVovGBt7lF1mwBY9xAMiwSN00bXxAlxok9mm8Tilj4/Ji1yIX2uWBRiMvuC6jx425EM2wjvkeltjg0jYXUeCLNfLIXwQ+EF/sMYm6g7nTBu5dlha+64X1Kcw8rv3mQjyGjszZJCz218UPovC+SIj7eVXBV+vXsBtpnD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Nadav Amit fullmm in mmu_gather is supposed to indicate that the mm is torn-down (e.g., on process exit) and can therefore allow certain optimizations. However, tlb_finish_mmu() sets fullmm, when in fact it want to say that the TLB should be fully flushed. Change tlb_finish_mmu() to set need_flush_all and check this flag in tlb_flush_mmu_tlbonly() when deciding whether a flush is needed. At the same time, bring the arm64 fullmm on process exit optimization back. Signed-off-by: Nadav Amit Signed-off-by: Jisheng Zhang Cc: Andrea Arcangeli Cc: Andrew Morton Cc: Andy Lutomirski Cc: Dave Hansen Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Will Deacon Cc: Yu Zhao Cc: Nick Piggin Cc: x86@kernel.org --- arch/arm64/include/asm/tlb.h | 5 ++++- include/asm-generic/tlb.h | 2 +- mm/mmu_gather.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h index 846c563689a8..6164c5f3b78f 100644 --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -62,7 +62,10 @@ static inline void tlb_flush(struct mmu_gather *tlb) * invalidating the walk-cache, since the ASID allocator won't * reallocate our ASID without invalidating the entire TLB. */ - if (tlb->fullmm) { + if (tlb->fullmm) + return; + + if (tlb->need_flush_all) { if (!last_level) flush_tlb_mm(tlb->mm); return; diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index 129a3a759976..f2d46357bcbb 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -452,7 +452,7 @@ static inline void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb) * these bits. */ if (!(tlb->freed_tables || tlb->cleared_ptes || tlb->cleared_pmds || - tlb->cleared_puds || tlb->cleared_p4ds)) + tlb->cleared_puds || tlb->cleared_p4ds || tlb->need_flush_all)) return; tlb_flush(tlb); diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c index 4f559f4ddd21..79298bac3481 100644 --- a/mm/mmu_gather.c +++ b/mm/mmu_gather.c @@ -384,7 +384,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb) * On x86 non-fullmm doesn't yield significant difference * against fullmm. */ - tlb->fullmm = 1; + tlb->need_flush_all = 1; __tlb_reset_range(tlb); tlb->freed_tables = 1; } -- 2.40.0