From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A61C3DA6E for ; Thu, 28 Dec 2023 06:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B8EF6B0071; Thu, 28 Dec 2023 01:27:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5685B6B0072; Thu, 28 Dec 2023 01:27:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4301B8D0001; Thu, 28 Dec 2023 01:27:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32DE56B0071 for ; Thu, 28 Dec 2023 01:27:42 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F7B71A087D for ; Thu, 28 Dec 2023 06:27:41 +0000 (UTC) X-FDA: 81615245922.23.2D1B075 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 6B36DC0004 for ; Thu, 28 Dec 2023 06:27:39 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=WxH8G9yO; spf=pass (imf22.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703744859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ezcMWpqhmHAMLrYn0+Q9MY7X5OW7VKM8sl5WwMShxTE=; b=aSYwaC1nWh5NW8n8kFtmEfUjS13JvNMo99mblhgzACW2+Wkf4L4gAm6FmGNzv6qZ3SDZfY VINjzO5g2JfarjwqonL5P/MMZLWEA78P8n7FD3VlpL8S4YAid6dZl58jPSvk5twZLl+XTB cGuvgG8O+fjm8vKkcwFOhpj7v4tbXXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703744859; a=rsa-sha256; cv=none; b=BbhD5UiGG13ABQHON/4Xicf3PwMy3Jvo2R8oAp1sC2qk74JxYs5XhqnpR7QJnBvDHagGM6 OzNGD+EN1iQRr7PlUVHeiXde8lfb/QdbOPLpGSpW5621K2a8RzjpnC7NL1HFBggc74Q6mu KxlvspLBChk3J1L6cUJQXkSv6vKd1Z4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=WxH8G9yO; spf=pass (imf22.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6dc1fdc19b6so13377a34.0 for ; Wed, 27 Dec 2023 22:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1703744858; x=1704349658; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ezcMWpqhmHAMLrYn0+Q9MY7X5OW7VKM8sl5WwMShxTE=; b=WxH8G9yOdu8Rpn1u4pBfGzQcVcJh4bPAJkcdZF6S5j/OLgbnfXEnIzrlIYddGKAnME C0LYy1/Y0wYwlQKmn/VwwTWHiPGKlahC+M7FvrzH/pOiGlrVjYPTazSeclO1ck+KtCpC SdxU68QnprfumJm3kjDwSK+NYlZNZF4wFc84KkW66GuIEOG/gKaWtA8aaAGi6BEDrFHO SYAbjxaayQQQo25NP1zGJ8odSMTXQT6T1kd8pHpqaq4+JtWd4BuArpqjZXLUuqYvrq9z GWBU2oKKXgk3zE06paJvM0EVJawTd7qVgDtzPwYFo6kyOtmfFQZV90Zvuq7X2NYVNRMY 1FjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703744858; x=1704349658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ezcMWpqhmHAMLrYn0+Q9MY7X5OW7VKM8sl5WwMShxTE=; b=l2iCVi3WBmeosMU3pV95QQziquVkW+8ZjYGvUFqqSyz5y0eNDCdg2ayStdCgFNkKJ0 XkebDQBPP8Abam28wD3nTqHsJ82OC+Z2YbpwKadV6uhMwew0uR7I0UnSGFqo6SJ3ZeuI 5juKURg8HhmHhCWB18yRz3Or0dxqsq7E3ucshpzNCLv+OtEHesl1DNdp/F0LIjiFwMGi HxDbS0N3xPb9Ixx0y4qK/dFXUDXMTtrvkXBve15fobaKcG88HnwuPAIoj8U3qy6DbUTH Yx7Gkk1haK9D9g3z7XqWvCosNfqRzuxWTGhwZ9rgob3+i2SEaP/3rV0/S2qeSD340Ogx u0BA== X-Gm-Message-State: AOJu0YznfcLKPE51mBJoNj2U4Z3XcL4fl5HTP5f2+UCu57TDWqHjfaZR 6/tkTn3Jez5hA56xKlalE1Irm5RC3AuWKw== X-Google-Smtp-Source: AGHT+IERoZAaKW1da0vPwR5UnXPl5D9HGEMteAVaBdugBeFgLsr210XyHAAiaMtP+HF1RTPmOk4Sdw== X-Received: by 2002:a05:6830:610e:b0:6dc:1ddd:b7ff with SMTP id ca14-20020a056830610e00b006dc1dddb7ffmr188180otb.49.1703744858464; Wed, 27 Dec 2023 22:27:38 -0800 (PST) Received: from ubuntu-haifeng.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id g5-20020aa78745000000b006d9af8c25easm7681381pfo.84.2023.12.27.22.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 22:27:38 -0800 (PST) From: Haifeng Xu To: roman.gushchin@linux.dev Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH 1/2] mm: list_lru: disable memcg_aware when cgroup.memory is set to "nokmem" Date: Thu, 28 Dec 2023 06:27:14 +0000 Message-Id: <20231228062715.338672-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: riotrd17iuhcdr34x1kn41ayyj6kjsuc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6B36DC0004 X-Rspam-User: X-HE-Tag: 1703744859-264950 X-HE-Meta: U2FsdGVkX18AYIZ83KTS00qh8y/26nZrFmblpgb8D63KlFfO5lEg2zboadYSb7s4u9pGM+7f69GyTyPyh1wtvO1AWDvYIi/+2+gHsts3ko6HFCAeekVlih+VWYQDixOAFZMUrVQDQ1by9laAE25NgidGTOdYVJ2/k/uWGgFij2HA9BkVwZSut6ilxqpr/VqMVvavA0b8IghnRgC/JpWl2By3dHNGsdWD6KaKq9YDzcKXvE9QwHzUORHp7CcEiIZJc0rAVVnVgDpUZ16841LDGg7x1+9L+0atStmtZhMgDR8H1HlipatzKureJJDcjqYqfa8+S51mfMGdTsALBh8zey8gLBfKlbuPL0XfcHXG2cSuT3FpudMsOVfYNX+r3bODzPiwFlOYkpkoHSVJArAxbPuB2AV94SLlos+cPGLgOIiOHMqNJXBpAiLkn0RyJTrIx/HYzp8aOBcoeXTO3q71tGbOSCfiJXTeSDiOTsOVjc3tK6fO1CdqakVKwwh5sljcKMp843cMw5YZgmb7g3wEKoaNDzrw+qBYlIqEEEKVggqq8mB+bAyeV1xO7scJ4qx5GD6/tYw1IcOIkeCQ5Dhbn04wdd5JMHLWB/tTwS5Q2/wJRUv1h2PUSDt7D7mc5EjbQ6KA6e/cWSnB4rbfrLSrCsgdthRuwfP5NvQa24LDsrEbb3M0MkslpJv8HMHn0kuk8JOpEt6/L+JLkUT6CbZAko0UNLteALSRVHniK2ScE2NzzP1UFiNrNLsFIMcdHgljwF6CtP8lWepl8ZKfccFONUqC0wz8Rn6N7EYJ4ALG+P9pKJzups7N9M+dd3N9qyMw7OgXbQ9mJa/RIVsBECTpbfMyBZu9F35Ry32FcBSxdv4aZ8CzwH6oYiLcx169zTWVuqP0H5okzLgpdp/S8LbmOSZ6F/GXyz6VwQWpcUqoC8Vjbvhwa0NOhPkW03DcNRZwvzAGiVT8lMagECwqw7g hgXdBefJ zb5DacXl4aPkq8LOsn7FGRPJbw4gJr8gGzv09uXBHhb2b1qrcoBM6a7W3EZXKfkdekVJfq+b+n4aaw8FUEbVQysitlfqEWbXOu2LzYOmU9dC/PhI3g1/4NhKbgpVe40qWqWTmt7kuS6QVWyhzoMHT5qEowZCDhrwJWkTVY1nyXiRoHqqXOuSalHX4JOExdaNAIFDTPPjtABLfpOR6K6am11zIxoWrGjp7e7uedzGauOO7SV18aN+nzMW0G7j5gLAyKvPZylczI12CpVdUh96c+yISeoI6qoAIZ4oKs03QOXdxb+J8Bc5aedO5Y130rthNe7K1u0WAitie2sLH8FWztWiX31RrWJ4WAFbrfRyM7uTqa0NST27vWBJiGzS62wBJ/zJwWBSILy219cupdZXyjU3wdlyOrzipPPf7NuSgY6rKxe7WUR437KcsRvwQSmRlj+vS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Actually, when using a boot time kernel option "cgroup.memory=nokmem", all lru items are inserted to list_lru_node. But for those users who invoke list_lru_init_memcg() to initialize list_lru, list_lru_memcg_aware() returns true. And this brings unneeded operations related to memcg. To make things more convenient, let's disable memcg_aware when cgroup.memory is set to "nokmem". Signed-off-by: Haifeng Xu --- mm/list_lru.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/list_lru.c b/mm/list_lru.c index a05e5bef3b40..86f63c92fd88 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -566,6 +566,9 @@ int __list_lru_init(struct list_lru *lru, bool memcg_aware, lru->shrinker_id = shrinker->id; else lru->shrinker_id = -1; + + if (mem_cgroup_kmem_disabled()) + memcg_aware = false; #endif lru->node = kcalloc(nr_node_ids, sizeof(*lru->node), GFP_KERNEL); -- 2.25.1