From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECA3C3DA6E for ; Thu, 28 Dec 2023 10:48:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF9FE8D0011; Thu, 28 Dec 2023 05:48:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA98D8D000F; Thu, 28 Dec 2023 05:48:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98678D0011; Thu, 28 Dec 2023 05:48:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9A4D08D000F for ; Thu, 28 Dec 2023 05:48:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 688D3160857 for ; Thu, 28 Dec 2023 10:48:00 +0000 (UTC) X-FDA: 81615901920.02.C8289E4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id 4A0C1140009 for ; Thu, 28 Dec 2023 10:47:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N0lbqOyo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703760478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Oj5V39vAkN1/+i+CrgR3hM1xoyNKUjIkt8y2kK2itI=; b=Im1TYhWa6BGTiG9pGXBUkhC/2G5wZl9YcXyQsIII0/sw7FDmg0xTviOYeLU392S8iSVVRM LgzdfJnwQwtPMWo4U0g70aNtE/5CV6qWbPuImSDACEl45KNhL/vXn0hdIxR3Szp0dVLh/h Ksuulj8gOX3LgY3R7A7NPJss4FHWkyM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N0lbqOyo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703760478; a=rsa-sha256; cv=none; b=mByWOqRepJiXSbHBAzJCxsIguUqcREMwTIVvGMSpVPCXHwQKVSeFjsgr6cClLeyx89DzAO TpPTcCmjXhJF6YAGLeA5TzV/j34z0aIoPJTtvd/0J9GmAv/h3EZvDKxZC7J2sDv6R6CttG en1+7ue2kWe/pKdahodUve2BZv+uW8Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AB1F5CE1397; Thu, 28 Dec 2023 10:47:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32363C433C8; Thu, 28 Dec 2023 10:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703760473; bh=5Oj5V39vAkN1/+i+CrgR3hM1xoyNKUjIkt8y2kK2itI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N0lbqOyoJyeMAeYseh2byh6ANjb73lLSFoo/4Vf3UE84vYDk1TieZPcsFMbb0loqB J5c41nJjfroqg+lE9GGc0kOGcMTJxCy3AYauRg4GYPutMX/m+iGhLmhRqkfKY8IoEv HQ6gkkpXqpfaUSwSu7V7SK0kirgYW//TghKZrO0OFcZ8vFivTervREY8Iia7YzaARU 4nrS8pD062BAXhO50kSt3MeaqULSjKL976XU3bOxCS4tcxu9/yoI/LjuylHOVl+oXi rYFTNFdvU8qGKDS84wZ+xsCp/I0UcygpkM55NDFDntoL8POVYFgAFXl/4qpQMmPknr lSRN3+TRLr3ug== Date: Thu, 28 Dec 2023 11:47:45 +0100 From: Christian Brauner To: Nathan Chancellor Cc: David Howells , Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v5 15/40] netfs: Add support for DIO buffering Message-ID: <20231228-wohlbefinden-museen-c5efad4e0d84@brauner> References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-16-dhowells@redhat.com> <20231226165442.GA1202197@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231226165442.GA1202197@dev-arch.thelio-3990X> X-Rspamd-Queue-Id: 4A0C1140009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: uqbmoqxzu5kehjpx9664sd47xo9ips4i X-HE-Tag: 1703760477-215717 X-HE-Meta: U2FsdGVkX18hrhE8weFl2ic1jsv24tS9c+b8tNKARE0O7b6AIPnH7sapErC4fEMPb6BtSDehq9SIV6PItN3lHsK6iD78XEhvJmlNN7SZ7X//AovMeTJxTSCrVXgKFKgiHFchOXcIcmmYqIc18YH44hhNESwTQshXjXpxpWbgOHU/dNFivItPpFx4tweJxhKNUH+GsLdZwlBY4XNqB5GlU4yx+q2IU4wUnNcSLCuHGM3F035B68mWSZbmjdlnC2ZHx/QkV125y2XT5rtrZa6Qi6HhD8wX4UTQTd+gWx1+vYpuz+E9lODulZlUlPAUlVWKiGO9BhKGLDsOjpo++ZkYK3KMncjqTrdWjOeKMe6AJkbgNdjUxdbUNIrc+EjzNKaLoDBZWKkyDPJASu+b/EM2xMQdKmjkwEhbNcWobS5eL4DINcFY0/tQVlDUkKqW7Agbj+cSz9NBgzgSfQ1kAcAWcF3jITnPwuTJUNB9+d1Py26OaXq7Y+2a1eC9RR2cxOY8fE2Go7OHOr0orDYungJxreBbMzjdD3hF6e9tLbaDuDYrZQVekCSSQNLJSOH+qGGEhqOBHNLiXN5Btive3fqMcyQcnHbOyQJwjDLoVFE/WPkr2C1rzCO+aK1DbfvMmh0f2p1m1wEPKq6E/rnibC6XZ01RaXVhqBvKJdHy6Llf0tS13uogPoMdPQ6bQHxpDVGsB4OVmQJgF94hT6UVX9BBB6pT48c7Ql+drXHIPNaKmGR30OIPd1twsBMg/2aHIE3rdKkYDw6tC+36EkikuUrql+P8FqL+SXAhJWuPmudp/1HVNf5Bl5dUbWg26hI/VnlrglqQZKxh8Ankrm5OJZ4rYeW8C9p3gbkjBWmD+yfrTvCXrbZDCKI8BlOJSSKC18ThsSSaP9JkEGXxxeeel9dkatoG/0suYVJftJ5NQTl5WcVkil1+ekPjY/J7r1ZqEwaP8y06wESKF3GdGCgHw+k f5spJNY/ FDMXa/1nh5dsZM8QODqzm2bEEIWMfAhjvqHOy5eE3WM7n/9ObVZTCqMmJx0tjsXZQuG6WokLxRfpgMJS051iTiLAgV9m4xIBfo09+ovyv87qxpx2J3sfA0VP1Y/0fMK/JO7UxbAxnhP4dVzVEmrJ08/toBDO3BfHqD0FK5oiVsphqp/LtSEMM+XrwmaP/E5SmpfAt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > This will break the build with versions of clang that have support for > counted_by (as it has been reverted in main but reapplication to main is > being actively worked on) because while annotating pointers with this > attribute is a goal of the counted_by attribute, it is not ready yet. > Please consider removing this and adding a TODO to annotate it when > support is available. It's really unpleasant that we keep getting new attributes that we seemingly are encouraged to use and get sent patches for it. And then we learn a little later that that stuff isn't ready yet. It's annoying. I know it isn't your fault but it would be wise to be a little more careful. IOW, unless both clang and gcc do support that thing appropriately don't send patches to various subsystems for this. In any case, this is now fixed. I pulled an updated version from David.