From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA1A3C46CD2 for ; Wed, 27 Dec 2023 22:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD856B007D; Wed, 27 Dec 2023 17:10:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D196B007E; Wed, 27 Dec 2023 17:10:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 245496B0081; Wed, 27 Dec 2023 17:10:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 14D036B007D for ; Wed, 27 Dec 2023 17:10:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D4713C0235 for ; Wed, 27 Dec 2023 22:10:13 +0000 (UTC) X-FDA: 81613992306.15.E87F1AF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id AB48D1C0003 for ; Wed, 27 Dec 2023 22:10:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=djtb3RQw; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703715012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mvbWQPtLRjTEXBG8qxYD9GJ79sXogi23Rjf5NvvIXn8=; b=XqN+gtUUj24etL2ITRLNvNCji7zyeUiU+A7/pOFDmqX9zsAvdavykv4J4absIkUk9teLuj YnthWZS6VIpz8w/uYbz1QUDqGigVCQFd25YA475W12k1i59CVk+CAWnClG4iMn3QNcf3U9 m3+5e39aIr47eCKXhvTuVmc/XoYJ//Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=djtb3RQw; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703715012; a=rsa-sha256; cv=none; b=6QBnbXENX9AEvt/UAyU/vsEUQ1afL8n8Tyg5AvU3Vs3EXq7NtrLqoSTisfk1qbKyiU7bJt +9fD82s1WwV7EI5NgOMvStT2OfeYDVTGue54gU16Pzh3BgADdEH+71mbP7/FhahzFUtkt/ Z7Mgzm3LzKpHzFeK4cM8MkygneldVWA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D4A49CE1312; Wed, 27 Dec 2023 22:10:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F36D5C433C7; Wed, 27 Dec 2023 22:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703715006; bh=IsNop+8agQGKkYo5eY0cj9pIaFJSRadegBPPU7K7vBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=djtb3RQwHbPOU168xGDiQ8WhknSl4qCpB3Dv5B2/0wTgBHtMmISEw4rF3MGjEPt0R QA0He0895rEtX5IBfbdy2LI/LlFvrnjJryGTDKw6dWQ5LkbRh/deDbJR+wQ3+ZArd0 7Qb8LvIurV67ebK/j5NSgPR+5c+BqVHFk0pbNnEo= Date: Wed, 27 Dec 2023 14:10:05 -0800 From: Andrew Morton To: Andrey Konovalov Cc: kernel test robot , andrey.konovalov@linux.dev, Marco Elver , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm] kasan: stop leaking stack trace handles Message-Id: <20231227141005.14e278c3f08dd0d64004dbf7@linux-foundation.org> In-Reply-To: References: <20231226225121.235865-1-andrey.konovalov@linux.dev> <202312280213.6j147JJb-lkp@intel.com> <20231227132311.557c302e92bdc9ffb88b42d5@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB48D1C0003 X-Stat-Signature: rpstbekahurx66k7bta17crkczfc8wmk X-Rspam-User: X-HE-Tag: 1703715011-612304 X-HE-Meta: U2FsdGVkX18DNnyACBKN3HjRyysM23k/AMALxmx9ZPzdock9RU06NahY104QFelXlxnKWdQW4HtWgffIIEM2WlIeGeRzNR7ZWdEOQJaUoi6SRTEXufRS/ShyG2HMmtgIQ99dWT3dNHi/4Pjfse7a11tkSxDbEmhKyBLxFsDoL2WAyEfc5FyrgdWKyBN/ZfcYjFjYAC1sKKZM10txY6o+0Lozgad9Rznzhl7slADvq2qwIkEY1rpiMNI5CGcMBrF9mSAU+1R76dlkUthdJTP1iWsK4G24aN5JqtHYvcLt8mdeshJCvuvcbT5aKBnqyYUvULOnFxfRt+nAJgQ+5CIEE7bV501ah7615AK1q34OQtpk5KqBalNDvqFl8jBXTDW2+NTOSl9mbVnJMRSCx44QDfERRti1stDyEsF3rh4jscsOj0qaHrELbzzCaJPLEvKRJ/cSNHyZfqltWmQf3R17Dvib3vFNHFi8pjaDAqAm4PinzuzGRVog+FCKrLWzoohWpml2Ut+Pv1AFp3nIcEqxSSa04Z/3MWU2DxPwAE2yJxUOHQAo4Y/HUsiuD23oVkvWl7c1tXb+PCTFFCCU77K/8PPibIkFhTd7teJnCQCFKlxtQEag4vowwk/2ZO2Z5jb1Nrhr0fco5hbCxsgJZl51dgXhhvMXI+aoRkJHgEM+r5aCvqAyolr1n0vBbKjYO4zF3DCZmzElb9yLHVH91gVsZeJUaR5ez1b5wjbGd1fo90hUvKvnfGua7fji+wnSzuLBEQlwrOtdlwPD4RkcHtnSTU4z7mXWwcZ/M2MWZHtOf46MN76a49RtQpH3v1m+r3w7mmpwoDxOKELO5rJ2+unJtzm+IXHtkiCji1uUzU52qUidbk3TsxaSBgXjxUq9czIMaqyG31jGOk7pI/2Bvc4bTnjmRo/sHAr/4G3yCzghgv2J+nGbQ2sUErm3p1Em81sTfEh4b6j2GYv8O9+NqSD PGEU5b/Q kplLUHEfzmogETOIFnM0u+L7ovUjhfslxUfxmfG+gnS1P35Q2HOwx7I07OlxZi96yq/nI54qJ3l7/2gpHQXp4pRsAy8z1Uf9csNUS3kg4cKsRmVNOnMPpQlMnDuLVkCepqZdvoyQfOVSaQUYZ4yWRc+LY3+jbXfk4wMxM36qu2WCil7iv3m+DkmKya4oWvNFSW5HV4sAfFAwTrr4Dn/hfFE9He54dQIGHO4bxyOAbGeR8OL0aZGhu279YtbVBBukCNvuXF/G3W0tbSaVqTQNMzMywzxvMqQ2+hRkZZavvfd+yrkScKLiQUw8RDtPE9DxdYJXtk2ebETsUqp3YdqOKJH16Pt0byuOv9N/7KItF1ezGswDKE5qaqLoNlJ5rAjRELTkW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 27 Dec 2023 22:42:40 +0100 Andrey Konovalov wrote: > On Wed, Dec 27, 2023 at 10:23 PM Andrew Morton > wrote: > > > > Thanks, I added this fix: > > > > --- a/mm/kasan/generic.c~kasan-stop-leaking-stack-trace-handles-fix > > +++ a/mm/kasan/generic.c > > @@ -503,7 +503,7 @@ void kasan_init_object_meta(struct kmem_ > > */ > > } > > > > -void release_alloc_meta(struct kasan_alloc_meta *meta) > > +static void release_alloc_meta(struct kasan_alloc_meta *meta) > > { > > /* Evict the stack traces from stack depot. */ > > stack_depot_put(meta->alloc_track.stack); > > @@ -514,7 +514,7 @@ void release_alloc_meta(struct kasan_all > > __memset(meta, 0, sizeof(*meta)); > > } > > > > -void release_free_meta(const void *object, struct kasan_free_meta *meta) > > +static void release_free_meta(const void *object, struct kasan_free_meta *meta) > > { > > /* Check if free meta is valid. */ > > if (*(u8 *)kasan_mem_to_shadow(object) != KASAN_SLAB_FREE_META) > > _ > > > > Could you mark them as "static inline" even? That's rather old-fashioned. Nowadays gcc is supposed to work out whether or not to inline things, and we override that with noinline and __always_inline.