From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 700B0C46CD4 for ; Wed, 27 Dec 2023 21:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83CCA6B0072; Wed, 27 Dec 2023 16:23:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC166B0075; Wed, 27 Dec 2023 16:23:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BE506B007B; Wed, 27 Dec 2023 16:23:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 597056B0072 for ; Wed, 27 Dec 2023 16:23:16 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C8B1C140854 for ; Wed, 27 Dec 2023 21:23:15 +0000 (UTC) X-FDA: 81613873950.01.B84D552 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 09B3E40014 for ; Wed, 27 Dec 2023 21:23:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lFZ9Bdtz; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703712194; a=rsa-sha256; cv=none; b=dp24O5mmJI3xHs5VoN4vKD7yACn6yXsgdq+7+pp7WRWwEL7vwd1/GHqWRdG8qY64LVfY9k e6N4lZNFkv5cyDk6tAckpwzhin9HMzcuH5bjVh+mHB/nfKk6Vf+AcNlSB1+vcU1sYUip35 oCoGCxtTUBgaP9V3cx4R72rc7mtkCK0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lFZ9Bdtz; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703712194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lH+yqWGjh2MCQCB0UFXTbcgoswKLu3j5XuXUnRonSG0=; b=YdaU6yArarqC8ROEH7dE07/lQnOTeTMYESlZJpYxFV4FgwMSKEpsUwy3Iukwkv7/FZTHDj OiwmNHWDJp5bUHEv2LejRrrHNnIPSi/v7DVAh4QQwJfbAwWTgklqezBSPTfTBwK/0dUzki tJnwRbbvY8WQ/uo/Qh6KoTZQpN67ELk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1358B60F8D; Wed, 27 Dec 2023 21:23:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6691CC433C8; Wed, 27 Dec 2023 21:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703712192; bh=vZu8FSzIX7UcEH212Eu6LNhd6xH4C5oYya52gCy+xVs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lFZ9BdtzGo42rCUgHCykvfhdymFe2PhbaiOqqbus8bEaL5rBt6DaaGhII9vG1DEof GvlX6Kgoy6wCELqUajcE3D66+d2oBX+n+iHX/qJ0eRpg2C4MaHS84KmopPgO5CKbis LwxaDIHCKI0I9xrj/5/4Dm3rxwOfGQOYQnGSwYa4= Date: Wed, 27 Dec 2023 13:23:11 -0800 From: Andrew Morton To: kernel test robot Cc: andrey.konovalov@linux.dev, Marco Elver , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm] kasan: stop leaking stack trace handles Message-Id: <20231227132311.557c302e92bdc9ffb88b42d5@linux-foundation.org> In-Reply-To: <202312280213.6j147JJb-lkp@intel.com> References: <20231226225121.235865-1-andrey.konovalov@linux.dev> <202312280213.6j147JJb-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 09B3E40014 X-Stat-Signature: k515wh3yir13ar8j99rcfu846y1d9r1x X-HE-Tag: 1703712193-536412 X-HE-Meta: U2FsdGVkX18g51jisApeAcfJlscLNlsMvepRH7aBUvfJfT8uJCzO8VQoqqksKqEfYcAcaoIEnPE1pCOOr6bp6LVy28V5EloSv4dxJ9cI+L3+CU57pwtLcmsbSe1iU/3N3a6i6e0+Xxk4LHFuvZKkPqXytGGGvSguaP654wJh8nSq61QdO4WS6hqOJbr67Ndm1hFb2+otuESEK7N53gRnQok/LXM/Is0tfUOziolETFCNkqo7cGSrQ1XzqGkwl8WwjkoZYkODUUtiCyuXFb3q9E80ehk/bxQDHmDIIZSoSd3J/D1URsvj8QOEfG1aK12uSYbPVeKfXNKqx/0Jryr7B/DbnJpssSyQVNlSDQ0lIH5dLh0L8DuwJQ4kkSxEodks+Tiq8EbiUgv57LtkfZq5Gsgakbr97ZFJTSE/BtOwU3XRmomKvAXbnLsKhA5tqgCeN8Z7WSt/UlRRwHnm9cVPuv9qE5YA12XarwblhadD15VehA/M2NSmF4eZYQV3iNcebSRQEACqXU7jqYZ37I8wg5nmfMIKGmTZ+SxeCOX7UGWyLKtBC+dtOdqJiqWVLpCxFTXx3SAYLC71N5z0Ngt6dqaBZ86ywLiNbGf35PMzKDrKLklB4RSTOrwzKZDlExAMTVwHFXsp7CECfX4qLGFb6rJGQmyJ1N347AZNGxNS8Fsb9CUM0Uj7rSMAPYKirBiGVSJ5Mc0gt8cBe9YDnR+CEQHoLDXUOKa6yqOIsOr7yJxOrLWl+J4oAko7GujHFK1G/1WXRQ8hAR4sJoaWlE96wZvfrUGait2AYFbTZyecajUgjYVGdX54J/RVLKiDvCbqmI4e6IRL5iCimGyDzJOKV54JexZJY0qEujI8PGcaHdLmRCHFIRgu9FeH7wHUBpPJtNTlhxK+DxXbZz11oVSazonkTBFjEG63ug0oskDXvojuiT7UGiqymkFhw1CLl/tlMAgu7Fq1OS4CZMIf6Su XFjIiyEe CqG6YhmmV4R32INV2NsgrkvXuLKLUlsZJORVhokuYJfR//UE1vteBw+SQUirJ8AEl5L9RclplFNWoGTCf4znJkRrbImVdEO3z6yNQDzvVFHBr9ftOO/RdZxP0S3vqNsJVcfJNECcTQKNLGvX1GtQ4730h8aKPnxEAl8mhPZDq5jx6p9XAW/57tW1E5uHaFHA7Y4mv+A62i/UfvtzQ0k2JDdGIC9aNB0+7OegO//fpVfdDxD4XsrG2QeV8Qb9eCRLmbZQDcPbY/PH+T6RNIZpVjHqDw5Qj8MgV4AASNIyGnT1tnOXqn7GE9//XOOsPJraBUoNtxmBeljO7kk/u6a/4ucwhmP9O/AqZTvPz8uY7IUv++GG79vymFczVa05jic4CFqSHomM6xqIoHkA6gUana9vdCYgbZw1KZ+WWAJrjxPYnn+H/Vjh2h0ztjz8zbWk9elI6sy6ZkdODmZEeXWXOT2kT7QhbtsGoEXL6+aTLWF4H03J7gYNyvWTUQcvcDuHl2bzuvwNfFAmL62I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Dec 2023 02:19:51 +0800 kernel test robot wrote: > Hi, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [cannot apply to linus/master v6.7-rc7 next-20231222] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/andrey-konovalov-linux-dev/kasan-stop-leaking-stack-trace-handles/20231227-065314 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20231226225121.235865-1-andrey.konovalov%40linux.dev > patch subject: [PATCH mm] kasan: stop leaking stack trace handles > config: x86_64-randconfig-123-20231227 (https://download.01.org/0day-ci/archive/20231228/202312280213.6j147JJb-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312280213.6j147JJb-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202312280213.6j147JJb-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/kasan/generic.c:506:6: warning: no previous prototype for 'release_alloc_meta' [-Wmissing-prototypes] > 506 | void release_alloc_meta(struct kasan_alloc_meta *meta) > | ^~~~~~~~~~~~~~~~~~ > >> mm/kasan/generic.c:517:6: warning: no previous prototype for 'release_free_meta' [-Wmissing-prototypes] > 517 | void release_free_meta(const void *object, struct kasan_free_meta *meta) > | ^~~~~~~~~~~~~~~~~ Thanks, I added this fix: --- a/mm/kasan/generic.c~kasan-stop-leaking-stack-trace-handles-fix +++ a/mm/kasan/generic.c @@ -503,7 +503,7 @@ void kasan_init_object_meta(struct kmem_ */ } -void release_alloc_meta(struct kasan_alloc_meta *meta) +static void release_alloc_meta(struct kasan_alloc_meta *meta) { /* Evict the stack traces from stack depot. */ stack_depot_put(meta->alloc_track.stack); @@ -514,7 +514,7 @@ void release_alloc_meta(struct kasan_all __memset(meta, 0, sizeof(*meta)); } -void release_free_meta(const void *object, struct kasan_free_meta *meta) +static void release_free_meta(const void *object, struct kasan_free_meta *meta) { /* Check if free meta is valid. */ if (*(u8 *)kasan_mem_to_shadow(object) != KASAN_SLAB_FREE_META) _