From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED69BC46CD2 for ; Wed, 27 Dec 2023 18:42:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5067E6B0072; Wed, 27 Dec 2023 13:42:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48F8D6B0075; Wed, 27 Dec 2023 13:42:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32FED6B0078; Wed, 27 Dec 2023 13:42:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 20DC16B0072 for ; Wed, 27 Dec 2023 13:42:53 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EBBD61C1020 for ; Wed, 27 Dec 2023 18:42:52 +0000 (UTC) X-FDA: 81613469784.24.5AE85A4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id F3E4F40013 for ; Wed, 27 Dec 2023 18:42:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Odl1enjz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703702570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MACIlCAS95kGuZkxL2PTIu24keiO1gQsykhtQwu7Crk=; b=VTyRUqSQdic9oOm8E+QbjOWF/lXyzYaLj2/BgO433/4V9Wq+nijW26dfUweyWE3iswzO2j nOjlWWt3lPLPkdZTkNc3pddkzKs2OGUrbGR5WpirvQiNefLCy0VAMVtJjSbYTVjaa/8HLH OWvNbVoww73hgzEkLBdMJ8V0LanHQhI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Odl1enjz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703702570; a=rsa-sha256; cv=none; b=z+x/og0vFn3m1GlckNX5nCEer2odXrq/6XQc+7ggWbsTAYzQXf2iUwexQv/rxW89Mt5jpl xkHmOMCcnyR7EfUIprPI36q4gMVWrbSSuQzFltWhLHMOTepb8bxLhzw8hG2NlYKWDUxSr3 GdICpWGrioKleHl+qD2hms3Akq34308= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 68A50CE11BE; Wed, 27 Dec 2023 18:42:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D7FAC433C7; Wed, 27 Dec 2023 18:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703702565; bh=Itb1htvmWYpO4t/GAfB1X1BEGP2JCKRav8Pymo8NuEI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Odl1enjzu74MzygvCIiuGdQhGuwBJGYIrfEtU38Js+pJaoZgqZtkgAzxnt8KMGu1Z HnIBfcbwruRGCu4fnHHGpQUY7F610YMk2gcSRgtmGCxsz2CP9vBZFtS/g54K0EOiqb vXLQMw500IYoKRuQK2K0rtEuQiKxOdMtZzsO8p2I= Date: Wed, 27 Dec 2023 10:42:44 -0800 From: Andrew Morton To: David Rientjes Cc: Pasha Tatashin , Linus Torvalds , Greg Kroah-Hartman , rafael@kernel.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) Message-Id: <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> In-Reply-To: <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> <3d415ab4-e8c7-7e72-0379-952370612bdd@google.com> <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F3E4F40013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: t34radcjit3siuonmepam5uutkq5nxst X-HE-Tag: 1703702569-89358 X-HE-Meta: U2FsdGVkX18X0wkRnrvv4ABqAw6OZhhPVTCV+TS37RO1KkjKIbIdbE6hGFQaj3eoBQW+J5dXRX11G+NSNxIGSG2cpR31x82wdUif0zLgfVK4HgpidsADO3btjOcm2gbHSpKU9hFZq6PMvdRz5r9rkZj5Yd7IPp6EGuwvOXGnjGYXaHvVbymHzO6J7H91D3Kk4nyTkWMo1u9NeKwebY4/Xdp4EOQG6hTkx9zXLYw9xeMgoseTfG3T4jmi6e7L8FBXAX6HnWufNDyeEVG35Ips9GzZnV4QkdFVBbQjuQpnBLPm9tTXYfX1gX2WyVu3Ccc7m2RhbAwceFwMWtTUVHivNRYV4UqU9Ic2LGsRuZTpojYP2bhihCJHfmFS85+7lBffRX0bzK7AEiZzBnlwfMJRwktSFMDPM9RTK3YEuYc7u+JYfmVdilpMCDjwDsWJ2kXkDy/RKCfQmubA4xOuUIYY1LiCOqdk/aHdS7y5kcVJcXgveU7jpvZFkfZZRd9lmoUyuiwwt+kdtlgnfFkjBLBWu/kgb1xiKgL4u5lZF5DuUgqKuQUKfkqGNDQDNCXhlaeYt/Rji+AZVgKMXbX26q6Goq/3QFVTH0j4Ae/MzSDVPtsQeHZwr2qaixPNx715ybWk1ZBcP6De4mfaWt330DS8LOio703zBzeESjeYIV3ovmbNESIQQRTyA8pIUmn3qs0DucODrPQldkPhkIwQL4GicDl6MarMgzSlE6q9NKR2mJH1GKc/JgD90mq41azopDyjqd6kDExTt1p2iVBPJ+fcwHLJStcvuNsR2UX57+3jlM/982JvsZaONf8l9FOdGWi7VMv7KjRUAaB014jQeGQkqBscwbc17xe0c2oWkYPhpwXqc32Gj1iSrA7F+0qORIgCjULIlcYuMHOkRwg0GxIdVONabD3gpq3jH7k9tbyuqok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 26 Dec 2023 16:53:31 -0800 (PST) David Rientjes wrote: > But for existing files and conventions, I think we should settle it as > "keep doing what you've been doing for 13+ years" and don't force this > argument every time a kernel developer wants to just add one more stat. Absolutely. Let's do what makes most sense. For new things, one value per file. For stats which logically group with other existing stats, do whatever the existing other stats are currently doing.