From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael@kernel.org, surenb@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
souravpanda@google.com
Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files)
Date: Wed, 27 Dec 2023 10:42:44 -0800 [thread overview]
Message-ID: <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> (raw)
In-Reply-To: <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com>
On Tue, 26 Dec 2023 16:53:31 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> But for existing files and conventions, I think we should settle it as
> "keep doing what you've been doing for 13+ years" and don't force this
> argument every time a kernel developer wants to just add one more stat.
Absolutely. Let's do what makes most sense. For new things, one value
per file. For stats which logically group with other existing stats,
do whatever the existing other stats are currently doing.
next prev parent reply other threads:[~2023-12-27 18:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 15:46 [PATCH] vmstat: don't auto expand the sysfs files Pasha Tatashin
2023-12-11 17:00 ` Matthew Wilcox
2023-12-11 17:09 ` Pasha Tatashin
2023-12-14 17:52 ` David Rientjes
2023-12-14 18:57 ` Pasha Tatashin
2023-12-24 21:26 ` David Rientjes
2023-12-26 17:26 ` Pasha Tatashin
2023-12-27 0:53 ` Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) David Rientjes
2023-12-27 18:42 ` Andrew Morton [this message]
2023-12-28 14:48 ` Pasha Tatashin
2023-12-28 20:43 ` David Rientjes
2023-12-28 20:50 ` Pasha Tatashin
2023-12-28 10:17 ` Greg Kroah-Hartman
2023-12-28 20:52 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox