linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jan Kuliga <jankul@alatek.krakow.pl>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Vinod Koul <vkoul@kernel.org>
Subject: [linux-next:master 9984/10295] drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'sw_desc' not described in 'xdma_fill_descs'
Date: Sat, 23 Dec 2023 10:26:01 +0800	[thread overview]
Message-ID: <202312231042.LGJY7ydP-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   39676dfe52331dba909c617f213fdb21015c8d10
commit: fa88abfd0d03fea8b800ff1df4f161c804d24c8a [9984/10295] dmaengine: xilinx: xdma: Prepare the introduction of interleaved DMA transfers
config: arc-randconfig-002-20231222 (https://download.01.org/0day-ci/archive/20231223/202312231042.LGJY7ydP-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231223/202312231042.LGJY7ydP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312231042.LGJY7ydP-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'sw_desc' not described in 'xdma_fill_descs'
>> drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'src_addr' not described in 'xdma_fill_descs'
>> drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'dst_addr' not described in 'xdma_fill_descs'
>> drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'size' not described in 'xdma_fill_descs'
>> drivers/dma/xilinx/xdma.c:555: warning: Function parameter or member 'filled_descs_num' not described in 'xdma_fill_descs'


vim +555 drivers/dma/xilinx/xdma.c

   544	
   545	/**
   546	 * xdma_fill_descs - Fill hardware descriptors with contiguous memory block addresses
   547	 * @sw_desc - tx descriptor state container
   548	 * @src_addr - Value for a ->src_addr field of a first descriptor
   549	 * @dst_addr - Value for a ->dst_addr field of a first descriptor
   550	 * @size - Total size of a contiguous memory block
   551	 * @filled_descs_num - Number of filled hardware descriptors for corresponding sw_desc
   552	 */
   553	static inline u32 xdma_fill_descs(struct xdma_desc *sw_desc, u64 src_addr,
   554					  u64 dst_addr, u32 size, u32 filled_descs_num)
 > 555	{
   556		u32 left = size, len, desc_num = filled_descs_num;
   557		struct xdma_desc_block *dblk;
   558		struct xdma_hw_desc *desc;
   559	
   560		dblk = sw_desc->desc_blocks + (desc_num / XDMA_DESC_ADJACENT);
   561		desc = dblk->virt_addr;
   562		desc += desc_num & XDMA_DESC_ADJACENT_MASK;
   563		do {
   564			len = min_t(u32, left, XDMA_DESC_BLEN_MAX);
   565			/* set hardware descriptor */
   566			desc->bytes = cpu_to_le32(len);
   567			desc->src_addr = cpu_to_le64(src_addr);
   568			desc->dst_addr = cpu_to_le64(dst_addr);
   569			if (!(++desc_num & XDMA_DESC_ADJACENT_MASK))
   570				desc = (++dblk)->virt_addr;
   571			else
   572				desc++;
   573	
   574			src_addr += len;
   575			dst_addr += len;
   576			left -= len;
   577		} while (left);
   578	
   579		return desc_num - filled_descs_num;
   580	}
   581	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


                 reply	other threads:[~2023-12-23  2:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202312231042.LGJY7ydP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jankul@alatek.krakow.pl \
    --cc=linux-mm@kvack.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox