Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

[SeongJae Park]

On Thu, 21 Dec 2023 16:29:57 -0800 Tanzir Hasan <tanzirh@google.com> wrote:

> Hi SeongJae,
> 
> On Thu, Dec 21, 2023 at 3:49\u202fPM SeongJae Park <sj@kernel.org> wrote:
> >
> > Maybe we could add below Fixes: line?  I guess stable@ is intentionally not
> > added and that makes sense, but please let me know if you think differently.
> >
> > Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")
> 
> Yes, that makes sense. Just confirming that I understand, would you like it
> to look like this:
> 
> Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Reviewed-by: SeongJae Park <sj@kernel.org>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Yes, this looks good to me :)


Thanks,
SJ

> 
> Best,
> Tanzir

Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

[SeongJae Park]

Hi Tanzir,


On Thu, 21 Dec 2023 23:11:01 +0000 Tanzir Hasan <tanzirh@google.com> wrote:

> asm-generic/mman-common.h can be replaced by linux/mman.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Thank you for this patch :)

Maybe we could add below Fixes: line?  I guess stable@ is intentionally not
added and that makes sense, but please let me know if you think differently.

Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")

Other than that, looks good to me.

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

[PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h

[Tanzir Hasan]

asm-generic/mman-common.h can be replaced by linux/mman.h and the file
will still build correctly. It is an asm-generic file which should be
avoided if possible.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---
 mm/damon/vaddr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index a4d1f63c5b23..1741e0751e01 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -7,9 +7,9 @@
 
 #define pr_fmt(fmt) "damon-va: " fmt
 
-#include <asm-generic/mman-common.h>
 #include <linux/highmem.h>
 #include <linux/hugetlb.h>
+#include <linux/mman.h>
 #include <linux/mmu_notifier.h>
 #include <linux/page_idle.h>
 #include <linux/pagewalk.h>

---
base-commit: 9a6b294ab496650e9f270123730df37030911b55
change-id: 20231221-asmgenericvaddr-1d5c4cd128e3

Best regards,
-- 
Tanzir Hasan <tanzirh@google.com>