From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE93C46CD3 for ; Thu, 21 Dec 2023 23:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1E2F6B0075; Thu, 21 Dec 2023 18:49:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6E56B0078; Thu, 21 Dec 2023 18:49:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6E936B0083; Thu, 21 Dec 2023 18:49:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C4E736B0075 for ; Thu, 21 Dec 2023 18:49:53 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 93EAD4070B for ; Thu, 21 Dec 2023 23:49:53 +0000 (UTC) X-FDA: 81592470666.20.A10C7D1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id EF5CE140016 for ; Thu, 21 Dec 2023 23:49:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vp55ufAe; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703202592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jb29KkVToDFAkzYoj3p8DgzR3regLEFZr289jT6LnrY=; b=ah6GPsdhMu0ON7ePEmCyqrrqGEXvegETJa/FdpHIdeXJusAsHEBnXilgpbqXjgHnkmZ/vR q0dN4BaRJqRwDJ3sLnAl7au7D3feTdsrO2zeylOG/0OPrrEP+TzUN/kxAO8u010RLiE8TN ZtERudeAsjus6IGx9BaUIPR++1Ocn1U= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Vp55ufAe; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703202592; a=rsa-sha256; cv=none; b=u8u5cZwZqulH4bSZzWuZ3fc9sU5t/kRg2iphmVxTHHjT6Pu2wlbL5ptxmV4nqoILZ5MKUm GtnqJCGsUZGPnF0uL3SvwFJu72koTF0FYI/CmJYuOV1YE7qX5qeQTIeVaakZzJoW3BN3Fv tbh6bwemFwv3FWhIm+8jMp9WlP6juXs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 42807B821DE; Thu, 21 Dec 2023 23:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E26BC433C8; Thu, 21 Dec 2023 23:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703202589; bh=DzS0lRbVCV60NGLtHqn9dKHYbNssxVYhq7y9jEs68bM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vp55ufAeLpeinb2eUci6B5EAi0i6+wNoKKYCDj3OFsmm3urQo2FwvYBQTNtRCIKkN qm22cVkj82A1oLxfZLcQgS4cQX4jW30/DwgEmVz04Q+yerWQVZgn95EAegmyyu6OYL +Q7dtjWkGa/jyarkQDOUT9nEE8GQi7J5L3A53AZaynpnj45fuC/C9VEAX7MWF/6L+X 8Qo+5zxDBRGlYh7cqYaCc2uacXMiBcCH15mhgl8Ht5wJRi0iYdlcegd+SjN+em28xP beG/e0dna1HSwEYSvDgiyTtzfPseeuO9SkjCpzfnbzn9fBDaXLnesaOuQv+Lw2PvJj ZwGCvtNXlZHRw== From: SeongJae Park To: Tanzir Hasan Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Al Viro Subject: Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h Date: Thu, 21 Dec 2023 23:49:47 +0000 Message-Id: <20231221234947.59458-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231221-asmgenericvaddr-v1-1-742b170c914e@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EF5CE140016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pxgeyxwas97m4r5yx51p8xxd88ib1f59 X-HE-Tag: 1703202591-192615 X-HE-Meta: U2FsdGVkX1+6sOh7eV5nQNKKlaArBUg+77n/K2Yb1TTuiDI2vntGPRPCHkwHMKRnLXtWdStbJFZ1d9K31dTEe0lRKDM/c9ga2FJy54eIKwsTmBIw791tOkJ4QLnNHILBRJCB7nZpXEE/8SOTrH0iUFxTE0/CNZf/mYZ6KtzzjdPJ3ren/Fsz4Mp7BaKKXhJWiSxeklckZJ9+Ggay5Co1t4ndmhbLG4K2YV01+J62xgc4/RxRTMPNwWsyMf/6vfPS2LXtFyoVqsgDNMAvojkPFSW+iAkN/q0KgFLCRBDrK4N/C4WHGqZ0NXO42W9QzrjAV88k4USqMJ4I1ZeQEo2ZjDmdULhJn8FrAdxU3EAxcva9tyEovsr3ddIKzx6bqNjA8W4zhS5pOy2C7R5hbxC7UoCftPshPcQc1nMRyboQbhUymW4UEeCQCGRbBWQr8q+g+qSxOuJ8H7wAMeQI1TsPIfpjEw2EgE3IUk55cKXtr9J1AJnLcX4a6D3CW2RCTOx52NXb1gN/t6WOvD+1AF7SFWWF2Zg68a79vaDDd4PgfzA1uXlQZdpMNkQp1l4/yiePxxLyv+AQkGrTRFK86CiqgWMLK88oRCYEpr2A1pOaCAS082VGHVhRXqIjEJduQ92NGehBTgf5fbD6ECF5EU2vgLj5pkYK2fCiFNn/Dle3EH6ElEJl7h78c6noY9+Z08f6cvoGJOxjdMkmpJJLZkLWUS2Dk1nCSiuEOUq/Vpw9kj4ImaHgXRxG98JKxMUdc0+e8oEg0V7XXErNNdlBE1ibFQdWblgfW+bI/igviQCPeqhmFR716XwwioW+jdJQK1z66ym+HXlarkuFQunfpcXc55o0Z5s26/Qa/NG7eTiQz9aXTFuw5r0xpPutziVwCpaj0HrzZ9E74XO5lAkZ237ZX4chW5URCB/Epc8tJU5VFGY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000150, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Tanzir, On Thu, 21 Dec 2023 23:11:01 +0000 Tanzir Hasan wrote: > asm-generic/mman-common.h can be replaced by linux/mman.h and the file > will still build correctly. It is an asm-generic file which should be > avoided if possible. > > Suggested-by: Al Viro > Signed-off-by: Tanzir Hasan Thank you for this patch :) Maybe we could add below Fixes: line? I guess stable@ is intentionally not added and that makes sense, but please let me know if you think differently. Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes") Other than that, looks good to me. Reviewed-by: SeongJae Park Thanks, SJ [...]