From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2B4C35274 for ; Thu, 21 Dec 2023 12:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24828D000F; Thu, 21 Dec 2023 07:31:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD3CE8D0001; Thu, 21 Dec 2023 07:31:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 974828D000F; Thu, 21 Dec 2023 07:31:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 857908D0001 for ; Thu, 21 Dec 2023 07:31:57 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67F49A0713 for ; Thu, 21 Dec 2023 12:31:57 +0000 (UTC) X-FDA: 81590762274.22.65836E7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 24B1E40026 for ; Thu, 21 Dec 2023 12:31:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0wcQhuzB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lj/PL811"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0wcQhuzB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lj/PL811"; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QwHR5tUvfneScMWsP8MbP9fmEkGw5uhOCQkhJHPk1OA=; b=TdXYhbKTdOMMhAmzA8LJTupsnSyy02wFZETvL5L+Xbwpb/ZJytEZu8Dk6dbTWP+wMLV7ar 44zzW9FdVamgblh+0kyTs64Nx4qkiHXrAUNBXVfJiwGuRI6b/mi+vON5MRRmXcyOvKppac RgVsl3+2/CJ5AqzSI5P97y+M+O1TlkM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161915; a=rsa-sha256; cv=none; b=le7XCFG5j1+WLwZ0eU4BxHxFymTISu+z3RbTsNy19/2v5iDDKUexVk9ukQbxkiuaChO3ou zvHMeSwrYaT6gR50bDnTota37orqSLZtVUyGqF2cqdh+wr+Y1WVi+HI5zhRoHJfAmFWtgE pBFtfnj41MI6MTM+rgJ7tu1f4LHBkzA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0wcQhuzB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lj/PL811"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0wcQhuzB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lj/PL811"; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A7E301FB79; Thu, 21 Dec 2023 12:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703161913; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QwHR5tUvfneScMWsP8MbP9fmEkGw5uhOCQkhJHPk1OA=; b=0wcQhuzBCULrMhsrPbMUDvPq1vkJknK8Dh3qDnxgyYVejGEMPmLLd4xI0RZd24Vgr63qOG giAjay67i0UDSNidEpiGhBizY/QP5B2eDztrzA0VJ/ttyeM+cbHiyn8qlN4Ax1VukiCTjx QMrlqkDpKYso3MeMAHKZxR83HQRRjr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703161913; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QwHR5tUvfneScMWsP8MbP9fmEkGw5uhOCQkhJHPk1OA=; b=lj/PL811DVuzQ3shfd0630+UlaPG7rPzDMRTxc8wfu9DeHUCPWHcFJquegPUnPWviMhkKQ RCKbcyG15WM17eAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703161913; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QwHR5tUvfneScMWsP8MbP9fmEkGw5uhOCQkhJHPk1OA=; b=0wcQhuzBCULrMhsrPbMUDvPq1vkJknK8Dh3qDnxgyYVejGEMPmLLd4xI0RZd24Vgr63qOG giAjay67i0UDSNidEpiGhBizY/QP5B2eDztrzA0VJ/ttyeM+cbHiyn8qlN4Ax1VukiCTjx QMrlqkDpKYso3MeMAHKZxR83HQRRjr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703161913; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QwHR5tUvfneScMWsP8MbP9fmEkGw5uhOCQkhJHPk1OA=; b=lj/PL811DVuzQ3shfd0630+UlaPG7rPzDMRTxc8wfu9DeHUCPWHcFJquegPUnPWviMhkKQ RCKbcyG15WM17eAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90F3413AB5; Thu, 21 Dec 2023 12:31:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MYhiIzkwhGXfcAAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 12:31:53 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 47484A07E3; Thu, 21 Dec 2023 13:31:49 +0100 (CET) Date: Thu, 21 Dec 2023 13:31:49 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/17] writeback: Factor writeback_get_folio() out of write_cache_pages() Message-ID: <20231221123149.liaii5ziwyvb3rmx@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-14-hch@lst.de> <20231221114153.2ktiwixqedsk5adw@quack3> <20231221122535.GE17956@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221122535.GE17956@lst.de> X-Stat-Signature: 55ntkksxk169crf8faet8e3j4a17upon X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 24B1E40026 X-Rspam-User: X-HE-Tag: 1703161914-793655 X-HE-Meta: U2FsdGVkX18Ve6fXxCibehcBW5BcFxVFiwdJBTdSvTAko1+aeIPWVJprKtyItZCJbjWhg6RntOz227D6HIsafEhyyaVBQSuDnLBEjgWKUGdcnQiv8afPezit3v6ZtDSAGqXWKxXhVV4314J5VSC4RLU4bWtTV8gxtwNDEMELKEj9vIxRM/kMmFZnYrv0W5uZ/2rHq/JIUji61zS/eJqdOjseAAc+8MI5AuoYP8tW5nGqHhMZYlEgwZAFw28rOdURlvJGLywMvmj5LIcmi5rZONT14Sbxs8FUEt23R4jKUsKmGFBsX6C58d1vZ7+wyESg9zJJGnp0CdLFVE3hYNnRRGZCysyAlscsQwuneGvCPafh8n9mYtZj2AXPIslC9pA9IsamDkS6SkwmMB5yRTbySqViuEFDgaNjzQzPKLG1OkrfGUmPNLKYqikFfopKoZyJxHDoANFgaqjEZZS3u8NRj9KGr5qJTLnL+d8sN2j7NLvbwdJCyIcKc22Yw8LlMZjfJTAae3boKBwLaq2Vc5peYEgZYyjNKs+unweexUMgo0HSpRnpmt83zu1cjQuCxyVpGwLJzaqz9GHUgY85J65JbPTDQTq3Lc2ITNRV4b3Bl6NhUt6klZrcs3PowCUEb3V4MIwzj7talyGkA4YzbaPBWqBoeU/39vjCLfQmi+ibNRwY9wX7L+/EaT5WE9iqxoiI/a3ZJNVvNKw7UQAXubiVI6th+vHITWbqA0/R+MmG2p9wffebXLIaQzplo84ddq64dwIO276OjCDiiDNdTsHEn651GNWufz3qR2mkSUVa2R3XjiyljyaQqEoNWQyZKZ9f1yN1N2bv3dg3+av42rdM+yTCas2IpyI4MXiKxS+D5+V1NGWtEa7AuGI8ojl1ubMtnJBUM0oKFLmNWvMJ1hU430YPSbUPVZzQVgc3XrCb9FIEw0bH+vtOikUDdEb+Po6FE2zskhYuI5iJzRoyvoQ 0TCZlAnN jZaWHTrrWj+qXK+/a38L27mrAi02joWfmwX0gfm/OH+sP06eJJlXIHSa4eLWzda47gUx5hgXafu8qtURGSOZ/70oKE1ON5Gt7aNrnKuoVFjAO4zJ61S/L0iXeiHmvI2p00kWDBmydh989Zg+jDYxHPEr/crAlSmmgKbsUZSnScbIZUFLcg7/Dsl1yG4SV4bGr4myp+OkRvWMYbuUJqFyGiMhSyu/AFQrnp3GC3JaW1Dn3EKGc8YJ8S8TFBddw6/PcP+QT++vA5sguyAbP6VcoUvqJ7d/64gPliElLdWQ6nower8oLMH3U4XvBE+aFwKWuceja X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 21-12-23 13:25:35, Christoph Hellwig wrote: > On Thu, Dec 21, 2023 at 12:41:53PM +0100, Jan Kara wrote: > > But I'd note that the call stack depth of similarly called helper functions > > (with more to come later in the series) is getting a bit confusing. Maybe > > we should inline writeback_get_next() into its single caller > > writeback_get_folio() to reduce confusion a bit... > > I just hacked that up based on the fully applied series and that looks > good to me. Yeah, cleanup on top works for me so that you don't have to rebase. Honza -- Jan Kara SUSE Labs, CR