From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D837C46CD3 for ; Thu, 21 Dec 2023 12:30:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0A638D000E; Thu, 21 Dec 2023 07:30:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB8CB8D0001; Thu, 21 Dec 2023 07:30:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80948D000E; Thu, 21 Dec 2023 07:30:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6E0A8D0001 for ; Thu, 21 Dec 2023 07:30:37 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8824014071E for ; Thu, 21 Dec 2023 12:30:37 +0000 (UTC) X-FDA: 81590758914.25.DE76A96 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 0CAAD14002A for ; Thu, 21 Dec 2023 12:30:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zzrC1FT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t3AZ6zEZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zzrC1FT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t3AZ6zEZ; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fJLSNwQ5QmsjQ47r9hAM+XCcwY6F9aRMICRP236PlLc=; b=Fvm3A/TwFpwKsmgsuU2hYaDJt/aeiXm8wBSTXJ6RjvJ3wiBUyUWVvFBbqEsDXURh99ru3c BpI4+wLMhL4Kits7S+wgoIdhGZ93W+6+CpfiIU79+FsZqxz7XKWYL8tZeNgW6I+laqHhVh +F22ntnj2QSfRgoj2Sc3u4D6P7DxilM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161835; a=rsa-sha256; cv=none; b=otFH9zGAn48kHquvVaFZgUi4HZc8WzUGRck4UObfifxgFu4GgyhCqNqcAXfSNw0B3gkHl0 v1GOQu0hbWrVnetNajpM2M6yXjBbAg4xCrAip1TrFEYuj5s/SOumHm/t3d0tHtyanV2Lhq IXa9U7+iBXnk39uzfj1jasTQ0FNikvw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zzrC1FT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t3AZ6zEZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2zzrC1FT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t3AZ6zEZ; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4A91921E5D; Thu, 21 Dec 2023 12:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703161833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJLSNwQ5QmsjQ47r9hAM+XCcwY6F9aRMICRP236PlLc=; b=2zzrC1FT6sbYm5erWRGdcj452e0MRI86LSx9WwGcTyTgOF1exeUEod25I0+10RUjbCXd8B C2CHDbVJNPji8K6fQQFACMk96XkdStoHcWFADDg3igxcU0s3qdOPPLDSwivvtQMClhoPuy pfvThCa0HLwsVHa3BQ1BqwOovuZUOQw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703161833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJLSNwQ5QmsjQ47r9hAM+XCcwY6F9aRMICRP236PlLc=; b=t3AZ6zEZEVtWLXJ6S10yo2RxRnYCZwil/s7orPWjCDjdekCGUZCXW42APzi52EUI/giupA Gv37yos5nh174rCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703161833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJLSNwQ5QmsjQ47r9hAM+XCcwY6F9aRMICRP236PlLc=; b=2zzrC1FT6sbYm5erWRGdcj452e0MRI86LSx9WwGcTyTgOF1exeUEod25I0+10RUjbCXd8B C2CHDbVJNPji8K6fQQFACMk96XkdStoHcWFADDg3igxcU0s3qdOPPLDSwivvtQMClhoPuy pfvThCa0HLwsVHa3BQ1BqwOovuZUOQw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703161833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fJLSNwQ5QmsjQ47r9hAM+XCcwY6F9aRMICRP236PlLc=; b=t3AZ6zEZEVtWLXJ6S10yo2RxRnYCZwil/s7orPWjCDjdekCGUZCXW42APzi52EUI/giupA Gv37yos5nh174rCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 408FB13AB5; Thu, 21 Dec 2023 12:30:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /928D+kvhGVvcAAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 12:30:33 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E57DFA07E3; Thu, 21 Dec 2023 13:30:28 +0100 (CET) Date: Thu, 21 Dec 2023 13:30:28 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/17] writeback: Factor writeback_get_batch() out of write_cache_pages() Message-ID: <20231221123028.gzkqd43bmdupcekz@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-8-hch@lst.de> <20231221111743.sppmjkyah3u4ao6g@quack3> <20231221122233.GC17956@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221122233.GC17956@lst.de> X-Rspamd-Queue-Id: 0CAAD14002A X-Rspam-User: X-Stat-Signature: ztjkaesdxhpcboy7c3x7zmtfoainbupt X-Rspamd-Server: rspam03 X-HE-Tag: 1703161834-829556 X-HE-Meta: U2FsdGVkX18RsztSN9Vki/32Vkk2LoqzGWmreqocPNRP1vCA60hrVvIbCvwfuJIp1+2S6uyU60N70bZTFtsB00b+epNU0qQp0v54KKW3hWsyCcxEThKMIfM8g4x0cGCez0rdcWBkosfIu6+xxPoOtOipz6FYwgvLPxyIv4/R1jKCvwFmuk7Ow60qIXS3aqQDTGVjk7IN4UDh4Y/WfbJefnYqtJTYznreUtL5D/s3vnhs1ZF+m9EO69hXx0vvNxr5gpaRo7Ed3Nn8L01qZjmefsxepzshO1krqjQ3hLbyaoCJxqNDvt8Nbf4q9NsCgXo3VSPFM4j011jvfxZ08idAgixFKIvOwHZUIxdt+49guR1GGHg/Z2gMlSo/Goo/cayxGzEDjQ32PE63B3V/itTvHVjiA8O1SHSff2ubB2nR4s8wlzK8cUxsyQathyPSXv1TLONBuatJa188IZyMPEoHcYeN36/swDAj99sC6o4IPrq7aTZlUojSaW4Xsn6K7bW/ifKEtP3meHHGOlvTrw368AUHsrvz7GZmjfUophDf5/P1SLxDcpyFFZt4Q95z42YOWKhYSA7kShzGmZ5zVRHQhNRs6ydNBq5DTRLBexmyvZ3JX6Wl72O7oJh4jPrcV+DXHojc5UlAM+vJ7FSjIFk3SoIoKgPheyRuOho9KrEqnYIov9af40NECSTbzBMaU815INo6h1ruA8SI0gaYQ38YaMQLCwd+Tt02wijV8/rzbukDCkUiunTrnLuZ0sLIN3IAL1gEu9xDO/AUdzKzk5fWZcLMmikgBjx4drfy5POL4A2PU7urnrQqku60NlQqmjdYQdwAzbrMDGd+w5tL3rCOVt9/alIwzq60yz4tWEZrkpr2xlGnIKy8QVRS9i3pskvlXJ+avU1DloLyJeYvGeSIor//2hY9rCSPDU1xS6+qndMUGZ1pIOwHeHhhfqrt0Np+RJ7Zu9kO/9s2NsCYCWj 7cPLHmOP 8S6JpygXA6OrQWj6Za5xL/6e2C9QqnUPzwrk97OHWeG0Nxb6U/4XP1ONML9W24TX5g+OE5269aP9ZIg0dPNZXbBQ+Is1KK8+cGtKVoq/sN1/2aK+aBOuKRtOnY6J+6z5Q+LOaRCVkuD8msDgYS7RCWit0QF9oH/uJmiHPAhJ5zeZBETCKv8lC3KRMUBzzxNmDr2I4U10bbyqqNLv3XJNCIaBdKLL1lqvk40DeIjA/COGWOOxksKkSry6yEUuQRA4u39dynUM4GsXWusW8csgkNm5yaVFTVge4p9jPz7MN7qh7QqYHS+O9rIr9qRFutDbZ8MTZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 21-12-23 13:22:33, Christoph Hellwig wrote: > On Thu, Dec 21, 2023 at 12:17:43PM +0100, Jan Kara wrote: > > > +static void writeback_get_batch(struct address_space *mapping, > > > + struct writeback_control *wbc) > > > +{ > > > + folio_batch_release(&wbc->fbatch); > > > + cond_resched(); > > > > I'd prefer to have cond_resched() explicitely in the writeback loop instead > > of hidden here in writeback_get_batch() where it logically does not make > > too much sense to me... > > Based on the final state after this series, where would you place it? I guess writeback_get_folio() would be fine... Which is where it naturally lands with the inlining I already suggested so probably nothing to do here. > (That beeing said there is a discussion underway on lkml to maybe > kill cond_resched entirely as part of sorting out the preemption > model mess, at that point this would become a moot point anyway) > > > > } else { > > > - index = wbc->range_start >> PAGE_SHIFT; > > > + wbc->index = wbc->range_start >> PAGE_SHIFT; > > > end = wbc->range_end >> PAGE_SHIFT; > > > } > > > > Maybe we should have: > > end = wbc_end(wbc); > > > > when we have the helper? But I guess this gets cleaned up in later patches > > anyway so whatever. > > Yeah, this end just goes away. I can convert it here, but that feels > like pointless churn to me. Agreed. Just leave it alone. Honza -- Jan Kara SUSE Labs, CR