From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D780CC35274 for ; Thu, 21 Dec 2023 12:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57D408D000E; Thu, 21 Dec 2023 07:29:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52C178D0001; Thu, 21 Dec 2023 07:29:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41B3E8D000E; Thu, 21 Dec 2023 07:29:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E6008D0001 for ; Thu, 21 Dec 2023 07:29:16 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F226840756 for ; Thu, 21 Dec 2023 12:29:15 +0000 (UTC) X-FDA: 81590755470.28.D50F2ED Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP id 2A2772001A for ; Thu, 21 Dec 2023 12:29:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yL1k7aPBdFuikd6gTcTDOHjclLMX1P1DfZ3srqjMT4s=; b=ou2g2lAe/CJTFHk0GFbC0HErWEOp+WCzR5jUg2gLpaOw+26u7yKR+zagDJj50Yps41tS45 rOGoRAa5QveZJnDgHUu8tBTdFNwUg6oKb0fjtdfpQuBwjDz4ftcYhHXoWoXk29eJnXjkKH 786iC66Oqd/O5nT8nghMVilaYbLICkw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161754; a=rsa-sha256; cv=none; b=t1UL3RH2JNRW2Ze+Fl/sAMWMEhpdRJRI1ZSPOHmYxZYN93SvUDts6twk+YscBMxfswvOE5 IdwGsj9IzQU5dIKqUfzqnIKDbzBiQdvvHyt0SgXOjKEHpbWx/YrRd6HR1odVA0nw5go2dL htMHzSZAz8KawKehNmcG17MCmQWuQwQ= Received: by verein.lst.de (Postfix, from userid 2407) id AD52568B05; Thu, 21 Dec 2023 13:29:10 +0100 (CET) Date: Thu, 21 Dec 2023 13:29:10 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/17] writeback: Add for_each_writeback_folio() Message-ID: <20231221122910.GF17956@lst.de> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-16-hch@lst.de> <20231221115149.ke74ddapwb7q6fdz@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221115149.ke74ddapwb7q6fdz@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 2A2772001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ojdwqceuronzspdbpws13xfkxtokdfb8 X-HE-Tag: 1703161753-517070 X-HE-Meta: U2FsdGVkX1+LM4YBheoFJlOIu6yEd2XX5jyX0/RW03Lga39oacQcI0YE/Aub1Ygdo8THzTFgYwyrLj/LAuP8Wi40ynRAvyYt5gprRfqKRMfIknyfPY5ifcGicDmYxpxXv/i4KqqLaOd8bLeTsiLDlTunb1qA+XUaNtZThEYp4UnhsKKSkyrCcRBYbq9SjzsqpwjwSmlhaq6aPHkAh8O7x25BN37bpyW/g391n/iot32g22Cg732iZexolm5UE6RA2g1Ar8q9LwdDUaL74HuEcuuF5uTEttyPmZq3KIPcFOpVdQ5VsLp8bilH/A7gi3Wec83B33H0TDuE+oyhzV5YMR5k8tNxvkgBdR6KdQcLOyL+jVoa/3jUOSR7bwEGkqQUIJlROuFf25dXURaIWoy49jvDiS01QjiHJzPdHviPTh0u4c2315Dl6EnH2vzQkimwa9UMKw6PSl+gp3mqqxP3bxX+MhyZte9T81zlFhivgJiHBUi9IysJ+qjF2F6XP/kmCqutidNnW3ng/TMggjUEPnxlcUb6Pum/QkpdiiCEOs7pqX/K4SH90UVqmUHn7K+zxtr+pl5wRjq+NIYmZ0rpVs8g6Xe8GCQRIwrUtzMi5cODGDAnCIBq+MOmzgbVVsz7ZSQmdyONHujLpORLwYKcZMzdl6i08LhILk7xPze7LELqg0wHVzueDWD+H6wqj81W9SpS7a+Uo0ktakxHfLC9tdiuW11DbXV3ZYES0jFfmWamVBfbDlY45hFJemXR8wLplmspzWKis47Mkw4dhPpIoaduQb/kLUPdBfXI2hFqoz1kxmxwVwRwDHOWcgo7lqcILn+7vFYYt6GW8zDixgV0SGDX9FljOiS3a+4mrfx92gAPl63cWZDS93yeJHDzk5IEE0hnrceERIsumSBNnzaebTG+qoUyfHULPG7yeoxo1EUsC3XzhEC23dTal3rrIw6vTUgPdj6C7Ia1JISmxjt e1G+sPr7 7AkMsEt701N0lIU3jGztOPZJWzFJpRDbo0qCZgkrnLm7aARjBYlm/sEbwZ3EvLzJ7YG+gC8zwa1LhAqhrNjhvbNeKtttUoYbcLkch42kRGKVnfcII446Z3JT50zWPa/3mxsUOZLoaufV5HTU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 12:51:49PM +0100, Jan Kara wrote: > On Mon 18-12-23 16:35:51, Christoph Hellwig wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Wrap up the iterator with a nice bit of syntactic sugar. Now the > > caller doesn't need to know about wbc->err and can just return error, > > not knowing that the iterator took care of storing errors correctly. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Signed-off-by: Christoph Hellwig > > Not sure if the trick with 'error' variable isn't a bit too clever for us > ;) We'll see how many bugs it will cause in the future... It's a bit too much syntactic sugar for my taste, but if we want a magic for macro I can't really see a good way around it. I personally wouldn't mind a version where the writeback_get_folio moves out of writeback_iter_init and the pattern would look more like: writeback_iter_init(mapping, wbc); while ((folio = writeback_iter_next(mapping, wbc, folio))) { wbc->err = } return wbc->err;