From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 722D5C35274 for ; Thu, 21 Dec 2023 12:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC7E28D000E; Thu, 21 Dec 2023 07:25:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E78528D0001; Thu, 21 Dec 2023 07:25:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8F118D000E; Thu, 21 Dec 2023 07:25:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CB15F8D0001 for ; Thu, 21 Dec 2023 07:25:41 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9D4451206E4 for ; Thu, 21 Dec 2023 12:25:41 +0000 (UTC) X-FDA: 81590746482.07.780AF3E Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id E55BC4000E for ; Thu, 21 Dec 2023 12:25:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft1xC+ODNoFQk1EihE6ea04rNBj0+WzaLUlT/DP2aDw=; b=iZvhl40pPvJZixViXkyodcktAlrJc4HGda3TyRaP4g9j4tF7MlNnjC8/a6VEwMjQuzvooF w9LAi9qQIBkyuvnYeWRppY527yl8zUiCcS76I4pnrNY1HuVRtGmxO+SEAHNvvZtVz7AxBr L1yBnftoVEwO5kOPQgSMeFSELzhL1JQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161540; a=rsa-sha256; cv=none; b=4CzCl02ENib9GK24k8bOmcVN0O6dCvZyS5Buz+Q74yrDoANI50gL5bCS/h5IzjBeo46T15 RMT7Lno9dWiii6q2P0vTs1t6kL+5wmQCi4ljD3GxshGLjgBiYIxNdz5qeFXxLJxEkXFqsS at8aLrOxJdS1jFFsEffj6LWSC0J+6ck= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 467BB68B05; Thu, 21 Dec 2023 13:25:36 +0100 (CET) Date: Thu, 21 Dec 2023 13:25:35 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/17] writeback: Factor writeback_get_folio() out of write_cache_pages() Message-ID: <20231221122535.GE17956@lst.de> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-14-hch@lst.de> <20231221114153.2ktiwixqedsk5adw@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221114153.2ktiwixqedsk5adw@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: E55BC4000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dcabmkp33a9uz7rknuj4wju1bj4fiwuo X-HE-Tag: 1703161539-527379 X-HE-Meta: U2FsdGVkX19GzXwsIuWbSYsLuIc2pN5E8kI6dvI35M2ogONI6pWlI3pn7tOUe0V5K896nRLj7eZ4/MBUdFVjFvpgb27RLm9ffK1eahITJeLz3pGQaYAHHIXXMbC5drZhWQJYWY4r7CRldLLSClN1mUB80MvMp0coucrJTlVF9ZmVEzwOQc4MLBigfLU6X3MuDaq8whLOJeNcXPUx46kA+ybW/1xe/9bZ5YidEboBVNlwWQ7dHsKPQKejHtgWhbvYvnpTBl8CYHfVzCDzIotLCKBITuP4D6GV+Rqxb9EWTzcsffEnbkAmnqlS42v0Q2OEjGSSExtmy/r8hUj38EeW1u+xmkwdhc7MZugy34DZhQYrd5RexI3B1ToVLJFQP6BbX923egimiK+f7UNnJbdd/JZxAaVDn8JdTc6rs5SWdeyQ+WpzSFpaL4jm20qwtxzmdglDJpS2JNQz7bPUUSCl20LOCplC9vyf7Y1O4WJGTcY537Hmq6pi9QVOxKrPinV4Ak+YwIL+y2r6eVJk7gspcxiV+OzAdJQHJJDfVB0LDB6oJhqrsvSqWcXPZQWpTIbQt42SVdOEdM6Xe/ipJPf3Kawz77xXxRosdZACWwSctN1oupOWuvjwsw0sxldqHRmZTkNaD/0O3RSVIP+CTusKomsqEPPTJAPDQsZTfEbK+XPkLmezkZ0bO2ipDijODvu/zUapHPvLl6Vv73qRsV6wwOhbk/61Hps+S7e7ieKgouyEbXuibnPD9TZcboBYTY7xaSmaFW/S8SsugzwtEAcGRlvVffRtUBdgoH5RFWiXqILqDxns/q5PKFEUzTDLxypcR9rcty1SKmYW7Uq0Yls0qTZ/vzMQQ4ymMnCdxckYkKCJoEEsiUSXqKpHolccwpCi4PK3WqpBkddQrojDFY+KTVoL/iKafAzt9cenHyOlDf1Ui94SLahkeMwhe6F6+9qlZm7QcwtAcPxzkasJhSs wtOmcnKS /1KIXvMpv5fp2HksIBe6yyoamE5pwfD8qK294UCSIQliM6SAYt65JdU2yj6jVzKZVyNgxHrKqHssyLofg8GOwLhDscA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 12:41:53PM +0100, Jan Kara wrote: > But I'd note that the call stack depth of similarly called helper functions > (with more to come later in the series) is getting a bit confusing. Maybe > we should inline writeback_get_next() into its single caller > writeback_get_folio() to reduce confusion a bit... I just hacked that up based on the fully applied series and that looks good to me.