From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19B7C35274 for ; Thu, 21 Dec 2023 12:23:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9230F8D000E; Thu, 21 Dec 2023 07:23:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D1488D0001; Thu, 21 Dec 2023 07:23:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799118D000E; Thu, 21 Dec 2023 07:23:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 65D838D0001 for ; Thu, 21 Dec 2023 07:23:19 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 349A11606F4 for ; Thu, 21 Dec 2023 12:23:19 +0000 (UTC) X-FDA: 81590740518.26.B8BBE70 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id 6C3EC40013 for ; Thu, 21 Dec 2023 12:23:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w8i/83dap7y6WWKCKA1SbbRyzQL6SEj4NFXs469YtMA=; b=pWsEjKai0wDcfyi7ykL2QcJKV8kF1JR1D7fgYO9JpjpQ0Hb4nfBe2A3hx06bbSOZ4BORll BBUZKmpTVjS4j7Wjc1sf3TTJOBygpQmehNoBZ/SZtMR3/76WgMsBkJGfTHsij7bF8n3Wub 9YoutfzYj7QFucklvrZM7njQvNLX6aY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161397; a=rsa-sha256; cv=none; b=MGj1NtVNtdJO5ZqhPdPLKGqthT7kNllFxTKzZ8yB917Ao2HpCFbswIW5ZvgC7D7oVKbaFj BoJcgLJ0ay4ULpyDKJ2K5V/kYEZoTLnLaIv3svlZ5YBrSZp98cEZPz4ttuJCOyIauKQM7d WS01EYDuUQE/f6jRU5qvrdF1XitSGtM= Received: by verein.lst.de (Postfix, from userid 2407) id 3EBAC68B05; Thu, 21 Dec 2023 13:23:14 +0100 (CET) Date: Thu, 21 Dec 2023 13:23:14 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache_pages() Message-ID: <20231221122314.GD17956@lst.de> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-9-hch@lst.de> <20231221112206.f6biqpkpwl6w64mo@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221112206.f6biqpkpwl6w64mo@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6C3EC40013 X-Stat-Signature: f1upoxtm8u6uatesep7pgqqsf87i4zty X-Rspam-User: X-HE-Tag: 1703161397-707632 X-HE-Meta: U2FsdGVkX1/GCaUoTOizI7b5WLlOTvZKykziXQNEtqKnp0Qh1zJhRKXdyXkV1tlX4A/lp1gPb3IgqFTCiwSPj9t5o9u6lCULfwQSbeUwJcgqA2CM406/FG6WOmTR72q+w2e6KkHKVRulK6qDRfdNWk99uy8f/nGQWIN005J7jJmvc15K0ZEJBjarRaUZBVXUw9wvrnDxzYvBkBBdY/8UcYoO9ARo8qwr2VQLrNfYhTlrr+XvhJrwWiBR/a8AAo9O/SrgJ4RqnPXd1S4TVaJ8HzD+Bnt+sxccY28E1ASkJj9QK2aMoFHjrphfbtlDV/rvSzqj7TRot1Gc7LII3qBss7azJjMp14LZ+u1NOw+F37uc7bdnIUEq9+bpxsYlu/tXFDJzbGIVB4vH6BJRVphxGGARSWWKiezolfZ+ZAZ1Ay3kX1ZX+EVsbmEKLlcpIduSenVCv1cjhkcQ9AXSyEzaKc8rVOxEt0er2iugiUJzaSSPq1wlimPdPqrqPxIKEPqnSnyp3S1Ntx07Cla83XHOl49mLaBcNQjG5s7S6nI7UfHsQlFABvE69tg1VXlQ3XuL5z3wURlM9rXxJgawBuVa5z0VW00Mm1jw0MrUuIl8JVtvBOdPOVAvkoiIuS9cPtKcak8P1708giq4Gw4/hNaR9BTXhcHDxK+hHlnYIMvvnCy6sPpXLOT9UcBAN0Ca++W4MwIs4JgVOb12lbzRLkpO3soI/X/o/h3zuNf7SjXeJIEVbgFdyWg5256ibp34zwnaEQjzkwSoMcj8UGO6eEb2HxXB4tpkSzvDZAo/GS8KrfJ9UzJVdb93+xWeVsZMssTHZgBJenVcdekeMpq1Upx5s2RJMmjj+Y8+oXDYOaqs8JWskQI0MfgfWxOPwORLSoloNGdxQrrzGZFfGHjtPy8fq+b4g/HTZIDCLe1uZ8wAcGrES/uzXFCBsnVtYGWoH+7GuMJw3LYbYhxdv1s9YKU z7l6VwAV l0JRh9DRcqIXETVQPH2Ld/YGr5K1bT3VzUdnPhSL4wZIj1oHjFR8889EtccE01zMNNNRX6mfRk8x5Xp9J4E8hnS7IZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 12:22:06PM +0100, Jan Kara wrote: > > +static bool should_writeback_folio(struct address_space *mapping, > > + struct writeback_control *wbc, struct folio *folio) > > +{ > > I'd call this function folio_prepare_writeback() or something like that to > make it clearer that this function is not only about the decision whether > we want to write folio or not but we also clear the dirty bit & > writeprotect the folio in page tables. Fine with me. I'll wait for willy to chime in if he has a strong preference.