From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E787C35274 for ; Thu, 21 Dec 2023 12:22:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCACF8D000E; Thu, 21 Dec 2023 07:22:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7ABD8D0001; Thu, 21 Dec 2023 07:22:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1B498D000E; Thu, 21 Dec 2023 07:22:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9EFEE8D0001 for ; Thu, 21 Dec 2023 07:22:40 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 709C7C0724 for ; Thu, 21 Dec 2023 12:22:40 +0000 (UTC) X-FDA: 81590738880.02.7760417 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id 7D73240013 for ; Thu, 21 Dec 2023 12:22:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703161359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yf0JQO7q/WuYj9NOYMc6EY3D63AVANrzc56xXJJHfLg=; b=XKlgYPrOXafoU3g44vF75NDl+13GmyxgQ/Z4VgRbvzqvjg6DYeETTn5oAq3ACdpcrAoPP5 ATHlvkYe2aXxLcDnORKX/hq/wlpyGqUg+mjPlwAfWLIql9na2aJYFvLmeNvYtTPD6DQErU 32noE427GriBMkTc2fOOCtTVZ5bnk3s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703161359; a=rsa-sha256; cv=none; b=1y59a1nbhzHHVWc79iP0ElfBEMFwZazCSID/JzQC7UeVe3aKYjPQPSUpOKXIyxN9sk/NmV Si+4vG/ECQuWBY8dyOJ8LS3ep032VTRUbvtA4hJXiITninEYcigBNap3UilUBmjw3L3BqL hemCvNhTJs8LL89Su2mP1mi5JCEFAC8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 2393868B05; Thu, 21 Dec 2023 13:22:34 +0100 (CET) Date: Thu, 21 Dec 2023 13:22:33 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/17] writeback: Factor writeback_get_batch() out of write_cache_pages() Message-ID: <20231221122233.GC17956@lst.de> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-8-hch@lst.de> <20231221111743.sppmjkyah3u4ao6g@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221111743.sppmjkyah3u4ao6g@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: mx7o9bngrfyz4tj5jc6kscsjzkfz9p5p X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7D73240013 X-Rspam-User: X-HE-Tag: 1703161358-592787 X-HE-Meta: U2FsdGVkX1+4OHiDHKI1h7PmH149c/dcYGehlc5EiWLf0rLcHY7CRjNMjzTDrukGMiwYqbhlHI8k91ARhHWW977lwhLQikjqWHQUw67MEawNAmf45zmcOuRmGD/FsWBo0pLxQtlTER34m99pJPiJbnp7a4TImss8CDhdzQCgV/dyfgbzwgNS+G2rI4arDjSUZ1xiEShN/hiBJvzX1I2XCFWzKcbfVzzRiVAmuzOuSNF+k76eGCYCFfj0uKqt04W1OhlvvHX0dDoZNocaLi/sbYIcV0a1vmcO4VqOFOsK5AsE+LBhRoPdBklwNpNgfoP2dwRGwAghrLs2atsEAFlmczspDrHEBuhs0nKmsY/WpxUd5E9bRRDej9LlRAEdMqQBbLobYj30yndbBNmh+navAzzb+OMSnp8KMSsxE+zX6AYf5dfxr2OIP5vRpyW2pxQ0YLTSWdlhTiQHlRNCYCQbZ54NYAfdGJOUftF4b1GE2cnVMHboqW//ccPFKGVx7ms/zqFbpFeQ44EoXHLHfiie8t+KJRVsn6umuCzEdiyo8+k/Th5Ef5ZJiFBeF+V2Tl+fTO0jaEa2O8xLIO2JakITFvJEEHHCoKcJAP43KxYsU/UXIpF6SpLa1OmK4u+HoigG8nHJYIB4BY5zWK5kJKSZDyp7kJzCFajFun9V1s1zy/Zlsf3xakyzqVkXdEAKFlQVcfVy0BeATUq3Pmur1pyHnT+kzCK7VE4IJK9i9mjk2hxSVHQEEzy1KOYIhmFkz0eNWNbH90f559F6VgcdQHFDU+a9ncWVe8fg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 12:17:43PM +0100, Jan Kara wrote: > > +static void writeback_get_batch(struct address_space *mapping, > > + struct writeback_control *wbc) > > +{ > > + folio_batch_release(&wbc->fbatch); > > + cond_resched(); > > I'd prefer to have cond_resched() explicitely in the writeback loop instead > of hidden here in writeback_get_batch() where it logically does not make > too much sense to me... Based on the final state after this series, where would you place it? (That beeing said there is a discussion underway on lkml to maybe kill cond_resched entirely as part of sorting out the preemption model mess, at that point this would become a moot point anyway) > > } else { > > - index = wbc->range_start >> PAGE_SHIFT; > > + wbc->index = wbc->range_start >> PAGE_SHIFT; > > end = wbc->range_end >> PAGE_SHIFT; > > } > > Maybe we should have: > end = wbc_end(wbc); > > when we have the helper? But I guess this gets cleaned up in later patches > anyway so whatever. Yeah, this end just goes away. I can convert it here, but that feels like pointless churn to me.