From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40994C35274 for ; Thu, 21 Dec 2023 11:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDB9E8D000B; Thu, 21 Dec 2023 06:54:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C64518D0001; Thu, 21 Dec 2023 06:54:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B05718D000B; Thu, 21 Dec 2023 06:54:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F9AD8D0001 for ; Thu, 21 Dec 2023 06:54:41 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 76497406FE for ; Thu, 21 Dec 2023 11:54:41 +0000 (UTC) X-FDA: 81590668362.27.47E6F17 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 2F4D0180014 for ; Thu, 21 Dec 2023 11:54:38 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FaC/jpxL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tDOhWt+0; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FaC/jpxL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tDOhWt+0; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703159679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2M7C0GoB7X8XAnxaAgw9zOcBEuLiI+H/k44O2aeGnkY=; b=NM6NhsEtFr2wz6J12CSTijvnhBdudltKu4WtNEH2iSOLLNdqdZo57SZEgiAQBRg44Z1i6r RFAsoaAsay5X2Cf4M887Tc9LG1IvGTziNu+lxEjBNWFA/bJJY/TIRqyJM/E4bTBsG6tF7P iS075km/QvN38se4acbke3advbs36jA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FaC/jpxL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tDOhWt+0; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FaC/jpxL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tDOhWt+0; dmarc=none; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703159679; a=rsa-sha256; cv=none; b=tXcAjuoye2m/2N6fuHkxhX3T9dwOVPkHy02NIyIQS/3Kjj53GXOjGVllwbJDRpNQ0HKg5w WrW+xUbpv+OC0dOjDqAO7SiJX8IK5lDR7EqP7SPnRBQjHM7kiUDgY4vtbXRMJEZi30D1q7 SgFgBM+5AgsHfxWnDYsrKEx9Z9yNpeQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75BDC1FB73; Thu, 21 Dec 2023 11:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703159677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2M7C0GoB7X8XAnxaAgw9zOcBEuLiI+H/k44O2aeGnkY=; b=FaC/jpxLTx/SFyAVWKmjOvXA97rWeI26wRgraGOiIvumbUYeYgm8HnDW+GaZfRAD+3K13G 70RzarMo/xBV8tlymkKoirCLoG+QX1to/RLOkqLeZEdLh/uU5X0cwCDxTtTF+orwDRgl2P 5wClfvEV0WUHZILqkwO5CWHtDsXYsbs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703159677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2M7C0GoB7X8XAnxaAgw9zOcBEuLiI+H/k44O2aeGnkY=; b=tDOhWt+0l/bQ27UXfO4HoW7dToZgy13cJ2qKXi8v0qGC9cg3XscO1pobNP7+VUNSk2vDV0 i/2sgKfIazW7QzCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703159677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2M7C0GoB7X8XAnxaAgw9zOcBEuLiI+H/k44O2aeGnkY=; b=FaC/jpxLTx/SFyAVWKmjOvXA97rWeI26wRgraGOiIvumbUYeYgm8HnDW+GaZfRAD+3K13G 70RzarMo/xBV8tlymkKoirCLoG+QX1to/RLOkqLeZEdLh/uU5X0cwCDxTtTF+orwDRgl2P 5wClfvEV0WUHZILqkwO5CWHtDsXYsbs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703159677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2M7C0GoB7X8XAnxaAgw9zOcBEuLiI+H/k44O2aeGnkY=; b=tDOhWt+0l/bQ27UXfO4HoW7dToZgy13cJ2qKXi8v0qGC9cg3XscO1pobNP7+VUNSk2vDV0 i/2sgKfIazW7QzCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6A1A113AB5; Thu, 21 Dec 2023 11:54:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F3/iGX0nhGVEZAAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 11:54:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 2D5BBA07E3; Thu, 21 Dec 2023 12:54:37 +0100 (CET) Date: Thu, 21 Dec 2023 12:54:37 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Message-ID: <20231221115437.nyxxipfyezn6jrzt@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-18-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2F4D0180014 X-Stat-Signature: 84q5cs3iujump3aauckm38gxucd1izgp X-HE-Tag: 1703159678-280658 X-HE-Meta: U2FsdGVkX1/0Rcn7yDg9H5vyephpxLRhCKuEVaHlrXYNUmEYobUGTedo9eGmeWgwMzEGVV0XzXDE4QO6XRM6S9Yz38fUFCftZoJN28bbwbPsest3h+AOMqFSjJZ/wjnDVw8gcwICDfsgoGI0K0TtgO+6JJpq/tFzsJaRtlKzRUzBG2xGHgAcNB1H4gRXVR9xBM7076WeDFyWgTIXkaOrAcyc8W3qefRnoVK8Gd9Lw/0dmC7Vpktc+LXIVrcUOsgf3o6lDFioD5iFCIgyPv1ORmkDKmvINcbOM0hUUKye9WYDyxayOdOLXBGzIS2oNlYNT5O3QOjKJJllcI6MYuWrZ7aGjh8FVkBuuUMOApyBYsSJ58cakZMoEk20xTHD9OlqR0+O1ZZm+231ZD4YOmj4q+GYbKRrdJjtzKUgcXWGRPfY5P17YItJEBjYP6HjZbjqBApeoSyobF8MH5Sk1XcTZcW9C2J4nz69r6pxLtrnxqHFtrCNbJbSnTth2WkMhpabqxMa6I3lU4U6/EflBAGVhAud/1TwjnmkNaFXbpEppp5VAhICueC/AejWrJQh/WoDhn0hijvTjIchAQnMlv6AOFFOP9XiDtzhDGgVnmNWDRDwIPCkv5/LsAKkfqqN/CZeSuotWzWZED8U2VvaMgyrdPBpZ9SZlenhUPGmY+V0BEokXlCEpikPfT5mRvD9k3gl344z5RqIYeQwHPvNlu2u29VEp3ciG9g6+IfjKntnUXDrcVsw4qVHsIjZGFGCfBeoubY6vRcgrwPI3qKzLehmJgSMcXDB+jl0F71m3wm13yI94tdG878br302xxhS1wNGdSIReVEm1L8M0Qt/l9v2jdLTB6bRzK9wH3/4LlrCipQQuUqT1TXEb9XM19jVqskFYEtAYwpiKy7/uGxmqXrwkw3ezKv+MTeL6ZcI8arb12IrneSPzlfRvYjG/KFbH1Vb6jcRNDcbruUNlztwGXV 6WZplWbb mfV9HBqazdUNKz9MITY927IfRFmp21fDimwQY8eF+puNNgPgO9XHbw0OjS9usEMmZ5Dj/HNUVtK5aReuH55mw7HNSiCXmRdFY9wB47wId/+Q1YeLYywkjZk2Md2jlKLF6fgOH+YZZfLFaTGG0x8veP5Q1lzGFXK+BFyLbEwC+7GppWGLCLPctMO2O6xCwxHYsss6tRa+n7jrETRKjle4v0rCRaZBne1oxXMTcNpzdPC04vca2KoTEdsNbP9VAgejqbYvI9OI98DndS2fqVx/bNAbuHJhUHJxsxPzcdPfAXThtK4aPHU3BdBE0XXtOYZvYOE54 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 18-12-23 16:35:53, Christoph Hellwig wrote: > Don't refer to write_cache_pages, which now is just a wrapper for the > writeback iterator. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index d3c2c78e0c67ce..bc69044fd063e8 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2325,18 +2325,18 @@ void __init page_writeback_init(void) > } > > /** > - * tag_pages_for_writeback - tag pages to be written by write_cache_pages > + * tag_pages_for_writeback - tag pages to be written by writeback > * @mapping: address space structure to write > * @start: starting page index > * @end: ending page index (inclusive) > * > * This function scans the page range from @start to @end (inclusive) and tags > - * all pages that have DIRTY tag set with a special TOWRITE tag. The idea is > - * that write_cache_pages (or whoever calls this function) will then use > - * TOWRITE tag to identify pages eligible for writeback. This mechanism is > - * used to avoid livelocking of writeback by a process steadily creating new > - * dirty pages in the file (thus it is important for this function to be quick > - * so that it can tag pages faster than a dirtying process can create them). > + * all pages that have DIRTY tag set with a special TOWRITE tag. The caller > + * can then use the TOWRITE tag to identify pages eligible for writeback. > + * This mechanism is used to avoid livelocking of writeback by a process > + * steadily creating new dirty pages in the file (thus it is important for this > + * function to be quick so that it can tag pages faster than a dirtying process > + * can create them). > */ > void tag_pages_for_writeback(struct address_space *mapping, > pgoff_t start, pgoff_t end) > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR