From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9259C35274 for ; Thu, 21 Dec 2023 11:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45E1D8D0002; Thu, 21 Dec 2023 06:22:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E7308D0001; Thu, 21 Dec 2023 06:22:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260298D0002; Thu, 21 Dec 2023 06:22:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13EBF8D0001 for ; Thu, 21 Dec 2023 06:22:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D411A40D70 for ; Thu, 21 Dec 2023 11:22:10 +0000 (UTC) X-FDA: 81590586420.26.BCB3BD8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 94D5B1C002B for ; Thu, 21 Dec 2023 11:22:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kMpzL+ie; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p2fc/wre"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kMpzL+ie; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p2fc/wre"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703157728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pi7hRIwpboX5Xu7y0qd/z2bmAu98D1+xyAumfJmNvK4=; b=TxWoKhsMUuQxRp2f9xWG/Dn85XXEeK5zMI8YvRCs6WZ+E5FIXDycd9LP8IYt4fsToeXbbT yqgs+SEOeCxuNO/Foi88NcUPtMwVUbKDLl6jUhR9kHv10q320RV3XMC8FOdyxKJMLsgMjf ENDxeBEGIWA4S/0eRFiv7syeFnAhFsA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kMpzL+ie; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p2fc/wre"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kMpzL+ie; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p2fc/wre"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703157728; a=rsa-sha256; cv=none; b=z5X9gTd99eoKW9yQUA4RfY3HDib0Gjk8WFNnsyCihPGXFaRxi71PrZOmBMwxKdAlPtdE+E gvBdRnFsS4Vsdn9Zg9uJnd/cIPD062cD0GlxFYNMs9EPWPPt3OoSdh7ZdWet67+Gig9rXm XjWjJNoN5ydEmPCqGzhRRVosqOiY+Mg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B3D9721DC8; Thu, 21 Dec 2023 11:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703157726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pi7hRIwpboX5Xu7y0qd/z2bmAu98D1+xyAumfJmNvK4=; b=kMpzL+ie++zLwCkwHGBQZ0WX2Gtuv7hgYuCZ0BhNBsVV6zvtNObGFQIrhNqcX+IvGwC9gy WbJkETUtT9ZHa3nSXEF2fsB5ByEnOTO6SDIzSYPs3INMzBSLMvPlqqVy50lOjwrBuM2rP6 vApsEVVPzlqlu6597SCPrUsb3b86M3I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703157726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pi7hRIwpboX5Xu7y0qd/z2bmAu98D1+xyAumfJmNvK4=; b=p2fc/wreu6wuPV676GJ09229hWhN15CuWbvMvuLxXIG/cGFw5zxXYvdFQIAJu+M5o1hu49 8+WjvyTVxHRH8KBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703157726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pi7hRIwpboX5Xu7y0qd/z2bmAu98D1+xyAumfJmNvK4=; b=kMpzL+ie++zLwCkwHGBQZ0WX2Gtuv7hgYuCZ0BhNBsVV6zvtNObGFQIrhNqcX+IvGwC9gy WbJkETUtT9ZHa3nSXEF2fsB5ByEnOTO6SDIzSYPs3INMzBSLMvPlqqVy50lOjwrBuM2rP6 vApsEVVPzlqlu6597SCPrUsb3b86M3I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703157726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pi7hRIwpboX5Xu7y0qd/z2bmAu98D1+xyAumfJmNvK4=; b=p2fc/wreu6wuPV676GJ09229hWhN15CuWbvMvuLxXIG/cGFw5zxXYvdFQIAJu+M5o1hu49 8+WjvyTVxHRH8KBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A7E7113725; Thu, 21 Dec 2023 11:22:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GpX7KN4fhGVmWQAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 11:22:06 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 5C2B6A07E3; Thu, 21 Dec 2023 12:22:06 +0100 (CET) Date: Thu, 21 Dec 2023 12:22:06 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache_pages() Message-ID: <20231221112206.f6biqpkpwl6w64mo@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-9-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 94D5B1C002B X-Stat-Signature: ajyhn89shafp877o5otu7m1ez44aktyw X-HE-Tag: 1703157728-951914 X-HE-Meta: U2FsdGVkX18CbBictvc6LiIqtHIq+wLn+6JTM/8fkAvMgnQshNlwUw4QWojLyEsmLuW50TUwY1CxWEA+t6+nA/VRXv6QNJUEPzbvHZbT0rxHi9OaI+/27UU2AvcvpKBqwPW30DRBRA+FKCcjf+xdT6+xfhrz0bJj3OG13S5CA+4D9rKEQubWd6X/cPPMrGrmU15+Y8sFWSLPM11F2/YYCTyWTNtF4q0KHjLx2GOe2H9bwUhXeXreQoKwKs/No5DdYbYGFmYNPnaFms+RZ7/amwmTvWcsxn5vpHZNCEvKBeIIehphJMP0cGEvse9Ij9efzKFEqgDGaWlYPQjGFmqAZWgUZoZcxriQj2UFaPa0zKQh8btizr55bznSsXhQKKJ7VLq8a4iRlFpOe0askaOZOuxZA350tk6opwyidGXeiJbDSjkqOeg02nRz0Ju0IX/vrhxPjG/F/IIOsAezE1d0kMwiEuPyKGJMZLwhWBCAs8FpzKc0+E3MSHL1z7WbgYx7o5w+FyFpRTmcN7Zu0Xq4ynvH9OwbxNMq8/rK9b1PHNiLVtilFOF+xJjIVHroNVkn/0oMmzP6PpV5zmazi+Vgb6XrsmMSLOLlM3KqkYMaZF0vXJS28FFIip/9HSmARtZoy7wCm3uh8l1VrLafpXbu5FDUmb6UVjGeB/TLSY5vyUXLzZxVV046UUzY0LK4Q98MZtq3KDbsCx+j68tuS0CWpbmjrbrQtjN8Vn1RYN33/0nhoA/dc0sF7MYNjq4drOmjb2FXDuulbEsRCP5oPkvZFToVa3W8zfbXFqVhx6GxDqCUZkOxxlBDMElTrSIXh0N6I5K80Eh99VVD0SAwYzUtusIhMJpLNo+iGN5YC5Tq7JUO9AOhuUPJ6M0Mg+95kyaS5FJ1Zd1rt2nLzWpT1XFLMMaXhq61f9noj7xOw11f6kWvlEPFgh6YtNSGVarWC19/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 18-12-23 16:35:44, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > Reduce write_cache_pages() by about 30 lines; much of it is commentary, > but it all bundles nicely into an obvious function. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Christoph Hellwig One nit below, otherwise feel free to add: Reviewed-by: Jan Kara > +static bool should_writeback_folio(struct address_space *mapping, > + struct writeback_control *wbc, struct folio *folio) > +{ I'd call this function folio_prepare_writeback() or something like that to make it clearer that this function is not only about the decision whether we want to write folio or not but we also clear the dirty bit & writeprotect the folio in page tables. Honza -- Jan Kara SUSE Labs, CR