From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55719C35274 for ; Thu, 21 Dec 2023 11:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D81F86B007D; Thu, 21 Dec 2023 06:17:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D31F06B007E; Thu, 21 Dec 2023 06:17:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD22F6B0080; Thu, 21 Dec 2023 06:17:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE7C96B007D for ; Thu, 21 Dec 2023 06:17:57 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7CCD2160CDA for ; Thu, 21 Dec 2023 11:17:57 +0000 (UTC) X-FDA: 81590575794.15.4BFAE3E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id EC1DD40015 for ; Thu, 21 Dec 2023 11:17:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pnETPrJh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ojdikVS8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xvpDs7i3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8DwrDG7W; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703157475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lMCSXvKrQmzSHPEjvHeGpGs44ARAmvqkLgvIRNnTtig=; b=xBp6Ld7eql8QvgvL2AlxWth2eZQK8Jfdz28v3aAg+zZrhLoJmqZr+TuXZBA71VGKvRptjP F5scQsDgHbJwmyn5UlP9faFOh04bp+3yvUhza9NAJXl6pOFoVtwiYY0ueB6aJqIweUjRsi ShMbZQzAsfDI/EQNLpTJDdIHJOrFat4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pnETPrJh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ojdikVS8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xvpDs7i3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8DwrDG7W; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703157475; a=rsa-sha256; cv=none; b=VUTM4k5dcsUxklTbVk49gUgqQS2e5petTw+/ZhJJy71Po5NULqr9KR2dyfbpdWqWvEmh+F 3RrR4SVEjlmCqsdofrOv+cbC3XBslGe3sOG68ZiQlDmg7iMLp5reTOjNncyxFvBhT5bb5u hLfn0YvTUCej5+RE1+t/QgOwZBCNU/A= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A02C1FB74; Thu, 21 Dec 2023 11:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703157473; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lMCSXvKrQmzSHPEjvHeGpGs44ARAmvqkLgvIRNnTtig=; b=pnETPrJhteg5RB0DUE8tAJB4EjfNapbjFUM/MIg8Vxwn8PEuU38AoDkJHCf9n8NfRJ2Wl0 Psjv/OfoA80DlnoNnX6P+BnElZUKv6aPwgRco25bCxElC/gbOu7IgrRZP2cGGcGDKwzc14 qN24jlQ9w/VYbuGuIBOgaRk+wFO5748= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703157473; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lMCSXvKrQmzSHPEjvHeGpGs44ARAmvqkLgvIRNnTtig=; b=ojdikVS8DkebDKlIGcdOCiUb+Ksp3CQnB0Vb6FbAGc7rcE1uHfFTXlWHSDyXg7dhPNE/dp TdlWZ4XnkUxrFcCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703157472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lMCSXvKrQmzSHPEjvHeGpGs44ARAmvqkLgvIRNnTtig=; b=xvpDs7i3BHZ9zXzzOMdoEgoZz+grtKOq+/JNvWYPoiVLx7fRP9bn+yfgPwNycufE53V3Ky hcr23WWkpNq0twQN1xLrh91VbDfbqGO0e+9KFG1iT4oZJS6kHkvoqcSsmLQwZHIUsX5aXp AeyqGvIQv6SwKysR4h4HFEgvwb7GwC0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703157472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lMCSXvKrQmzSHPEjvHeGpGs44ARAmvqkLgvIRNnTtig=; b=8DwrDG7Wko8MrW6UV+mDy/nO7rxhMr4BQnUnXThk2rqn9xBGUn+AuiD/I0L+m9Wm1Mag8Z HkQl9eKaiYOJOTAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0C9D713725; Thu, 21 Dec 2023 11:17:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7ME1A+AehGXpVwAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 11:17:52 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 90645A07E3; Thu, 21 Dec 2023 12:17:43 +0100 (CET) Date: Thu, 21 Dec 2023 12:17:43 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/17] writeback: Factor writeback_get_batch() out of write_cache_pages() Message-ID: <20231221111743.sppmjkyah3u4ao6g@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-8-hch@lst.de> X-Rspamd-Queue-Id: EC1DD40015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 76q3dtyya6d87bzbsnk1kpo67tjohpix X-HE-Tag: 1703157474-628746 X-HE-Meta: U2FsdGVkX19UEDgZ3VGKGJZQiFlsbolijJtrb9IYixLRtVwV1fOMY4VT/5JcmgbLrE2gu2YSNyUa2CqgD4wvIMmyrHDkqgXSOsq5BqfpgHUyV/K9jJiArKXPT8VetOQ3BQ9YGoo3JMD3fWD+ALhoGMsnjNc7mGLwChu0AgCMy+tcDYau/txaxmyz1v9oys8aPLDilN4ehDu1OQBCQB6D0OSuTIbI+LbwVqgiFcv+caqR0k5hSLcdFJfCd18tO6le09saX8J8aHlt5rDprF2Yt+eS9jPce4fFE8feLNPB23E1iAhPErD4dRiMrgSZ8nZIRpgaNULnIXZWMQ+n9HtOFJvNzLfGM8wvIuGRNr7Vn859+es23DqoeyuaF/atpji3Eh4IW6Yf6JbzH8skXJZnpmH9yspQohFgJBw98y+rSIwuXZKEDv8SG+ADpTNTVPIKJb7tEGRfJH6jzf2iLyys6ikXTW3ujsBwWQjqrcDnmwIO6R7BescXhVhTXFxtqjInE23ch+BXdndMASv42bfCy19ujCowSq0dgIblvdaBpDJpEOKRh08z/BZRsl56tmNMS+zkF7Ra7v6kWxbHsB1ehclmfevNJSjz9Ybuho7ko87jJ4m7hP+8S+P3EW1tc8jvrAPCHWL/CNJCny8f6L7sdbMcMPVfeoK7rNHTqfo1LyEFXA0TCNXbIBOaf8OqEMmiZOank5T3i7eMuH746PF6NWNgXiVsMjxZobTDS7zhSrICziwGLHYgHeXFA0hhrCmdga1KFazVS/1C+nrmHUPd+0TJNPiYbQOAlxT1lgI2+raYGl0Sfk5ifosZgzC0PjYkGcNNFkkEhBpzKrvSy/yWxtC5U7DZhbYgxkZKnubxpXJenpSvHJIbyABU2x3SEkJmAR1wM1b045GVV9FUy45aDoIgrobmaputr9M6JmCNLZc0HstpHCcOdgMfJZ/lALlA4VmsP0mK4w1BFFM/xMB Ib8BuNC5 Dr2fo0XJ2MJHVvRZBl50b2Prt8bViNdwOyAv3p9A39ge0JzkWEsff1OhY75EtFVjVMJMlXxLVTSJ6mSFIeQyjPB5a5LMcSKf7jwo+m44QuEZCNUvprFqIFbW1G8rUjWvEmQgwlB28zeudNPV8WXE/dvHR5xjJ2v8zu1DfGkeunqGuE5HqVd0TWlT8ZqeQNzjY6iHzEYbg+bS21ZWhF0F1ztove2plJxZrqTEdBkq8K6fF8hbRVa68gnzWFk9eLpL1MIk2dF+Z7CQCUdd7a+Jlmym61XSMvhWCT5YymzDenachqCxxVYakb+d7W5rnBe6LIK0hDruXDoP10qiyroJt0kfOpb9j50ZR1kw7wFObbkFsGl6ukeeaJTxM2OMKJSE/3dGV37TpesAQtTpqPTjfaSqFUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 18-12-23 16:35:43, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > This simple helper will be the basis of the writeback iterator. > To make this work, we need to remember the current index > and end positions in writeback_control. > > Signed-off-by: Matthew Wilcox (Oracle) > [hch: heavily rebased, add helpers to get the tag and end index, > don't keep the end index in struct writeback_control] > Signed-off-by: Christoph Hellwig Just two nits below. However you decide about them feel free to add: Reviewed-by: Jan Kara > +static pgoff_t wbc_end(struct writeback_control *wbc) > +{ > + if (wbc->range_cyclic) > + return -1; > + return wbc->range_end >> PAGE_SHIFT; > +} > + > +static void writeback_get_batch(struct address_space *mapping, > + struct writeback_control *wbc) > +{ > + folio_batch_release(&wbc->fbatch); > + cond_resched(); I'd prefer to have cond_resched() explicitely in the writeback loop instead of hidden here in writeback_get_batch() where it logically does not make too much sense to me... > + filemap_get_folios_tag(mapping, &wbc->index, wbc_end(wbc), > + wbc_to_tag(wbc), &wbc->fbatch); > +} > + > /** > * write_cache_pages - walk the list of dirty pages of the given address space and write all of them. > * @mapping: address space structure to write > @@ -2419,38 +2442,30 @@ int write_cache_pages(struct address_space *mapping, > void *data) > { > int error; > - int nr_folios; > - pgoff_t index; > pgoff_t end; /* Inclusive */ > - xa_mark_t tag; > > if (wbc->range_cyclic) { > - index = mapping->writeback_index; /* prev offset */ > + wbc->index = mapping->writeback_index; /* prev offset */ > end = -1; > } else { > - index = wbc->range_start >> PAGE_SHIFT; > + wbc->index = wbc->range_start >> PAGE_SHIFT; > end = wbc->range_end >> PAGE_SHIFT; > } Maybe we should have: end = wbc_end(wbc); when we have the helper? But I guess this gets cleaned up in later patches anyway so whatever. Honza -- Jan Kara SUSE Labs, CR