From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF37C35274 for ; Thu, 21 Dec 2023 11:00:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5126B0074; Thu, 21 Dec 2023 06:00:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 274E16B0075; Thu, 21 Dec 2023 06:00:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 116026B0078; Thu, 21 Dec 2023 06:00:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F3D5E6B0074 for ; Thu, 21 Dec 2023 06:00:02 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D1293140D33 for ; Thu, 21 Dec 2023 11:00:02 +0000 (UTC) X-FDA: 81590530644.26.07DEBB9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 1E87F14000B for ; Thu, 21 Dec 2023 10:59:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703156399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=cqdtmHWjwwyZQ/r4KJ3RGZEjIMQqYQPxNllJCmf+JZav/V0NuiaAS0Pv2nXPA3/y5555b4 AZ3WO/Q2tGjIlXhPwM+k7ED2615/QK1bHNNRInhXH6KdRsZPymJ12gyfi8ZyKrs27KAY/u g1HrsfMNU2JN/pLzGd2xTeu0kS6yS4Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703156399; a=rsa-sha256; cv=none; b=EiB2jEKeSBPVyM97ftcoYd22g2+2a2oSh+0Si5bKepE8rinJNyRfG2TmShe6OdLy60nCNC 3F+AacA48E6vuvXfMTcyPZZtKplXH1LgeuvrAMYkduSlbW9tmQT7vIO30T0Haee7UAkLIH KMeEKKxpmyJrym563iOZ2A7wo98irqE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6E4B91FB42; Thu, 21 Dec 2023 10:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=KOX9jgSmKdCXnbQ05qeZeEyD/jTUeiSMMXmb78ldAvYlyvqNxabY3TB6ALwaCCgEyDa3n8 EQBTpLoWyijBPOZDfC7W01R28BIHiyE+Ib/rJ+U27Bc44UXCjZagaGjB0rz+mDtleJUkuA MTvZYEbT7KizaGn9vezvjOCPie+ZLSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=a5SMVjtV5OgcuJnDegg+TTnF73BGoJXfTmVoKqFOhRO7o8ahluGCw/YOn/2FC3YHdka5M8 jkBuR0SECJwCKcAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=KOX9jgSmKdCXnbQ05qeZeEyD/jTUeiSMMXmb78ldAvYlyvqNxabY3TB6ALwaCCgEyDa3n8 EQBTpLoWyijBPOZDfC7W01R28BIHiyE+Ib/rJ+U27Bc44UXCjZagaGjB0rz+mDtleJUkuA MTvZYEbT7KizaGn9vezvjOCPie+ZLSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=a5SMVjtV5OgcuJnDegg+TTnF73BGoJXfTmVoKqFOhRO7o8ahluGCw/YOn/2FC3YHdka5M8 jkBuR0SECJwCKcAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 59D5213725; Thu, 21 Dec 2023 10:59:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GXLsFa0ahGVRUQAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 10:59:57 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 22EBAA07E3; Thu, 21 Dec 2023 11:59:57 +0100 (CET) Date: Thu, 21 Dec 2023 11:59:57 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] writeback: remove a duplicate prototype for tag_pages_for_writeback Message-ID: <20231221105957.havwaqt4ijlu6l65@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-6-hch@lst.de> X-Rspamd-Queue-Id: 1E87F14000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3dtoo6zjygcwccc673hobk3dgcgcmyko X-HE-Tag: 1703156398-342715 X-HE-Meta: U2FsdGVkX18jZwAkTgzZXsRBgPmrcrDfWBROl/fWAYvPouaNOuG1/5C+iUgfJWk8hDI3GFS29RxLruMQDF0TMgGgIYm2xL5727gU09PY+1lwdB4GZBPIHQmJkUj4vvbWJf3ism/EixTVVTM+2Ll5PG9JPIH+owR9qP1FAsr7UmmU7pVueNc8HttTHU/HGtLab+qvPxDuWs65j83uuwjgREH+HBRv9szuVR0V+QtCiHbngKsfIoLY9QuPvM3tc96oTpeaWvi/reEvu/9xHvxQhVrA9DQ52ZNH+1NyzRQyusoV56/JOWNr4IZbS3VLMqcfR/eusRaXnTmxyZ71+hEDqWyVOq6sm5AzpdpT1+IXc8DSPtXJ2xBsZUj3h90b4BR4Zc1LEJTZ2cVhbbp3kuN1c4WwEnthXJRbUtWZwbEkjmmE4osvKqFR8QfiKAU/SAnyLOlKt+ZmWJGVzlcecx/zO+QJmxBdhBkD9nk/eKHsGGmO4Y0/K4mEj0yib/+mogPiRLcws/k/RmwXiQnQ7v99IygEhpELzXS4gKaeIfjkUuiXf2isITODLFFpJd8/Jy0l+kycTS8VtiK4wJCrr44he0/7enVFkTL+ZlcatfAP9kDMov4+NxA+093NoKquceUoCk77+bzgn6B9c6ajlCIBTT1TSZeNoc7LgYc3OaGc6xOX3CTQVdQdftfzpHZcrFZSXmmcIwfguvHu7T3YYEmM0/3DrqUg3escBr1Kh5AsIzaT3Dlva+MpDq6ivCuGQ+FHlim7XFgzVbln4xHcpEP+ItBWECX9EHdzjyJ82Da2zYD9rghdv5e1p7QcmPOmDtzsSF+yAoZ4QbMENerZSR8pfGogEpcFOSxP3Mkk2fD/pMdxWPUWUQBgN38a4lsBr1NFX4TU0tNqY5PnPp/IJZ7vBMFaES66TnME+Qjhyhiype+KSYUp2xbNTBoAGDlkKpcj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 18-12-23 16:35:41, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > Signed-off-by: Christoph Hellwig > [hch: split from a larger patch] > Signed-off-by: Matthew Wilcox (Oracle) Sure. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/writeback.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 083387c00f0c8b..833ec38fc3e0c9 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -364,8 +364,6 @@ bool wb_over_bg_thresh(struct bdi_writeback *wb); > typedef int (*writepage_t)(struct folio *folio, struct writeback_control *wbc, > void *data); > > -void tag_pages_for_writeback(struct address_space *mapping, > - pgoff_t start, pgoff_t end); > int write_cache_pages(struct address_space *mapping, > struct writeback_control *wbc, writepage_t writepage, > void *data); > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR