From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050F4C35274 for ; Thu, 21 Dec 2023 08:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617686B0071; Thu, 21 Dec 2023 03:13:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C5816B0075; Thu, 21 Dec 2023 03:13:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B40A6B0078; Thu, 21 Dec 2023 03:13:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3CAF46B0071 for ; Thu, 21 Dec 2023 03:13:28 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1309C405B1 for ; Thu, 21 Dec 2023 08:13:28 +0000 (UTC) X-FDA: 81590110896.12.37727C1 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf21.hostedemail.com (Postfix) with ESMTP id EA8DE1C0009 for ; Thu, 21 Dec 2023 08:13:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bJPsA3Od; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703146406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TlVlCHdINWUQiqZsia9JThp9Z+zsHuZHc773Y+yBfJU=; b=COXx+skeaXPnhK29/s1zWuH0I2OSbOOdrhl/pJdIZ3LwPMf9Ox+atH4ZCjHuHePcV5W9S8 NBX1MAme9PKZx5BVHKwnU580DUrvv1q0a4Nt+5vosyyQyVkZc2gta2TzyT5eYBb7JGa84h uQS0bkYYMXOvIjLJgWG9D8R6+Ff6/sc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bJPsA3Od; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703146406; a=rsa-sha256; cv=none; b=xfHg6wkdXaAaS7WU/qDGP1OVS4ncKIfLxOCX6xIveEDBEgXIcvt7R4gCyE7D7VMZHfau1f Mucf3d/7a8TUnBGq2RjNmynfBFEkOhC5Ea2chv+gDC4xyZZoIRYeD2RjrbIkkycqANn1KU EYxNY3urPS9qr84TsHlW3ma6I7z12Sc= Date: Thu, 21 Dec 2023 17:13:09 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703146399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TlVlCHdINWUQiqZsia9JThp9Z+zsHuZHc773Y+yBfJU=; b=bJPsA3Oda69G/YgDW7AKSZx7jxGYdWTbIEBAvKafSZQ++oQcYmeZQy4udncX7wd3uHjmwb LZmmG54ZGk90Tts0lhezPfmLIMKxfzDBttEE27jbOmw9b3uxGZEKbGKel63aR+lvcoj4P7 Sk5HJy+z+kVHNWj+ItUEMUOIyVUoUx4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Naoya Horiguchi , Dan Williams , stable@vger.kernel.org Subject: Re: [PATCH 1/3] mm/memory-failure: Pass the folio and the page to collect_procs() Message-ID: <20231221081309.GA1295773@ik1-406-35019.vs.sakura.ne.jp> References: <20231218135837.3310403-1-willy@infradead.org> <20231218135837.3310403-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231218135837.3310403-2-willy@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: EA8DE1C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gadw1fz84jmmkqkhgwdmxksadxxdakgd X-HE-Tag: 1703146405-472244 X-HE-Meta: U2FsdGVkX19lK2owZyNTuwFGcHoVqmqN0u/K6TesX+SQYr3wyuwqRTEqQEWZbgjeadJR0MY33fF4qBlmDHRkovPL283QafdtBidj9fwguCVT04+6VQ7ipcoACD64KzLCdQv1ltOUw158/h/tdmvpREQ1tYHLwFAp0LoLTQLOcc7TSFEeTQ3mh4ESio2YjI8zjBZrFbvKkk9tLhP0m3KBOgK0H7uQRZ1xhoz5kcnr+F6fO+gLj3rxJcVBuPliObhgj1L9WBlcy7f++cZyq+rbh7kWP+gtx1vNG6WDUgQkFkPdkhpIPZZbdviIUVqMn8Ac+rm6cgcGgR27NHd0+oj4uhbo+UQuFlAMg15jwXZLKpFFklDmLTJE24vlruQqU87/vp5RUcX4+lK5xO4MWKhgsg0YEIdkV39s1Iq7jEgtPZUO/7con4dAZvDUMnTxpAzXJNoh7cFG49w6h8neCYxyG3pIs9WWoR8LChKzcaNfAlzbHZdZD6vAOhIcKgDJ3YuJ0RquOp0pCD2qV3Hwvd5HnphVqMlm5Fni9MgtfPX2o9ZCiNnNVT86APAfLY0th6XAdW9ZRnkVEh01ErQ7ODHBUpSRYYAksXCnnf9Azc5bYhePAJJx5tbiJYfl+kBO6Fc6+iiELPMWhrmMrqGOfZMoh1sYlC4HLn5FQAC0xl7sL7TO9ptli1+YxwSpTiAwP/7arQTfTfHiIB81zAPDcdNiJgiAIwSl3TeOQ0fZRoLbeEAllLrZZTBC73mIuP7X5muyJveTjMljAKzstv9ZHcvL29JZMmcLgFdKj9t6tkECMExM4TaD6qnioDX3JwUcy6VIojGaw1pylh4Hb+AKIdKn6Ya65VXzXi4iguu7GcGvJJ9kUajeFXbYtUK2hiGvd0/ehWMKSAJ9+7G+mcvivzH75WR0UOla9zbQ5GF6P5b5hPIdbZbRE3JzoXwVWnlz83IYhlx8iZ9S5+/KiNB6q/o OBte0O0e Wk8zkPqP1qAAyRSd9ffdQG0wpOySfT+Quf3mnpypJ/rg9taj+aJHjaxIcQyZbYCeqwY/qv+a/8eH1stvoteAyma3LzaWiZEoVTnsHmcSz0VJq8QFAG/6Ug1AmpgKA8EctNeT5zbMY1zOyDPhw1neUVIT0fCBKV6QLatL2aDLuojNNlKxHxCJtEGw7jyLC6Z5EsvVxdTaMFLb9TkUD2ZzcnsiZ5n/hGxQ786pP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 01:58:35PM +0000, Matthew Wilcox (Oracle) wrote: > Both collect_procs_anon() and collect_procs_file() iterate over the VMA > interval trees looking for a single pgoff, so it is wrong to look for > the pgoff of the head page as is currently done. However, it is also > wrong to look at page->mapping of the precise page as this is invalid > for tail pages. Clear up the confusion by passing both the folio and > the precise page to collect_procs(). > > Fixes: 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling") > Cc: stable@vger.kernel.org > Signed-off-by: Matthew Wilcox (Oracle) Looks good to me, thank you. Acked-by: Naoya Horiguchi