From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Dan Williams <dan.j.williams@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/memory-failure: Pass the folio and the page to collect_procs()
Date: Thu, 21 Dec 2023 17:13:09 +0900 [thread overview]
Message-ID: <20231221081309.GA1295773@ik1-406-35019.vs.sakura.ne.jp> (raw)
In-Reply-To: <20231218135837.3310403-2-willy@infradead.org>
On Mon, Dec 18, 2023 at 01:58:35PM +0000, Matthew Wilcox (Oracle) wrote:
> Both collect_procs_anon() and collect_procs_file() iterate over the VMA
> interval trees looking for a single pgoff, so it is wrong to look for
> the pgoff of the head page as is currently done. However, it is also
> wrong to look at page->mapping of the precise page as this is invalid
> for tail pages. Clear up the confusion by passing both the folio and
> the precise page to collect_procs().
>
> Fixes: 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks good to me, thank you.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
next prev parent reply other threads:[~2023-12-21 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 13:58 [PATCH 0/3] Three memory-failure fixes Matthew Wilcox (Oracle)
2023-12-18 13:58 ` [PATCH 1/3] mm/memory-failure: Pass the folio and the page to collect_procs() Matthew Wilcox (Oracle)
2023-12-21 8:13 ` Naoya Horiguchi [this message]
2023-12-18 13:58 ` [PATCH 2/3] mm/memory-failure: Check the mapcount of the precise page Matthew Wilcox (Oracle)
2023-12-22 1:23 ` Naoya Horiguchi
2023-12-18 13:58 ` [PATCH 3/3] mm/memory-failure: Cast index to loff_t before shifting it Matthew Wilcox (Oracle)
2023-12-21 8:13 ` Naoya Horiguchi
2023-12-18 14:03 ` [PATCH] mailmap: Add an old address for Naoya Horiguchi Matthew Wilcox (Oracle)
2023-12-21 8:15 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221081309.GA1295773@ik1-406-35019.vs.sakura.ne.jp \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox