From: Yang Shi <shy828301@gmail.com>
To: oliver.sang@intel.com, riel@surriel.com, fengwei.yin@intel.com,
willy@infradead.org, cl@linux.com, ying.huang@intel.com,
akpm@linux-foundation.org
Cc: shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 1/2] mm: mmap: no need to call khugepaged_enter_vma() for stack
Date: Wed, 20 Dec 2023 22:59:42 -0800 [thread overview]
Message-ID: <20231221065943.2803551-1-shy828301@gmail.com> (raw)
From: Yang Shi <yang@os.amperecomputing.com>
We avoid allocating THP for temporary stack, even tnough
khugepaged_enter_vma() is called for stack VMAs, it actualy returns
false. So no need to call it in the first place at all.
Signed-off-by: Yang Shi <yang@os.amperecomputing.com>
---
mm/mmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index b78e83d351d2..2ff79b1d1564 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2046,7 +2046,6 @@ static int expand_upwards(struct vm_area_struct *vma, unsigned long address)
}
}
anon_vma_unlock_write(vma->anon_vma);
- khugepaged_enter_vma(vma, vma->vm_flags);
mas_destroy(&mas);
validate_mm(mm);
return error;
@@ -2140,7 +2139,6 @@ int expand_downwards(struct vm_area_struct *vma, unsigned long address)
}
}
anon_vma_unlock_write(vma->anon_vma);
- khugepaged_enter_vma(vma, vma->vm_flags);
mas_destroy(&mas);
validate_mm(mm);
return error;
--
2.41.0
next reply other threads:[~2024-01-09 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 6:59 Yang Shi [this message]
2023-12-21 6:59 ` [PATCH 2/2] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE Yang Shi
2024-01-10 1:36 ` Yin Fengwei
2024-01-16 19:22 ` Zach O'Keefe
2024-01-16 20:57 ` Yang Shi
2024-01-16 21:31 ` Andrew Morton
2024-01-31 7:53 ` Florian Weimer
2024-01-31 18:46 ` Yang Shi
2024-02-01 15:34 ` Florian Weimer
2024-02-01 19:00 ` Yang Shi
2024-01-10 1:35 ` [PATCH 1/2] mm: mmap: no need to call khugepaged_enter_vma() for stack Yin Fengwei
2024-01-15 5:50 ` Huang, Ying
2024-01-16 21:39 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221065943.2803551-1-shy828301@gmail.com \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oliver.sang@intel.com \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox