From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD21C3DA6E for ; Wed, 20 Dec 2023 21:40:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A09738D0001; Wed, 20 Dec 2023 16:40:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B9BA6B0078; Wed, 20 Dec 2023 16:40:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 881878D0001; Wed, 20 Dec 2023 16:40:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7AFA66B0075 for ; Wed, 20 Dec 2023 16:40:08 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4AB5F1403AF for ; Wed, 20 Dec 2023 21:40:08 +0000 (UTC) X-FDA: 81588514896.21.2615D2F Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf19.hostedemail.com (Postfix) with ESMTP id A4F761A0010 for ; Wed, 20 Dec 2023 21:40:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hAMfVIdA; spf=pass (imf19.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703108405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MKJBECd4R8njoEhQpBoXguZPfsz8RJrc1vVZeI2+VE=; b=1yoUBBzCX+LfZ0M9Q+SDWQTItmCMAyQQiPeFOS2SKz9m+xNeTlMy/d7j3haao0u2D0hGuO P6p006IohdrFZqpOqYkKmd+cPq/HU014m3bXEGTAUiEzkf/tqbD4azSl/iUN6cisD7Ecfo yhGEtzczBrsrvIG3LzAuK2GxRyYb4fk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703108405; a=rsa-sha256; cv=none; b=rWlkCzTROnoLt/Qz+ZJfrTKvCkZ9mFg+/dlEJQ6POe789nq2iAX6wQCzzSAWiPOlskHwN9 kLI0AYjUddqS21JnnIQ0s/DtfjsfuLvvjjb5W1qj+PRpFfmTg/dWD7Mf+kJHOe8fD2vrns wuLechr+4UzK1XF+PdLImALpFnBInvc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hAMfVIdA; spf=pass (imf19.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 20 Dec 2023 16:39:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703108402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9MKJBECd4R8njoEhQpBoXguZPfsz8RJrc1vVZeI2+VE=; b=hAMfVIdAcvKAqpVeEmLbf794s30T+d2XRrj0W3ZmVnnDFQOyAgAcVKoz2+E8Bri27NJT3i R6rqYna2x1MEHOkr1ifi42C0N61Fj7ic4zkL//pKIN20NgjeEVzs69DE1aUNcG+xJpKm6J PwTTmScxncX2W0xDyH03mhGmmhCdHXQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 50/50] Kill sched.h dependency on rcupdate.h Message-ID: <20231220213957.zbslehrx4zkkbabq@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-7-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A4F761A0010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: c63zeyeon1tmqogmmnjxc7d67d5tnn3w X-HE-Tag: 1703108405-181369 X-HE-Meta: U2FsdGVkX18czHX7sjecEOuPP6axuCBYh96HxE1N3ofdnxUx4P/c9JUnIumIVOyJEXkWh5XBPl8esQQTNMxa3xr9Alz+Ku6b4HFHSY1Ffpn+jGyTxyab4KzmXBczijyB5rSCGZYIZlTu5E4jwh5lkDsKWMMv5Ib7tJlUtIIemRxFLG+jhgmikqwbJ7Wbp6bNA6RygSE0A4q8C3pM4zXoUIYG5DCQiwoHC2/eaRGNZTamfdAyOPumbcE6p4w5+Cekfl8Sw1Gy9uMEHw5boBh74YfwFlKVQX+EieyGe5EHjAeBMMHbSqiYcsF0HESd3BLJQrXbMo1MTUz48EYWlJitSlxUlS3CGTsYTIw4MlSHCceMPq7oHMdTyPtsv+I1t11OsGF3JbnLi12y6BT9fJPRd2l+aMzDebbU1qIOdBItdmZqpGgrGIn9i7X6gEapfAh9acPgz/3UCIDBgshi3Ts4Ogi+f/cybP+iFC969kuaMDDgUKjt5x0O4SyAfE5UWPrZpLFKGtn32BQy+BCRVm5+ewyAWQ/PTASEPH+QlC8gW8nfTGPUVckExk/glv51TMaFgDRCfz8YeoePTC9ZZeyvOxQ0oJls4xvGlo/nDdVrq1abxu/wGgaeGj+66Q7SVUwuiodZ3qGdfdJQotvppx331hL2BGzbBUOXyHKwPBdHGckI9SgkZVBdwHkc+yuZCtecaHk/++BHdMSTscDVP8U6ouXFlHRQ0aZ/qAfu07PrGQNujFZhqxdGVZXwOzVSbu1JgUrzRPzhJXErvNQDLNlP5fnT5hW+47KK7suExP6keBaXxBrc+uIc/WhzIhir7QfWp1HfTHHpSXg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 20, 2023 at 12:59:44PM +0100, Geert Uytterhoeven wrote: > Hi Kent, > > On Sat, Dec 16, 2023 at 4:39 AM Kent Overstreet > wrote: > > by moving cond_resched_rcu() to rcupdate.h, we can kill another big > > sched.h dependency. > > > > Signed-off-by: Kent Overstreet > > Thanks for your patch, which is now commit dc00f26faea81dc0 ("Kill > sched.h dependency on rcupdate.h") in next-20231220. > > Reported-by: noreply@ellerman.id.au > > $ make ARCH=m68k defconfig arch/m68k/kernel/asm-offsets.i > *** Default configuration is based on 'multi_defconfig' > # > # No change to .config > # > UPD include/config/kernel.release > UPD include/generated/utsrelease.h > CC arch/m68k/kernel/asm-offsets.s > In file included from ./include/asm-generic/bug.h:7, > from ./arch/m68k/include/asm/bug.h:32, > from ./include/linux/bug.h:5, > from ./include/linux/thread_info.h:13, > from ./arch/m68k/include/asm/processor.h:11, > from ./include/linux/sched.h:13, > from arch/m68k/kernel/asm-offsets.c:15: > ./arch/m68k/include/asm/processor.h: In function ‘set_fc’: > ./arch/m68k/include/asm/processor.h:91:15: error: implicit declaration > of function ‘in_interrupt’ [-Werror=implicit-function-declaration] > 91 | WARN_ON_ONCE(in_interrupt()); > | ^~~~~~~~~~~~ > ./include/linux/once_lite.h:28:27: note: in definition of macro > ‘DO_ONCE_LITE_IF’ > 28 | bool __ret_do_once = !!(condition); \ > | ^~~~~~~~~ > ./arch/m68k/include/asm/processor.h:91:2: note: in expansion of macro > ‘WARN_ON_ONCE’ > 91 | WARN_ON_ONCE(in_interrupt()); > | ^~~~~~~~~~~~ > cc1: some warnings being treated as errors > make[3]: *** [scripts/Makefile.build:116: > arch/m68k/kernel/asm-offsets.s] Error 1 > make[2]: *** [Makefile:1191: prepare0] Error 2 > make[1]: *** [Makefile:350: __build_one_by_one] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 Applying this fix: commit 0d7bdfe9726b275c7e9398047763a144c790b575 Author: Kent Overstreet Date: Wed Dec 20 16:39:21 2023 -0500 m68k: Fix missing include Signed-off-by: Kent Overstreet diff --git a/arch/m68k/include/asm/processor.h b/arch/m68k/include/asm/processor.h index 7a2da780830b..8f2676c3a988 100644 --- a/arch/m68k/include/asm/processor.h +++ b/arch/m68k/include/asm/processor.h @@ -8,6 +8,7 @@ #ifndef __ASM_M68K_PROCESSOR_H #define __ASM_M68K_PROCESSOR_H +#include #include #include #include