From: Kent Overstreet <kent.overstreet@linux.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, tglx@linutronix.de,
x86@kernel.org, tj@kernel.org, peterz@infradead.org,
mathieu.desnoyers@efficios.com, paulmck@kernel.org,
keescook@chromium.org, dave.hansen@linux.intel.com,
mingo@redhat.com, will@kernel.org, longman@redhat.com,
boqun.feng@gmail.com, brauner@kernel.org
Subject: Re: [PATCH 50/50] Kill sched.h dependency on rcupdate.h
Date: Wed, 20 Dec 2023 16:39:57 -0500 [thread overview]
Message-ID: <20231220213957.zbslehrx4zkkbabq@moria.home.lan> (raw)
In-Reply-To: <CAMuHMdW29dAQh+j3s4Af1kMAFKSr2yz7M2L-fWd1uZfL7mEY1Q@mail.gmail.com>
On Wed, Dec 20, 2023 at 12:59:44PM +0100, Geert Uytterhoeven wrote:
> Hi Kent,
>
> On Sat, Dec 16, 2023 at 4:39 AM Kent Overstreet
> <kent.overstreet@linux.dev> wrote:
> > by moving cond_resched_rcu() to rcupdate.h, we can kill another big
> > sched.h dependency.
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
>
> Thanks for your patch, which is now commit dc00f26faea81dc0 ("Kill
> sched.h dependency on rcupdate.h") in next-20231220.
>
> Reported-by: noreply@ellerman.id.au
>
> $ make ARCH=m68k defconfig arch/m68k/kernel/asm-offsets.i
> *** Default configuration is based on 'multi_defconfig'
> #
> # No change to .config
> #
> UPD include/config/kernel.release
> UPD include/generated/utsrelease.h
> CC arch/m68k/kernel/asm-offsets.s
> In file included from ./include/asm-generic/bug.h:7,
> from ./arch/m68k/include/asm/bug.h:32,
> from ./include/linux/bug.h:5,
> from ./include/linux/thread_info.h:13,
> from ./arch/m68k/include/asm/processor.h:11,
> from ./include/linux/sched.h:13,
> from arch/m68k/kernel/asm-offsets.c:15:
> ./arch/m68k/include/asm/processor.h: In function ‘set_fc’:
> ./arch/m68k/include/asm/processor.h:91:15: error: implicit declaration
> of function ‘in_interrupt’ [-Werror=implicit-function-declaration]
> 91 | WARN_ON_ONCE(in_interrupt());
> | ^~~~~~~~~~~~
> ./include/linux/once_lite.h:28:27: note: in definition of macro
> ‘DO_ONCE_LITE_IF’
> 28 | bool __ret_do_once = !!(condition); \
> | ^~~~~~~~~
> ./arch/m68k/include/asm/processor.h:91:2: note: in expansion of macro
> ‘WARN_ON_ONCE’
> 91 | WARN_ON_ONCE(in_interrupt());
> | ^~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [scripts/Makefile.build:116:
> arch/m68k/kernel/asm-offsets.s] Error 1
> make[2]: *** [Makefile:1191: prepare0] Error 2
> make[1]: *** [Makefile:350: __build_one_by_one] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
Applying this fix:
commit 0d7bdfe9726b275c7e9398047763a144c790b575
Author: Kent Overstreet <kent.overstreet@linux.dev>
Date: Wed Dec 20 16:39:21 2023 -0500
m68k: Fix missing include
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
diff --git a/arch/m68k/include/asm/processor.h b/arch/m68k/include/asm/processor.h
index 7a2da780830b..8f2676c3a988 100644
--- a/arch/m68k/include/asm/processor.h
+++ b/arch/m68k/include/asm/processor.h
@@ -8,6 +8,7 @@
#ifndef __ASM_M68K_PROCESSOR_H
#define __ASM_M68K_PROCESSOR_H
+#include <linux/preempt.h>
#include <linux/thread_info.h>
#include <asm/fpu.h>
#include <asm/ptrace.h>
next prev parent reply other threads:[~2023-12-20 21:40 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 2:47 [PATCH 00/50] big header dependency cleanup targeting sched.h Kent Overstreet
2023-12-16 2:47 ` [PATCH 01/50] drivers/gpu/drm/i915/i915_memcpy.c: fix missing includes Kent Overstreet
2024-03-08 13:46 ` Jani Nikula
2023-12-16 2:47 ` [PATCH 02/50] x86/kernel/fpu/bugs.c: fix missing include Kent Overstreet
2023-12-18 11:08 ` Sohil Mehta
2023-12-19 2:05 ` Kent Overstreet
2023-12-16 2:47 ` [PATCH 03/50] x86/lib/cache-smp.c: " Kent Overstreet
2023-12-18 10:48 ` Sohil Mehta
2023-12-19 2:06 ` Kent Overstreet
2023-12-19 4:04 ` Sohil Mehta
2023-12-16 2:47 ` [PATCH 04/50] x86/include/asm/debugreg.h: " Kent Overstreet
2023-12-16 2:47 ` [PATCH 05/50] x86/include/asm/paravirt_types.h: " Kent Overstreet
2023-12-16 2:47 ` [PATCH 06/50] task_stack.h: add " Kent Overstreet
2023-12-16 2:47 ` [PATCH 07/50] nsproxy.h: " Kent Overstreet
2023-12-16 2:47 ` [PATCH 08/50] kernel/fork.c: " Kent Overstreet
2023-12-16 2:47 ` [PATCH 09/50] kmsan: add missing types.h dependency Kent Overstreet
2023-12-16 2:47 ` [PATCH 10/50] time_namespace.h: fix missing include Kent Overstreet
2023-12-16 3:26 ` [PATCH 11/50] nodemask: Split out include/linux/nodemask_types.h Kent Overstreet
2023-12-16 3:26 ` [PATCH 12/50] prandom: Remove unused include Kent Overstreet
2023-12-16 18:52 ` Randy Dunlap
2023-12-16 22:19 ` Kent Overstreet
2023-12-16 3:26 ` [PATCH 13/50] timekeeping: Kill percpu.h dependency Kent Overstreet
2023-12-16 3:26 ` [PATCH 14/50] arm64: Fix circular header dependency Kent Overstreet
2023-12-16 3:26 ` [PATCH 15/50] kernel/numa.c: Move logging out of numa.h Kent Overstreet
2023-12-19 16:36 ` Nathan Chancellor
2023-12-19 21:02 ` Kent Overstreet
2023-12-19 22:52 ` Matthew Wilcox
2023-12-20 0:37 ` Kent Overstreet
2023-12-16 3:26 ` [PATCH 16/50] sched.h: Move (spin|rwlock)_needbreak() to spinlock.h Kent Overstreet
2024-01-15 20:31 ` Leonardo Bras
2023-12-16 3:26 ` [PATCH 17/50] ktime.h: move ktime_t to types.h Kent Overstreet
2023-12-16 3:26 ` [PATCH 18/50] hrtimers: Split out hrtimer_types.h Kent Overstreet
2023-12-16 3:26 ` [PATCH 19/50] locking/mutex: split out mutex_types.h Kent Overstreet
2023-12-18 16:53 ` Waiman Long
2023-12-18 18:12 ` Waiman Long
2023-12-19 1:46 ` Kent Overstreet
2023-12-19 3:04 ` Waiman Long
2023-12-19 3:37 ` Kent Overstreet
2023-12-19 3:39 ` Waiman Long
2023-12-16 3:26 ` [PATCH 20/50] posix-cpu-timers: Split out posix-timers_types.h Kent Overstreet
2023-12-16 3:26 ` [PATCH 21/50] locking/seqlock: Split out seqlock_types.h Kent Overstreet
2023-12-18 17:02 ` Waiman Long
2023-12-16 3:29 ` [PATCH 22/50] pid: Split out pid_types.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 23/50] sched.h: move pid helpers to pid.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 24/50] plist: Split out plist_types.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 25/50] wait: Remove uapi header file from main header file Kent Overstreet
2023-12-18 12:39 ` Christian Brauner
2023-12-16 3:29 ` [PATCH 26/50] rslib: kill bogus dependency on list.h Kent Overstreet
2023-12-16 19:05 ` Randy Dunlap
2023-12-16 19:09 ` Kent Overstreet
2023-12-16 19:10 ` Randy Dunlap
2023-12-16 3:29 ` [PATCH 27/50] timerqueue: Split out timerqueue_types.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 28/50] signal: Kill bogus dependency on list.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 29/50] timers: Split out timer_types.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 30/50] workqueue: Split out workqueue_types.h Kent Overstreet
2023-12-16 3:29 ` [PATCH 31/50] shm: Slim down dependencies Kent Overstreet
2023-12-16 3:29 ` [PATCH 32/50] ipc: Kill bogus dependency on spinlock.h Kent Overstreet
2023-12-18 11:04 ` [PATCH 22/50] pid: Split out pid_types.h Christian Brauner
2023-12-16 3:32 ` [PATCH 33/50] Split out irqflags_types.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 34/50] mm_types_task.h: Trim dependencies Kent Overstreet
2023-12-16 3:32 ` [PATCH 35/50] cpumask: Split out cpumask_types.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 36/50] syscall_user_dispatch.h: split out *_types.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 37/50] x86/signal: kill dependency on time.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 38/50] uapi/linux/resource.h: fix include Kent Overstreet
2023-12-16 3:32 ` [PATCH 39/50] refcount: Split out refcount_types.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 40/50] seccomp: Split out seccomp_types.h Kent Overstreet
2023-12-16 3:32 ` [PATCH 41/50] uidgid: Split out uidgid_types.h Kent Overstreet
2023-12-18 11:01 ` Christian Brauner
2023-12-16 3:32 ` [PATCH 42/50] sem: Split out sem_types.h Kent Overstreet
2023-12-20 11:53 ` Geert Uytterhoeven
2023-12-20 21:39 ` Kent Overstreet
2024-01-02 8:47 ` Geert Uytterhoeven
2023-12-16 3:32 ` [PATCH 43/50] lockdep: move held_lock to lockdep_types.h Kent Overstreet
2023-12-18 17:05 ` Waiman Long
2023-12-16 3:35 ` [PATCH 44/50] restart_block: Trim includes Kent Overstreet
2023-12-16 3:35 ` [PATCH 45/50] rseq: Split out rseq.h from sched.h Kent Overstreet
2023-12-16 3:35 ` [PATCH 46/50] preempt.h: Kill dependency on list.h Kent Overstreet
2023-12-16 6:13 ` Matthew Wilcox
2023-12-16 19:21 ` Randy Dunlap
2023-12-16 22:35 ` Kent Overstreet
2023-12-17 0:04 ` Randy Dunlap
2023-12-17 0:18 ` Matthew Wilcox
2023-12-17 0:20 ` Kent Overstreet
2023-12-17 2:03 ` Randy Dunlap
2023-12-17 2:05 ` Kent Overstreet
2023-12-17 0:18 ` Kent Overstreet
2023-12-17 0:26 ` Randy Dunlap
2023-12-16 3:35 ` [PATCH 47/50] thread_info, uaccess.h: Move HARDENED_USERCOPY to better location Kent Overstreet
2023-12-16 3:35 ` [PATCH 48/50] Kill unnecessary kernel.h include Kent Overstreet
2023-12-16 3:35 ` [PATCH 49/50] kill unnecessary thread_info.h include Kent Overstreet
2023-12-16 3:35 ` [PATCH 50/50] Kill sched.h dependency on rcupdate.h Kent Overstreet
2023-12-16 19:35 ` Paul E. McKenney
2023-12-16 22:20 ` Kent Overstreet
2023-12-20 11:59 ` Geert Uytterhoeven
2023-12-20 21:39 ` Kent Overstreet [this message]
2024-01-02 11:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220213957.zbslehrx4zkkbabq@moria.home.lan \
--to=kent.overstreet@linux.dev \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox