From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29697C3DA6E for ; Wed, 20 Dec 2023 17:37:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9D1D8D0003; Wed, 20 Dec 2023 12:37:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4DA68D0002; Wed, 20 Dec 2023 12:37:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D388D0003; Wed, 20 Dec 2023 12:37:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 94C928D0002 for ; Wed, 20 Dec 2023 12:37:26 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F605803E3 for ; Wed, 20 Dec 2023 17:37:26 +0000 (UTC) X-FDA: 81587903292.01.DB2DB69 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf29.hostedemail.com (Postfix) with ESMTP id 5F538120003 for ; Wed, 20 Dec 2023 17:37:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=GfmTgFsO; spf=none (imf29.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703093844; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P5Zs3qECdjn7uq4jzjXFG/AJJqVMTzM5KFD78T4GWU4=; b=YrU9/EDqgBm41eeG3pTPgIBBiG9tt1bolb49deOb/2XX7Zd7NlaJaf0tmLmepim/1ZPkPl w5/dLM56pguj3PhxMWYQlr9tewtcHBISu3r0upf02rCU12P56D6XxZWnbcNsxZJiFMYVI1 f29nDDX3mKYmpneI+sNyjeWqSQcayFY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=GfmTgFsO; spf=none (imf29.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703093844; a=rsa-sha256; cv=none; b=wnbpCGWT4oxUj8VT2Gla6vBqyJPVm90pzMjl7qFetpB4lDdL5lBDQA2VhYagfpXe7hsDA/ OxZBJ04q/g2SKC8UUZNAcVwdhP4/crap1FO0mBA/GbQlTd/1KO/Ff19ER+KNzKCZdCMirR Yvum4PhnYElA8VgKkVd3pQFRf+inAnw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P5Zs3qECdjn7uq4jzjXFG/AJJqVMTzM5KFD78T4GWU4=; b=GfmTgFsO7WZPUWeQIz8wIkLZ78 QXBR2nKA1E1i7bc9cqlCtY9FA1rTaF5acFIypfpjPlpfwK1VOFWmA5eadcG2H/amCG00+cEZUBh+n 9NmflrX0pngURp6SJeC9zhL0f+YuyA4P/mls6iJO5P8o58AAgNFPp5+OqL3/1KVhuZvhSq+sdMTkk RbBfUUFCYJNnsU/8a8Fs2f4gAA+ZaDX5OgGJavV/IGKMR8ilaozWC33JHq56s5vxyZH/CGAM/6nEr vvZqgQNVHHZSmJ8yt5hGqDGZrJWhl7oPmJzjvP79kjhUeWdQ3lekSsgB45nOoJ/vUkuZhsys4+rMH yteTPRUg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rG0VK-000X0K-2h; Wed, 20 Dec 2023 17:37:10 +0000 Date: Wed, 20 Dec 2023 17:37:10 +0000 From: Al Viro To: Baoquan He Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode Message-ID: <20231220173710.GX1674809@ZenIV> References: <202312182200.Ka7MzifQ-lkp@intel.com> <20231220060030.GV1674809@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5F538120003 X-Rspam-User: X-Stat-Signature: y8hu5ddehqrsuzu6c9bapeg9dxrxhj9d X-Rspamd-Server: rspam01 X-HE-Tag: 1703093844-2275 X-HE-Meta: U2FsdGVkX1+3DiMJBmqBdI1w8ODeSO6zVg4iVVXbzz4sBe2DkcYRAllbByIfG6Iv5SG3YkidVawrvFUeEZsidFZlOWlhZ8UfkLkoGeJ2LN9thiC26x/P+yK4h6WkS+sZIp0toybKzYxeyB5jWhKxBG91goGvfljCp+jLcJM/54vlKwLhGRSc80BS7Kgz8U3hOHXl3fr8UaEaaKc4SrshYgyMVZfrrV7OmhwbDv7yRpKcMnPwvwQibp1WzymrDBKYVaGiJFtHdwPG7MbBuO0w/qNttGg09UmMR8kLmVSG0LA5WgXgAcu7bW9/k/ukTnDTRe8q6gp6y0ornESiXq7MM4s0kvp74RR/Z61G9oJN3Pvv2JAU9iqLDk/H6KD5FRLQVtbkmFf/v4kf9j7bVIjTfU7ldEpLkqjgAvrSxPhf0wvWfAR5jX81n63iFECMF7DWcId2PXucNSuC56ph0f5do0WHXZnhLfZI/8bRjCyP7oeqXJlsdVnWgtOuS08S3rM8cK1+T7HAQ4vcHvQUrdn1zQfn7wjiZDrlHBK5hXqFEoveWu2oq3Qps8cdDq1czC7b8X7UcLgcyCIHTMjvQy06hniKlTpOD9vBY4fAYWgyhWwaPJUPjMM2rSkAiY3IypK+ltjaxmKhQL200S8hahqJzbJ3UWwIFLN0bjj0ee9+S91pQFx6JSo9NFYXUlr2mofM9tn9N0Q/XEdFK9zwKL4nWoLOgDDLAuUKrLjgRsadyKvcUyCuq3iw6ko754QaRh/SAt+z4OSyv28KR/cFXLeEFBq3WnZX3n+k7oa52ygx9w0lJ3+rMHQPuru6aamqOF45k/UAvxJul8Ivte3cs1ix89hlC4FSmGGXB3S0G5h5uGVd3sKvv9QdU5HKHPa09AdRXgUxm78v3m0q5z+zKtJlBUMxiYZL8z5twRjwJUhM3hBOa+KgRmOQBmz8BUq+iD9gNJLtppx1E911PJFqxj4 X6Dxo/we ve18yNforiGA1gzGXaxBXP09BXNj7R3t0fleGY+xewiDl8VscHe8lsLa8END0f3z0ytTYJGAam+elRuLJDf5P6DrlyOV+ni8dfXGTLiSktl23I2S6IoJPMg+BczFtNL2gRHGg1ffsyLhE6QMp4qXxwNl7FXU/CdSfIEVifdjiXTtZlf/9VKd7HwbyXqckpBnFW+YpOU8uekSRh3+QhcKOXg1/op8hsEN9CR8WZ8fGDUIzcRmCQb9YS/GoFj5VTL92RspzoMf2G5DAgAoId41kkWpuDw4fGU4IuGJHe2/Y30Ublg9Nm1WcmoQKx3OUKtPB+i64xHXXuOvehURPZrbU8UaRiWeXEpgEnshwURbuB8RY4W47VaE3J9ZJo1ZQZVB8YMYGuCn2RR+FTww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 20, 2023 at 09:27:32PM +0800, Baoquan He wrote: > Since the kexec_core code building depends on CONFIG_MMU=y, we may > need to add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP. I made below > change, do you think it's OK? > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index 7500521b2b98..fe1500871648 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -548,6 +548,7 @@ config ARCH_SUPPORTS_KEXEC > > config ARCH_SUPPORTS_CRASH_DUMP > def_bool BROKEN_ON_SMP > + depends on MMU > > config ARCH_SUPPORTS_KEXEC_JUMP > def_bool y > I'm *not* familiar with crashdump or kexec machinery, let alone the current changes in there, so take the following with a cartload of salt, but... does sh crash dump support depend upon the code in question? From quick grep it looks like we only want it in machine_kexec(), so the conditionals used in the commit in question might be wrong...