From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE5BC3DA6E for ; Wed, 20 Dec 2023 06:37:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806156B008A; Wed, 20 Dec 2023 01:37:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B6B16B008C; Wed, 20 Dec 2023 01:37:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A4956B0092; Wed, 20 Dec 2023 01:37:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B6986B008A for ; Wed, 20 Dec 2023 01:37:53 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30EE51C0DDD for ; Wed, 20 Dec 2023 06:37:53 +0000 (UTC) X-FDA: 81586241226.18.586E01B Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf06.hostedemail.com (Postfix) with ESMTP id A95C518001F for ; Wed, 20 Dec 2023 06:37:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Pm0xg3gP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703054271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Jcb3NYVrGteIOFtz+g4gwWgj9dkl6RL6qjWdyvEGo7Y=; b=s4+ci1oDDkRvqWj/p+thjOqUvoHvfbyamhX556yCSnIowXcSpxCrlwssNvtyoqKbNOu0Hn boj4/pwkeKGg7frqDTeZB5QhG/83DLnVBWkBbZJQ4l9bg+MPjF9cxm1RjjBSv6ScsIGdBQ ZI+S5KyjAH3iXgFMsVJq81BbucZ23fM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Pm0xg3gP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703054271; a=rsa-sha256; cv=none; b=WyRUBAsLrDdAUR23Xc0wQRm6SK8D+Ym6NqRF0sV/S22AV16aDvUcystpP3j87dog4xDOzO O8BdE4ZWWuPBayQvyuirIXAkqrTE7oyH2KC46xrdZp9fwmvOJd3xzzWLpf2uAz3fpxe0HN 67IazmhfFrAfAlKy/oSCudHufNHTMZc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703054271; x=1734590271; h=date:from:to:cc:subject:message-id:mime-version; bh=bh5scw8pATeryugZTyoTL++cxokNIZfmT8f0Hy4mxjQ=; b=Pm0xg3gPADRTpdd7H5hjinzRXDcfNoYIrbRrBrzEmBA4pmhC80ZBQb+O zBTAojCEQe1eeFgN56bf2dr6RJS830MYLD2cCkrL33vRtsvfJUftkXnLI NgRAeYzgFRqvmgknZ2M8JBZ7uETIrjafoKzc4cx1zfe7c6J0WuBSTP2tx tS5FXfWB8d3aCYLVQOlnQbzysnHBgmuRsxXQaW7TFTCRawS8AWPGqrSX8 /pTJee8bRFtSrLkQO3l9LN3afsvuNj44ikzcdaax05zayaxH0sZFLHvP4 lZrn6WzTHKgpcl1wOyWjM2OEPHcZFtpnFXAUSFmpGp0xe5uHZ6rAJSgpm A==; X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="9149189" X-IronPort-AV: E=Sophos;i="6.04,290,1695711600"; d="scan'208";a="9149189" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 22:37:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="1023383638" X-IronPort-AV: E=Sophos;i="6.04,290,1695711600"; d="scan'208";a="1023383638" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 19 Dec 2023 22:37:47 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rFqDB-0006WR-01; Wed, 20 Dec 2023 06:37:45 +0000 Date: Wed, 20 Dec 2023 14:37:33 +0800 From: kernel test robot To: Justin Stitt Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Martin K. Petersen" , Kees Cook , Hannes Reinecke Subject: [linux-next:master 7125/9096] drivers/scsi/fcoe/fcoe_sysfs.c:283 store_ctlr_mode() warn: unsigned 'ctlr->mode' is never less than zero. Message-ID: <202312201409.y5nmYEx3-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: A95C518001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: p4zc1szpxst84q5wymr7csmirzi94ia1 X-HE-Tag: 1703054270-546392 X-HE-Meta: U2FsdGVkX1/6GHk+N+JlggaHgTmftH+b+f3Ta3AQ5idbEYMxSLWuBL91UY7H3GtrTFaAMQu+Z7TjHu94z9LioAkujZNAHJ4py9QM1AYYl9wBuT3gTTu+/HsVeKyP/ngpS1cN4JmIm2A4JvlGL+6VMycH/5dFU3lTjXYWAzNLKujP73YcFWXVEcDS4b1fPEPz/p3ArNnCEUNJixsfQ+36S9qGwxjU8yoFYie0Li8GUOfiHlSq2jc11LAapVOqmfFMNWwAgyxo/6NWwe49Zf/EBOsBGD2C52a44zgwdyf7JMPz9bw9VTUdlIg9tM1y3oJ150D6AFwEa4aOXtbLk/GOUYSA2j001uvfRhiTKJ8ifEWr7HKpGVddsCScgLuV1hjXBC3nkLOzImA4W5vnFPh9gxT5AUJ+Og6Zt8X5J5yhgUipGogmDS0p2vIQU2o4qmIryxN9rI8PyzjvxI1sIRDOTZ6yF44ivIUjGQIKHf14Pma0AS/pSd1LoHWOoYbEUtEWxTeNd8u+bssOSzAcSkComjkJ9sa5MF4LpwX7kMZq87QiSvQZBbf2OUcku7THw3laIYtJatdeBSdMlj9CM/D1V60p1B/8/dmskfNE8lFBTAIx16RYCfynYOtyMd6e16dQVarDXCGYNZEWsNQ/w8a7ilRxX+f6Q0kDtQzzk1IlRKnMnJh3iz9NrSbQguRKwmtZFgBi67hGLyUnXEI0wQrWudfj8DjC1kCAS/55BKUA0W55RD/8F4dRNLZ3Ap1y+RuqpovuIO8CE5hf04JyLE5iSsLkppejbbiVdUFqKm2ERVF+jqdBdVwBHERD4UuA/2hRfVHG0RBFbRPsrOT9VyAUzu4q2XmlRiBhLCM23DzVahjcJ9AbUJ3A7T55Q6wJytm9hr7lvpRP/Wh3ErDQtqTXoYv6hmtTcavq4fUt3h9lSOO8MvvdMOtOaACeD/SG1sFzi3WS7fe+cI1+2RDclTQ eoSj4zNv Laf2ey/GkYJmakH8C2XHNBcn4oHLbUjGiiLmLvehxiF4xQnvnH2B5Za5CBPrJgQA6T2N88FOkoRZZFzt7OIZgJEfD0POJ3ZhZRdjzLkFoOJDWb6PxKPDb4GF3wkh8uPIctLrLDuHp3r5sON4uXUO7uHzI/ChkNKv06QxvOS7jWIRC8vjNKZCL+PudDRrgq0Sm8HM10mHrwfhwUGKC13CTkM2Q8zNXr7GscGXgmxu1sjCf/R/JDQyNhuKiLnBKG7IV4IioVtLqNProGH/yMlAWyqSI9P85+GXPCjdAEOuje6TMsNOVxrDAUJ6DzFxyVSpN02W/kmp7bqVSNTIWW1jrvtfYS2sBZYH/mtXI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: aa4db8324c4d0e67aa4670356df4e9fae14b4d37 commit: edc22a7c86888d1f2442e359c3b33a861045e9cd [7125/9096] scsi: fcoe: Use sysfs_match_string() over fcoe_parse_mode() config: x86_64-randconfig-161-20231220 (https://download.01.org/0day-ci/archive/20231220/202312201409.y5nmYEx3-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312201409.y5nmYEx3-lkp@intel.com/ smatch warnings: drivers/scsi/fcoe/fcoe_sysfs.c:283 store_ctlr_mode() warn: unsigned 'ctlr->mode' is never less than zero. vim +283 drivers/scsi/fcoe/fcoe_sysfs.c 260 261 static ssize_t store_ctlr_mode(struct device *dev, 262 struct device_attribute *attr, 263 const char *buf, size_t count) 264 { 265 struct fcoe_ctlr_device *ctlr = dev_to_ctlr(dev); 266 267 if (count > FCOE_MAX_MODENAME_LEN) 268 return -EINVAL; 269 270 271 switch (ctlr->enabled) { 272 case FCOE_CTLR_ENABLED: 273 LIBFCOE_SYSFS_DBG(ctlr, "Cannot change mode when enabled.\n"); 274 return -EBUSY; 275 case FCOE_CTLR_DISABLED: 276 if (!ctlr->f->set_fcoe_ctlr_mode) { 277 LIBFCOE_SYSFS_DBG(ctlr, 278 "Mode change not supported by LLD.\n"); 279 return -ENOTSUPP; 280 } 281 282 ctlr->mode = sysfs_match_string(fip_conn_type_names, buf); > 283 if (ctlr->mode < 0 || ctlr->mode == FIP_CONN_TYPE_UNKNOWN) { 284 LIBFCOE_SYSFS_DBG(ctlr, "Unknown mode %s provided.\n", 285 buf); 286 return -EINVAL; 287 } 288 289 ctlr->f->set_fcoe_ctlr_mode(ctlr); 290 LIBFCOE_SYSFS_DBG(ctlr, "Mode changed to %s.\n", buf); 291 292 return count; 293 case FCOE_CTLR_UNUSED: 294 default: 295 LIBFCOE_SYSFS_DBG(ctlr, "Mode change not supported.\n"); 296 return -ENOTSUPP; 297 } 298 } 299 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki