From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DD3C3DA6E for ; Wed, 20 Dec 2023 17:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C38338D0003; Wed, 20 Dec 2023 12:35:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE7DD8D0002; Wed, 20 Dec 2023 12:35:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD6BC8D0003; Wed, 20 Dec 2023 12:35:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9E0008D0002 for ; Wed, 20 Dec 2023 12:35:50 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3E225120B32 for ; Wed, 20 Dec 2023 17:35:50 +0000 (UTC) X-FDA: 81587899260.25.B7218A0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 7EB3BC0009 for ; Wed, 20 Dec 2023 17:35:47 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=cVS+=H7=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=cVS+=H7=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703093747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x7HCvwLQlq6ekOpUZPYCwBsn+PZMWjQ0YClRcLaySz8=; b=HcYdNymzCAtdz1xpCMyJYFgCBY9yj/dMJgMytjHJa6zGMbcJMj7pOXdBt3qcBm4RcbHhvB hZ9sDz7XrN35aym8E+XdMm0nsMyT/1p55uPLCGaRvS1h5mrIFCw7Y5Ulx6c6L9chTbwUqw 5kw95JNWYlcE7JGKqqiH8NI+MJh90OQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703093747; a=rsa-sha256; cv=none; b=v+nj8kEwWvT47fabMIrqUSVHnuvZRirdug5KAfHo2oOwYa0HpMYYsi4wmtdx9ddqqaUwXr +8ZCXhtckXQ+l9R9IHcyscA4OIAkNBhpohY+LBpvquxdTCornaijZrvM1J5yP3/6K4x8Zr VApA3Zs7miVRQY1zp+B3ck30Yzgmxow= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=cVS+=H7=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=cVS+=H7=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D876DB8123A; Wed, 20 Dec 2023 17:35:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D875C433C7; Wed, 20 Dec 2023 17:35:44 +0000 (UTC) Date: Wed, 20 Dec 2023 12:36:44 -0500 From: Steven Rostedt To: Bixuan Cui Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, opensource.kernel@vivo.com Subject: Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru Message-ID: <20231220123644.2a28d162@gandalf.local.home> In-Reply-To: <20231220012123.2787-3-cuibixuan@vivo.com> References: <20231220012123.2787-1-cuibixuan@vivo.com> <20231220012123.2787-3-cuibixuan@vivo.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 5fw9srkdc3z6f81zsjz6ettugusmtw99 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7EB3BC0009 X-Rspam-User: X-HE-Tag: 1703093747-640654 X-HE-Meta: U2FsdGVkX19Qo1d4CU6Oi9FNZ0dmJPFkISsa3HndSYS5/h4FjBl7tZSgwJbIoIzaSHKTlQxodFRInbpc8adyjjlNxVZ3G4w5aVyV3fg3J1Me4qyTbhp0MI7qnhrc9TQi5zEdVP7cAcc2uVrcKkf3v8tdjMh4cW7kTfllNlDm/+VDW6wIodYZZgJO7u5jorutXRM4fRp6XFPYzPk7MUVzV9jChtIMFGWX+tNQzFk27mDBU/6+6oWYw76jl8LFG2S0gXygGPBxTETxU8H6F77P+/aGykQg+ppr6UeAh8l5Habx3Y6pgJLVxPNy9PAqZTjzn+CokJXRkm0iLdkEQ+ohh6llKjW0jgB89GF1hQoNUnG75zipDMrjAtoYB/BlBkEsLE5z1TS2I4FRPXLV4BlnKjHGsHObsIeXUCzGDvpCRtyv/ow+cKSuhskWuKsyr91DwY58bmdT+cO7SL50KK4KJ0sbBP6L7uJ/ne8DBhUDkCEETe/OqrjFvIxM09h50+VL1cQ5TsU8b5VRIf0B5L5wnZmYY+1DxyLkQ2Or3w80F//BZdt9TXRcfntYm9IwHRqIaK31aKmlyS7gFQ7ML+lhVO7MU7NcIqY03x39lyhyICuPgmOxkZue0udyPT6SQFRe4AvJS5n7amUu220OSlRwsywZ04021YEv5XvYcGIUcu/U+8/yO672ZsRg7l+kt0lUoskyUY2uwquTLBn0+9qPR7z4+Z6akpveeNJFG4ZPPd6tUQssgk3FkA6PDO/oEgzYpJgJ+Q0EW1ABxAJufNiGllnVMG9Y5SmRq35tyM0ffjgsp+u8hHv1Luy8uQepfrRND9NFVrpwK10h0dpzMTG4llAdpM2KpXsKVdTQmRqVYvBPm9jmSmJovddI7B4Fm3EsxatjpFgarx04fRXeGdvvGu+pGCJ5b4lf0Otqicm/lC3uP0Yx02JhVTgY7wxLq/7Bs8P7HKDFEEg7zB4J1Hq TAzsbn6e PEmW1bgQUenX679B0KPl6aXx3XwI3eY6GCCWCBGkYcOAJZhWvgFAHLbWjHE6Fvh/LyP05vwrdkV+FIw2EyV1aaO0SzwL5+vcCIDtobaqoLAGjdfydVzVagTJb3DcT9gsn+68xlNxs9Nexi7tec82VogRkx8c932tV6ug0F6jO4st3odMjS8CU+AMVgQhYxfDrzv1qb5GZ4WDJJtCFsoFAbW5h0URDw8iPwVZdZpcfRu2k+A6LKTZBU7rspE5mOp3+OnO2a0DAldap/3/nGyAX1Zrq8/1kC4V62o3WIFz81DBluzjJOyhxjVUPWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000286, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 19 Dec 2023 17:21:23 -0800 Bixuan Cui wrote: > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index b99cd28c9815..02868bdc5999 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -395,7 +395,24 @@ TRACE_EVENT(mm_vmscan_write_folio, > show_reclaim_flags(__entry->reclaim_flags)) > ); > > -TRACE_EVENT(mm_vmscan_lru_shrink_inactive, > +TRACE_EVENT(mm_vmscan_lru_shrink_inactive_start, > + > + TP_PROTO(int nid), > + > + TP_ARGS(nid), > + > + TP_STRUCT__entry( > + __field(int, nid) > + ), > + > + TP_fast_assign( > + __entry->nid = nid; > + ), > + > + TP_printk("nid=%d", __entry->nid) > +); > + > +TRACE_EVENT(mm_vmscan_lru_shrink_inactive_end, > > TP_PROTO(int nid, > unsigned long nr_scanned, unsigned long nr_reclaimed, > @@ -446,7 +463,24 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive, > show_reclaim_flags(__entry->reclaim_flags)) > ); > > -TRACE_EVENT(mm_vmscan_lru_shrink_active, > +TRACE_EVENT(mm_vmscan_lru_shrink_active_start, > + > + TP_PROTO(int nid), > + > + TP_ARGS(nid), > + > + TP_STRUCT__entry( > + __field(int, nid) > + ), > + > + TP_fast_assign( > + __entry->nid = nid; > + ), > + > + TP_printk("nid=%d", __entry->nid) > +); > + > +TRACE_EVENT(mm_vmscan_lru_shrink_active_end, > These two events are identical, please use DECLARE_EVENT_CLASS and DEFINE_EVENT macros: DECLARE_EVENT_CLASS(mm_vmscan_lru_shrink_start_template, TP_PROTO(int nid), TP_ARGS(nid), TP_STRUCT__entry( __field(int, nid) ), TP_fast_assign( __entry->nid = nid; ), TP_printk("nid=%d", __entry->nid) ); DEFINE_EVENT(mm_vmscan_lru_shrink_start_template, mm_vmscan_lru_shrink_inactive_start, TP_PROTO(int nid), TP_ARGS(nid) ); DEFINE_EVENT(mm_vmscan_lru_shrink_start_template, mm_vmscan_lru_shrink_active_end, TP_PROTO(int nid), TP_ARGS(nid) ); This saves a bit of memory footprint when doing so. -- Steve