From: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>, <steve.kang@unisoc.com>
Subject: [RFC PATCH 1/1] mm: mark folio accessed in minor fault
Date: Wed, 20 Dec 2023 18:29:48 +0800 [thread overview]
Message-ID: <20231220102948.1963798-1-zhaoyang.huang@unisoc.com> (raw)
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
Inactive mapped folio will be promoted to active only when it is
scanned in shrink_inactive_list, while the vfs folio will do this
immidiatly when it is accessed. These will introduce two affections:
1. NR_ACTIVE_FILE is not accurate as expected.
2. Low reclaiming efficiency caused by dummy nactive folio which should
be kept as earlier as shrink_active_list.
I would like to suggest mark the folio be accessed in minor fault to
solve this situation.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
mm/filemap.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/filemap.c b/mm/filemap.c
index f0a15ce1bd1b..b1ee6ce716c2 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -3273,6 +3273,11 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
*/
folio = filemap_get_folio(mapping, index);
if (likely(!IS_ERR(folio))) {
+ /*
+ * try to promote inactive folio here when it is accessed
+ * as minor fault
+ */
+ folio_mark_accessed(folio);
/*
* We found the page, so try async readahead before waiting for
* the lock.
--
2.25.1
next reply other threads:[~2023-12-20 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:29 zhaoyang.huang [this message]
2023-12-20 14:14 ` Matthew Wilcox
2023-12-21 1:58 ` Zhaoyang Huang
2023-12-21 4:09 ` Matthew Wilcox
2023-12-21 4:53 ` Yu Zhao
2023-12-21 6:28 ` Zhaoyang Huang
2023-12-21 6:32 ` Yu Zhao
2023-12-22 5:53 ` Zhaoyang Huang
2023-12-22 6:14 ` Yu Zhao
2023-12-22 6:28 ` reply: " 黄朝阳 (Zhaoyang Huang)
2023-12-22 6:45 ` Yu Zhao
2023-12-22 8:41 ` Zhaoyang Huang
2023-12-22 9:41 ` reply: " 黄朝阳 (Zhaoyang Huang)
2023-12-23 2:41 ` Yu Zhao
2024-01-02 5:36 ` Zhaoyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220102948.1963798-1-zhaoyang.huang@unisoc.com \
--to=zhaoyang.huang@unisoc.com \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steve.kang@unisoc.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox