From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD53C41535 for ; Wed, 20 Dec 2023 00:37:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80A396B0072; Tue, 19 Dec 2023 19:37:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 793A86B0078; Tue, 19 Dec 2023 19:37:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6817A6B007D; Tue, 19 Dec 2023 19:37:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 552976B0072 for ; Tue, 19 Dec 2023 19:37:18 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1C7DDC0417 for ; Wed, 20 Dec 2023 00:37:18 +0000 (UTC) X-FDA: 81585332556.27.E2FF98D Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf25.hostedemail.com (Postfix) with ESMTP id 35F1DA0007 for ; Wed, 20 Dec 2023 00:37:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qp+CTAGi; spf=pass (imf25.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703032636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHj95+SuuyuWE1aSF6Rh6UTwRm9YyyNdHIj34uMPRo8=; b=7PVWDacsZkcagMtgEZUPK3F5DJIlH1Lw1r7TyZaNtxHK1zzWe78ropzRmJhnVUY22tb5vf FkB5BxQx4SfFIykw3jTvnS50kGd9h1LgJ0noXFwROfYdwmZRdpXX4b/6Zl7Vl8+V0r8GdE Z68xxVibTFU3tLoQTol00BSrIZEn11g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703032636; a=rsa-sha256; cv=none; b=LQmzLdbctxjHlhKGOoc/spDkJnqkOnGc+W0CaIGR3hzamm3rOXrT/7/iqc2sm4/2lbV9hJ Xs2e9jw3TrfsWXgwpIpuDEFCCHuNFhqL9xqzXpijAto7eCNA/AnAGSMv/Un9YaxQHiNSUE S5fY6Wa8nUE5nX4pZk79Fae4dcuBjKA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qp+CTAGi; spf=pass (imf25.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 19 Dec 2023 19:37:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703032633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iHj95+SuuyuWE1aSF6Rh6UTwRm9YyyNdHIj34uMPRo8=; b=qp+CTAGiISYK5OsbFlrDsk0N5xl83cjPhbMYmtT2vDnenKXaqxLkePTl5h03mktfWBfvuP rfMH1mZLDvyVJHjM+56nLh741/Uty9ZOIEpBniIinPBJnKx4rmVZyMwPRbY6WWF2EqF2X8 WAm1fqiuSAhO8ocVjhNby5s66oWfYyI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 15/50] kernel/numa.c: Move logging out of numa.h Message-ID: <20231220003709.vayf4rcip7c3hjk7@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-5-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 35F1DA0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jbfhecc6m3waqo1w5u967fitmsmzkfrx X-HE-Tag: 1703032635-467395 X-HE-Meta: U2FsdGVkX1+EIZItTVTKpIJ4uZVQEsGL6sqR4BMyM+/UT0F1QJfpFwzuSn9aiWdEqMUigX3D2+s9RCXymnbR4Rk4ScX4PMp0JaJf26a9xvw3HpZzNDq0SJLizN8+jpWM8E4/Gx0hX4FR2R/+wsHKCN2qw4uGqxYrSML42OsHx0klrqS7l0TcSR6HZ34gJCfzCNERI5stKHBV6zTFHLqbFsLtgiRFDTrqXdNFo8xuxmNO9ye/YERw3qIZcilfAPOI6JLl2PgttC+hGWYIjcuuXqSbKlfY0zuIdRMiFhGJIaHZTaUqF5s8gP4E+KHR9kvit1nEJ6D8mhFotdzWQDjCOjv5XPRhywpO5L+QPhcYk8nBf0unPuL4y/utfzjk6cU/zgBWES+aFRT/cKcUvrKrWYWrT0uZu/TVbEmUnZuZwrzikj3yfbYVYNynMQyVfB7lS71UN8ZE+RT0p9mwgtNF0qiKxNovUXHqAZZa2tAs8yh+DvHQtYz0YafaYbA6zT//xKdibQmQlT7seQmjezSYGOhb6zXr2Oti8et3Ok2Z4Vb4Ln3EqH4qjphapPGiWoaivKUDMTn01AyFCpt7SNi8hBZDlru4mX7bqZZv4B/XyEStBUoO2qW/tQY0POw4LzsNn9/MtZGms3bhkVCmXyBy1mNup3DvuH/8CyLKL+HZPwU6M10CE0Bi5lydNs2fNpiYHzZQKGdVYX1p243gRieRITiNLfJuYSuIYHB1Z7Kr6AsODLmw/Pxt3pV1xWC8M32/9IZcm9QbL56FuI/Ei15JQWXZ3ls0wta6v3Xi2urM54UuZUTD5VxvO01Jme6+ow+wQPKQ0wYq2KJM/HgTb2DyIPK1RULExi+8FKZRI2hicBF2NeUC0GZ0/9syEMyMtFryRM2xAoCt9SV9W3IAYqixN2B4QMDUEeqb6XcOi/guu8mogSADbRDfq+kd5sGRgLHB8vQlCUKTCwHQvViMupv BMb4f+C3 uqVystjqOAyoacbs70680+kLWIr1LYr7K/9/cdt8tilGaBthM37BSnX+QYkRkJoORjvws0V/bpDfQlgo6f8YgvjVGW/iIR7VSAkQ43GByHuUgSwSYfMv/SruVlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 19, 2023 at 10:52:33PM +0000, Matthew Wilcox wrote: > On Fri, Dec 15, 2023 at 10:26:14PM -0500, Kent Overstreet wrote: > > diff --git a/kernel/numa.c b/kernel/numa.c > > new file mode 100644 > > index 000000000000..c24c72f45989 > > --- /dev/null > > +++ b/kernel/numa.c > > Should this be a new file or would these functions fit better in, eg, > mempolicy.c which is already built only if CONFIG_NUMA? that does look like a bit of a disorganized dumping ground though, I wonder if anyone would want to start mm/numa/ and do a bit of organizing?