From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226E6C46CCD for ; Tue, 19 Dec 2023 23:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 584278D0003; Tue, 19 Dec 2023 18:18:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 534198D0002; Tue, 19 Dec 2023 18:18:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D5748D0003; Tue, 19 Dec 2023 18:18:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 274CE8D0002 for ; Tue, 19 Dec 2023 18:18:22 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF87714038F for ; Tue, 19 Dec 2023 23:18:21 +0000 (UTC) X-FDA: 81585133602.21.E04C3D8 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 4A95BA001A for ; Tue, 19 Dec 2023 23:18:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kZzjTNS2; spf=pass (imf25.hostedemail.com: domain of haokexin@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=haokexin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703027900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=RQc4Yh7vXiJk6+PEfMHFKBELekTdUIW6FrBDqho79kE=; b=qvLaDFpQc4TwdmIQsG8IhMCiA1QXTj8G0rD4Mw9TErBnLS2hUdwrezaH1hlGEIh6h56ylX 1kB0TEPe15bz5s2VygS5vFUMbUtDshEeiLSwYlFwwnPdOuhrutQVkEmCw4TdtJPulfbahC 256qmexAF5whVT/5LtGjz2pdLMAzpcM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703027900; a=rsa-sha256; cv=none; b=wQEOv778uMPIOwB0jB0NxpDVcRGUNhctWDT+MgCO95fIsMwCkd4CHGZxxUVSATW6AbSVR2 yH4sxvlxKD/UDv9mC57waBCr6JMQCcOzsp6ZCQc57QCIb4fU1+ElLcFcJPatzngc3SFjnw CZIWZ7C09S6jwuAMzQgQxqueHkkW7Cg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kZzjTNS2; spf=pass (imf25.hostedemail.com: domain of haokexin@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=haokexin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-425952708afso1652611cf.0 for ; Tue, 19 Dec 2023 15:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703027899; x=1703632699; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RQc4Yh7vXiJk6+PEfMHFKBELekTdUIW6FrBDqho79kE=; b=kZzjTNS27fWDrJCH/2S3fyavfAZRH4JlH/r3vNezwU+lAvw42QhH4PvAFyS5qSpfHZ Xvrrybg9EFHJ9dDzpOD8XzyPtTolx09Cb3lL2U1zbAAx+9RDNsx4an9Vs+44TipeKc1Y i7fqhVafGIegxsKmKvuzCFec+dhhd8UjPpMQourLOJ7QWLsMene9hdcC1u7Du23z8Ceb 5BFVWnOQhMuDNq1dc9cWjHjeeq5Y1OGsRTWadD3HeJNlLXNavZv0unQFsKq6m+NgOeas QEKOQqkSU188MNB+31uRfrjv1QZLs9pWB44W33Sdeou3kVyIS5WKaRFYAlW1WUCJD+e1 8BPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703027899; x=1703632699; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RQc4Yh7vXiJk6+PEfMHFKBELekTdUIW6FrBDqho79kE=; b=B9BARzaKeKnWczd8y8AwgTPkDio9ztspilei2Cb0Nhl5Is2upzl45bwQkZ1Vc84zgg UinSOT8e2k3vOxfDWqJzNZYqu46gJyxpO2EjnfmQKHQ/I2AplAmTdL2fShAvPdQnjTuv HzWrLVSqpTCosw9Gf24QOBmdJlkgcNckidYi/H61n6EDquzllW/zxp7I6DIXqCC0FDX2 Fijt6Zd0KSntPaZ/zz0Tg4a92NT7oyfKyR4f6VuraSwvNF0R9vkHZocZ7W8LdDpmTAwY R6B8u/fM+m4NIMyAhhQqceQZ03iFWGSETkOXPtikxDiMdfEwu+EpMngt0r1x0gcL58st 8T5A== X-Gm-Message-State: AOJu0YwnRiXphdRAKk+Z2N66UFP8+o09IhYkjKDuCBdlSh5ru+gCsJ77 6DmXdsIHqIOjsQHoHwQYFhr0eOje/Ug= X-Google-Smtp-Source: AGHT+IHyRBCciJIcPmhluBdzH/vAxdfqRXOWnW3p42H9rX8o1We6kJcaAR0bUhpjSeIVUompV8RZdw== X-Received: by 2002:ac8:5a8b:0:b0:423:8f37:fb08 with SMTP id c11-20020ac85a8b000000b004238f37fb08mr2615822qtc.32.1703027899316; Tue, 19 Dec 2023 15:18:19 -0800 (PST) Received: from pek-lpggp6.wrs.com (unknown-105-121.windriver.com. [147.11.105.121]) by smtp.gmail.com with ESMTPSA id bq12-20020a05622a1c0c00b00419732075b4sm5980634qtb.84.2023.12.19.15.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 15:18:18 -0800 (PST) From: Kevin Hao To: Andrew Morton Cc: linux-mm@kvack.org, "Rafael J. Wysocki" , Pavel Machek Subject: [PATCH v2] mm/khugepaged: Remove redundant try_to_freeze() Date: Wed, 20 Dec 2023 07:17:53 +0800 Message-Id: <20231219231753.683171-1-haokexin@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: jb674oo481mw1b8qsf146dcusqhksztx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4A95BA001A X-Rspam-User: X-HE-Tag: 1703027900-581916 X-HE-Meta: U2FsdGVkX192GiPU7kBtSAl69WnkxfJTXgLn6NBfTFZ8wZHT+pAv85g/9rlbv0QOHT4rTXQy21KIPtk9AP8gwjU6ZEIbjeoS1h89UKCJu7EAGLYGproUxnZHE0B/U9+IO3oQBUjE2ZNwdgCq8nts5m1wheqqPc+SkV4uuiyHgfW5YYPVzHhUsbalawO3/oKh+ZvnkVzcq6olPBmA6RjhUtuKvlO3h0q1gT5R9qa3rWSlagdbZhGimu1Af+X/WiaasuvJybk9vPQvf0GC8C6nFsLvyxs17oykH5h+siNK4lyESio734I/WwZ2mGYOFjGLf5svamqujlXvOpydcqKXXMZQa2mDfEtbHWbH4bfv6NlpLglsiJwvLapNlRZK6mjRasQbPXOpeuEs0rbk80KaQaBTpnkW404bzdsLpXn4sM2ZV/HyPONzqqUQnz6g2rt//1znComT4SAcWQWgEEtN0DlBMML2HsEzOHLN3tiTCUYzZGU5yd5BIufXy5eNjX/7azwXBW2ro2HrJi0CkYitDxfx6CNs8zdF7+WPm8nDakhKryvxRNKXtN69jCKi//Rge13ZB8q7UZ/mEJ7Iu5TwEPNM8NciMG/nbLYWhZxkTMm4YMvkcsH5g/HU/Bqk2Pt+V0Bzg39KhlJD7h7Gflm3p8GO3gMEMMwjaIv8VyC4GEi55IT4WffxN8fyZtli/r8WQ7Rb2XqmW5foxLPDqkicIiL8Fgh6QwGjvM+FhVBJqZlRcPF7V5y7oxHx63zWxgep+y0AeZ8/3PGXwVzNzjz7DZUc6x3uJnKAMfTj1yBMiwtoduSViB1xekRxjRPxoVym17Vt0fkqPvkmrtUNpN9XwPp6bTvP+3Pqgb2PbZZJegXBTXbPGDfhn3lNlPSPVXY3oLuAlZ2aRl2WmKd9xrONH8QFDrlFCkA4eCKoRMZYJQbOjfQ/O3Hmp/B4arE5dxLJPF4E/w/7q1zvE5WLg7d PuOZ/7yp R5RvjHLIkaZL9pugZc9tQWsdxt4q71fdWxPIi/KFLVjbBV9wdYO4g3xt8y5Iv+wgLRgxhjzDu1SZoZPoeErc1EmGbd+rBfsCn1EFzmczQsyFlc+Zge0tlkWBtJNOqdHeUrUlEv0A1v6ut79hzD0BORWC0epUQZKVNYSZppEqW0+sOmJGfn5dC+uXV8JX3aXJreQt6XFY7JiqUzkUSrFpYFv4wIY439IDCnQ9XKHr8JKDBhsV/aJO3zrV0AMSZO0zaOmOIdqBGG2fHmxfljkEvlp2/RHNvtSPJRRtcpwMOT3Ny5V+P3S6R/+ihKKA1Zqc4RQQ5Y62rbK6AdbrP8iwYmy3yspcrS0tz4IekZXreM0x+bZcTWGPcSwUCD/Y2hFeKyRwOwHXjawQ0KDb9FpEgeNo+TO+vRMaupRoX3EL44MwHL2scOoGs33rHBtk+VJ30Y0c633nfxLsIuF225rsDJHmvoPEnhRWEigJjIizTjOWeI4c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A freezable kernel thread can enter frozen state during freezing by either calling try_to_freeze() or using wait_event_freezable() and its variants. However, there is no need to use both methods simultaneously. The freezable wait variants have been used in khugepaged_wait_work() and khugepaged_alloc_sleep(), so remove this redundant try_to_freeze(). Signed-off-by: Kevin Hao --- v2: Adjust the patch subject to make it look more unique. mm/khugepaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 5bf9a4d0e47e..13c6eadbeda3 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2500,7 +2500,7 @@ static void khugepaged_do_scan(struct collapse_control *cc) while (true) { cond_resched(); - if (unlikely(kthread_should_stop() || try_to_freeze())) + if (unlikely(kthread_should_stop())) break; spin_lock(&khugepaged_mm_lock); -- 2.39.2