From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB9BC41535 for ; Tue, 19 Dec 2023 21:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A38E6B0071; Tue, 19 Dec 2023 16:03:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 453DF6B0072; Tue, 19 Dec 2023 16:03:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 342186B0074; Tue, 19 Dec 2023 16:03:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 253AB6B0071 for ; Tue, 19 Dec 2023 16:03:02 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2067A042C for ; Tue, 19 Dec 2023 21:03:01 +0000 (UTC) X-FDA: 81584792562.04.04DA5DB Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf17.hostedemail.com (Postfix) with ESMTP id EAD9640014 for ; Tue, 19 Dec 2023 21:02:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JFwmCwdB; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703019780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qsj0lc16eNSjypOaBN+kiTN4/ImC8Sqq9/KbAa5A9Yg=; b=YCFiWHuMsRORBsBcsAD0fDREvo8bH1J8c5b5vbMmRKIq4dW4em1KeAzhoprBc5lo06Gz0x 8aYcRginwEoB1hrCqXuHKbbHdjRorsOeb+i9oyT74swTF2ZGeI7M631MmXnGWf/4/8kLX5 ncjZPyiN9Q9kl3gaGFUN+17yDuUZzYs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JFwmCwdB; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703019780; a=rsa-sha256; cv=none; b=X6xvRdc6tbvOwqaXcH63SefJb0JrpiYc9g3yi7StYDdwKZ0jwOm67WX3P17UqFSspLfszA PsCzTbf1rFM3RO58ugadtuP0cihw/EN7xYwpuD1b6/IshIHL/m3vefEo6+t2YwPjerMRDS FtXb18EJrWAwh8227trkhU+BhiaFE+Y= Date: Tue, 19 Dec 2023 16:02:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703019777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qsj0lc16eNSjypOaBN+kiTN4/ImC8Sqq9/KbAa5A9Yg=; b=JFwmCwdBloOFVe4lIBYNnTgC2AMZG71MPaUzExbNJzqvrsWsGYIUxGXAkzYcDzsw96EgZg MbdQdodF2adLe9nMCNIlobqZHGc7bMzrki23ghmGsP8M0gJ1qnPSolpHBOEtDzp5bJ7MZT yyK1rTnD+M1lgIQHh7wWIKRg+QpkeFk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Nathan Chancellor Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 15/50] kernel/numa.c: Move logging out of numa.h Message-ID: <20231219210253.btvil5tychx6b6kx@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-5-kent.overstreet@linux.dev> <20231219163644.GA345795@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219163644.GA345795@dev-arch.thelio-3990X> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: EAD9640014 X-Rspam-User: X-Stat-Signature: u6jcommeruhset3h1y9rzts31tchay5n X-Rspamd-Server: rspam01 X-HE-Tag: 1703019779-287427 X-HE-Meta: U2FsdGVkX1/iaEquoDYlpT4cQdv0r5U4cFYzKBHXiovqczAw8CWO9wSnXkYqml5tVl7UV9pv+rBucypKGCUMRGupO9JnIV003RsxW1QUd46i7q/kzyBGWPGULE9P5BxHC8eA69s2BvXui/GcdFzNV9kXO+UFi1n8w0ANKIddBEH/Wm7bVrm+o5wbd47Y3Vg7i1sAxXke2pPaEuGL7CgGyjcP3a1p2lu32bCIfqvnetY3P+mU6PK53FuWwPCp78sfFp4cJGgmVa9ssAVAwwLHH02xmAQ2+h8TY4yyphbtwSdRBf8QwA8SMRgsCIoAtIesABaj2kNTrJZ6mKpUzJ+6741TwgvaMYSdcjHnlc4SGGAM1wnrpuFNEVlQmDJ3fUUkstJ1C7mqi6vED58YeNge0aFDt8i2wq/Y3j1vgYGBEOZgLYJcVO+ZZXbYML1CL0DGkYXbQdzTub0HF67RR9BAW1pDaCSOSktbl3f6pGHX1S6sUS/HCCC5srP51NxF63SJyqmLDYdjQ+1wB+BdIGu+GU4YBSjBrcc3rFq5CjCZ6SQAfP4sEMAL9IY/hgJvKjV3vRMVDdbK7Y/gFKihoO5f3ABt30Ft9GdsDJfU5iFkXEaedwdenhd9i970JF6nTBH++tC8KYT30cl/t+9QLYWlN1aakK5h6pqVgf15Cq1SLe+GKv5IOONO522zZ9NR1q3r1a4SbLrNihUMbn449quYbAHnAVIbtKktV/Y+qWrQ/UZz0csJz5nTsHcW7W2JMD/4S/hQPVkFj2e5DmTb7KBq2z22Wqa0lbPlGqLllMxh2C2xwoBqX9rYcMKYYIBTPa/pG9Wg+HtK358yPv+gmDibZKfx7Jx5KvRX4zN7NBdwiOZXI40hY8FJAa4WKplgvOMcXgniR6/LWY4fB71ux1L6gX5YMacrBDO84/1nBkJRi946oD2quhikwsc00EckTQE0oEGpSi6OCxoebdWFRHM knk44B99 fuGBIzFwd8ynybrbA22uDpe/Vqbw4HFmz2IkZDAzHfy2nBQbI3zNdRItruuV1nH3my8hKUYB5WV1zRyctNZBlE+B/Z10mkWUPaDBEXhW1Kfe+FQqMCNypr3v/ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 19, 2023 at 09:36:44AM -0700, Nathan Chancellor wrote: > On Fri, Dec 15, 2023 at 10:26:14PM -0500, Kent Overstreet wrote: > These need EXPORT_SYMBOL_GPL() now like the architecture specific > implementations because they are no longer inlined. My arm64 builds fail > with: > > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/acpi/nfit/nfit.ko] undefined! > ERROR: modpost: "phys_to_target_node" [drivers/acpi/nfit/nfit.ko] undefined! > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/virtio/virtio_mem.ko] undefined! > ERROR: modpost: "phys_to_target_node" [drivers/dax/dax_cxl.ko] undefined! > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/dax/dax_cxl.ko] undefined! > ERROR: modpost: "phys_to_target_node" [drivers/cxl/cxl_acpi.ko] undefined! > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] undefined! > ERROR: modpost: "phys_to_target_node" [drivers/cxl/cxl_pmem.ko] undefined! > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/hv/hv_balloon.ko] undefined! Applied the following: commit 7ae175e405b44b9897c04bbf177e3e08ab25710a Author: Kent Overstreet Date: Tue Dec 19 16:02:26 2023 -0500 fixup! kernel/numa.c: Move logging out of numa.h diff --git a/kernel/numa.c b/kernel/numa.c index c24c72f45989..67ca6b8585c0 100644 --- a/kernel/numa.c +++ b/kernel/numa.c @@ -12,6 +12,7 @@ int memory_add_physaddr_to_nid(u64 start) start); return 0; } +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); #endif #ifndef phys_to_target_node @@ -21,4 +22,5 @@ int phys_to_target_node(u64 start) start); return 0; } +EXPORT_SYMBOL_GPL(phys_to_target_node); #endif