From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kmo@daterainc.com>,
Kent Overstreet <kent.overstreet@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [linux-next:master 8475/9096] fs/bcachefs/btree_update_interior.c:158: warning: Function parameter or struct member 'nr' not described in 'bch2_btree_node_format_fits'
Date: Tue, 19 Dec 2023 18:46:48 +0800 [thread overview]
Message-ID: <202312191829.ZkroAQDV-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: aa4db8324c4d0e67aa4670356df4e9fae14b4d37
commit: a857ec99c72bfd31275300bdda28ef499a75a182 [8475/9096] bcachefs: btree_node_u64s_with_format() takes nr keys
config: i386-randconfig-061-20231219 (https://download.01.org/0day-ci/archive/20231219/202312191829.ZkroAQDV-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231219/202312191829.ZkroAQDV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312191829.ZkroAQDV-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/bcachefs/btree_update_interior.c:158: warning: Function parameter or struct member 'nr' not described in 'bch2_btree_node_format_fits'
vim +158 fs/bcachefs/btree_update_interior.c
1c6fdbd8f2465d Kent Overstreet 2017-03-16 143
1c6fdbd8f2465d Kent Overstreet 2017-03-16 144 /**
7cb0e6992e5c56 Colin Ian King 2023-09-12 145 * bch2_btree_node_format_fits - check if we could rewrite node with a new format
1c6fdbd8f2465d Kent Overstreet 2017-03-16 146 *
96dea3d599dbc3 Kent Overstreet 2023-09-12 147 * @c: filesystem handle
96dea3d599dbc3 Kent Overstreet 2023-09-12 148 * @b: btree node to rewrite
96dea3d599dbc3 Kent Overstreet 2023-09-12 149 * @new_f: bkey format to translate keys to
96dea3d599dbc3 Kent Overstreet 2023-09-12 150 *
96dea3d599dbc3 Kent Overstreet 2023-09-12 151 * Returns: true if all re-packed keys will be able to fit in a new node.
96dea3d599dbc3 Kent Overstreet 2023-09-12 152 *
96dea3d599dbc3 Kent Overstreet 2023-09-12 153 * Assumes all keys will successfully pack with the new format.
1c6fdbd8f2465d Kent Overstreet 2017-03-16 154 */
a857ec99c72bfd Kent Overstreet 2023-12-17 155 static bool bch2_btree_node_format_fits(struct bch_fs *c, struct btree *b,
a857ec99c72bfd Kent Overstreet 2023-12-17 156 struct btree_nr_keys nr,
1c6fdbd8f2465d Kent Overstreet 2017-03-16 157 struct bkey_format *new_f)
1c6fdbd8f2465d Kent Overstreet 2017-03-16 @158 {
a857ec99c72bfd Kent Overstreet 2023-12-17 159 size_t u64s = btree_node_u64s_with_format(nr, &b->format, new_f);
1c6fdbd8f2465d Kent Overstreet 2017-03-16 160
1c6fdbd8f2465d Kent Overstreet 2017-03-16 161 return __vstruct_bytes(struct btree_node, u64s) < btree_bytes(c);
1c6fdbd8f2465d Kent Overstreet 2017-03-16 162 }
1c6fdbd8f2465d Kent Overstreet 2017-03-16 163
:::::: The code at line 158 was first introduced by commit
:::::: 1c6fdbd8f2465ddfb73a01ec620cbf3d14044e1a bcachefs: Initial commit
:::::: TO: Kent Overstreet <kent.overstreet@gmail.com>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-19 10:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312191829.ZkroAQDV-lkp@intel.com \
--to=lkp@intel.com \
--cc=kent.overstreet@linux.dev \
--cc=kmo@daterainc.com \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox