From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 579BCC46CA2 for ; Tue, 19 Dec 2023 17:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B83246B007B; Tue, 19 Dec 2023 12:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B33B26B0080; Tue, 19 Dec 2023 12:33:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D3466B0081; Tue, 19 Dec 2023 12:33:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8F7F66B007B for ; Tue, 19 Dec 2023 12:33:34 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5795DA28ED for ; Tue, 19 Dec 2023 17:33:34 +0000 (UTC) X-FDA: 81584264748.05.97AC8DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id D3B521C0006 for ; Tue, 19 Dec 2023 17:33:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JJtCW6a8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5IB12f7P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JJtCW6a8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5IB12f7P; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703007212; a=rsa-sha256; cv=none; b=rO6XfBxtRJ3Wn+n+wWpDH6uRAx7vjTOafNKcqeGv3dmpwEBBA48cxsiwZty0iPiQDIS2H+ VZxSAlwvBTsvdmRzwA7KxZd/D1nE9BAkzWuKmiu6onkb3ZPXtCVV6IqMkzZqJoyYg1c0mD Es+HEMizMrZK5moy8lLA4bbNCQvAomQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JJtCW6a8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5IB12f7P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JJtCW6a8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5IB12f7P; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703007212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3dL7h8ceV7aXiO27Scimg+YoS9afC6qEOpXAa9fm794=; b=I9lTEaUlbV7K3VePOh69JaW+c1Fpbmtuoib9mPcJfmdlxU5o46htUrELmluuTVxg/9JE63 sf+JeKQg46ZVjRSEbe6jsr14Amuq2LEeQhC3qydKZy5kR2s2t3gCGXG87ZSlDL1MDPQqUl Rlca9tZBJtkkdsWgoAQmaOd4v1X4kWQ= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C509921E99; Tue, 19 Dec 2023 17:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703007209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dL7h8ceV7aXiO27Scimg+YoS9afC6qEOpXAa9fm794=; b=JJtCW6a8tG0oX5QaOWF3s38dZD9xtqLQjTHPXsicLVMtYhK9LFoSINWPxWdM7Ri4OCgTtL kdomvY9IuAnrDmOOzP5tj+Eio/HKEwnHF2LAFVdpFVxj2U2mlkmFaN/4W/pPMz1+pq/q+K h7ZFM/eLFSz9pMglmpOVBTvkqRdelvk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703007209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dL7h8ceV7aXiO27Scimg+YoS9afC6qEOpXAa9fm794=; b=5IB12f7Pqb/iD32Pjj++IGNtIH3KhdJ/RDFA8nNOnZpPJmZtJck+fn+fIAl5xsvxE67JcC VRxiEfIISuBoajBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703007209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dL7h8ceV7aXiO27Scimg+YoS9afC6qEOpXAa9fm794=; b=JJtCW6a8tG0oX5QaOWF3s38dZD9xtqLQjTHPXsicLVMtYhK9LFoSINWPxWdM7Ri4OCgTtL kdomvY9IuAnrDmOOzP5tj+Eio/HKEwnHF2LAFVdpFVxj2U2mlkmFaN/4W/pPMz1+pq/q+K h7ZFM/eLFSz9pMglmpOVBTvkqRdelvk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703007209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dL7h8ceV7aXiO27Scimg+YoS9afC6qEOpXAa9fm794=; b=5IB12f7Pqb/iD32Pjj++IGNtIH3KhdJ/RDFA8nNOnZpPJmZtJck+fn+fIAl5xsvxE67JcC VRxiEfIISuBoajBw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id B46CC13B9B; Tue, 19 Dec 2023 17:33:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id L9pfK+nTgWXpIAAAn2gu4w (envelope-from ); Tue, 19 Dec 2023 17:33:29 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 64E84A07E0; Tue, 19 Dec 2023 18:33:29 +0100 (CET) Date: Tue, 19 Dec 2023 18:33:29 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/17] writeback: fix done_index when hitting the wbc->nr_to_write Message-ID: <20231219173329.wp6v4y5637wavnba@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-2-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D3B521C0006 X-Stat-Signature: 1mmsmpnd7qigsau8z13pbb518wijqd6q X-Rspam-User: X-HE-Tag: 1703007211-694722 X-HE-Meta: U2FsdGVkX19iBaohX+iCfgg2f0TrGHfbq723caNRJ62vsjdeSXLMiF3hTpxDTp5KLSQp4sojYPKQvIZTncIpButgRKfBKe96G1hK6tQgzJSCKsNsu9tuEy++XTCHzJeSmyeSqZZ7Hf+BKhLc5i4WvZipusEfTe9wqdIgWy5wqcINj78Bg0ydYchkEqIsAV8W0/IGC3kEcquvtWu867FH+bdWahX1CUNoteeE6/m4bW52XohDksKWTZiIxHcSuMMFmKD3hciI+c1eqOkerVTzMjlfP+jKydXQOW8WkKyF8Ax0eli6uGtFSycS3wTb0nBkGrt/gN0U6aD2dMNS2KLM4oi9LBvyUfnTtlJ6WVpLNYgwFnU+lgESSphMwNOhKDadi95olfU4Ddw+M3r6L8FmL8cizTpLSCKaQRDmi+BpEmts3FF1Zdr+CNXgGnkaVpM1+EQY50ago6e/P9jWwBDIg2Tht3snP4MKQxMj9vK77DkxWxvDW/ivfCKOdM4G0RZCaX1yZrkuDCmUeMaN1xZFu9YSYD1z0DXE2oMNuAZfUk1l9URGalrCkpuLSjh5IU21h0MadPnJBYogTMS1YGq5CIO6ePJXm8gA4AuDyaH2yHQt0KAn/2HVF+egc2q8QHDeCYDT1KJ1F6j8mlmMfzSNZzgzTLbgitaEvfWy0HQJxO0IJmKDSnqUw6+QmiZYvyHo41+oxA0THiEALRNxnrEf0edMXilIMHw6e0aYBYOIOAIwWymyomeicXZNXRe/xfBVTGj6khuUNnHp98VASqj3zBxZ/NeJec8JxSrsyYM1vsbpzOVjso6ls2RKXiKD/eQSSw2KR+dX6K7Yb06lKOM+fJPmoT7fIjYZuEr+SV9y+8e8CWBRqALl3CLDBvTo0RV8SfHQuM7pqfbKATPPB9d3GsEEcCRrkCfMnLga1cgczHj1r082xQP3oR2GVNrvZuj0rOBEk5/AfrFwSZuL7jT hWFN4Prc X5+DanYfrO7pyI+1GKjjktwjyicJP5BlW5IE1XAaiERLA1wqbiBY1yiuBjhcFmF0FvPqzQdRtDBJ3lwJKk70goxMz/di6KqjQ4+BqAQlGY/8dQeari29r5j/ckkjqFEi+O2idEzjUC9a/b0mREqWVwKtcK7uLGpxWg37GKRg3WM0VRr93hEwuuf9F8wdIm/7jHjieoykLf+A5wbmdDFykYZC1+WTs3vCNYdLh3xl20CV66h88ZMCcP6JlbtgYxNRClrfta5lATcBTzwc/N3jKAqLLymV6NUcEcjgHJMqo6mgb4cM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 18-12-23 16:35:37, Christoph Hellwig wrote: > When write_cache_pages finishes writing out a folio, it fails to update > done_inde to account for the number of pages in the folio just written. ^^^ done_index > That means when range_cyclic writeback is restarted, it will be > restarted at this folio instead of after it as it should. Fix that > by updating done_index before breaking out of the loop. > > Signed-off-by: Christoph Hellwig Otherwise looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index ee2fd6a6af4072..b13ea243edb6b2 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2505,6 +2505,7 @@ int write_cache_pages(struct address_space *mapping, > * keep going until we have written all the pages > * we tagged for writeback prior to entering this loop. > */ > + done_index = folio->index + nr; > wbc->nr_to_write -= nr; > if (wbc->nr_to_write <= 0 && > wbc->sync_mode == WB_SYNC_NONE) { > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR