From: Andrew Morton <akpm@linux-foundation.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: linux-mm@kvack.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v2] mm/khugepaged: Remove redundant try_to_freeze()
Date: Tue, 19 Dec 2023 16:00:33 -0800 [thread overview]
Message-ID: <20231219160033.35263ae2818c3e8bd73ae086@linux-foundation.org> (raw)
In-Reply-To: <20231219231753.683171-1-haokexin@gmail.com>
On Wed, 20 Dec 2023 07:17:53 +0800 Kevin Hao <haokexin@gmail.com> wrote:
> A freezable kernel thread can enter frozen state during freezing by
> either calling try_to_freeze() or using wait_event_freezable() and its
> variants. However, there is no need to use both methods simultaneously.
> The freezable wait variants have been used in khugepaged_wait_work()
> and khugepaged_alloc_sleep(), so remove this redundant
> try_to_freeze().
>
> ...
>
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2500,7 +2500,7 @@ static void khugepaged_do_scan(struct collapse_control *cc)
> while (true) {
> cond_resched();
>
> - if (unlikely(kthread_should_stop() || try_to_freeze()))
> + if (unlikely(kthread_should_stop()))
> break;
>
> spin_lock(&khugepaged_mm_lock);
What are the effects upon worst-case freezing latency?
next prev parent reply other threads:[~2023-12-20 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 23:17 Kevin Hao
2023-12-20 0:00 ` Andrew Morton [this message]
2023-12-20 12:38 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219160033.35263ae2818c3e8bd73ae086@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=haokexin@gmail.com \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox