From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1064AC46CD2 for ; Tue, 19 Dec 2023 03:37:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73AB16B0082; Mon, 18 Dec 2023 22:37:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA4A6B0085; Mon, 18 Dec 2023 22:37:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1986B0087; Mon, 18 Dec 2023 22:37:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 48A9E6B0082 for ; Mon, 18 Dec 2023 22:37:17 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FCC4801A0 for ; Tue, 19 Dec 2023 03:37:17 +0000 (UTC) X-FDA: 81582157314.23.7DC5184 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf05.hostedemail.com (Postfix) with ESMTP id A108A100015 for ; Tue, 19 Dec 2023 03:37:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=r4c8IvKO; spf=pass (imf05.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702957035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wkOW8CfWZ3CabOov8YAv399V5dwHVdkA0UCTpwkBZt0=; b=lkin1JkiVVq/oZQDRW4U6+BveybCtg1Y1nJZxExysDUeIq6vqz2Xyb8/CBAMqYH8LGsPG1 2WP5sVa4NQRVzkulDyy5tdtGac5qoCqdjXTAfhCdYWccIk7JqZdFeySRtkrgCmVDRRhhOE 7KJHEeOlfVdZLxAEU6ptGvh7R/0JVdk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702957035; a=rsa-sha256; cv=none; b=M6FQ0CLGHAI9b+6dSUl0chUHg1KLr5YSL0ZP8OIUnkquFJZ/+HOT8Kdqih1T+cfyXCwPAd +AG9+YiXB7yNlif9y2vPfNaRl6h9OQPaqpSt8E+czUOcdXikhV9bIOzQW0fUpSBwqW9I3c 1eWCPPUns46ou9kn/kNdHv7lrtQwWw4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=r4c8IvKO; spf=pass (imf05.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 18 Dec 2023 22:37:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702957028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wkOW8CfWZ3CabOov8YAv399V5dwHVdkA0UCTpwkBZt0=; b=r4c8IvKOjrNbOWXKzy9Zr6SkRm44hEVmV4UlDwniRH/MtgjmLGfP/AD22iIFCGVP8IMadI GfbaDSPQGrFgn8BbfB8MI1FM8X0PtykHqXiamGvBmn4MPxknqzn4Z02Oh9QVATHTOLaPqB JG0WOaSZ4Cjn0+e1vIp/ZnHfBPWedFk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Waiman Long Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 19/50] locking/mutex: split out mutex_types.h Message-ID: <20231219033700.rsc7utoz3vkayyno@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-9-kent.overstreet@linux.dev> <7066c278-28e0-45eb-a046-eb684c4a659c@redhat.com> <20231219014617.dulwl3mdro6zyblt@moria.home.lan> <647f6ed8-c6d8-421e-b5a7-faa3c19b9bd6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <647f6ed8-c6d8-421e-b5a7-faa3c19b9bd6@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A108A100015 X-Rspam-User: X-Stat-Signature: feicdx3x4635aa5us9dbo5k5cc649j4u X-Rspamd-Server: rspam03 X-HE-Tag: 1702957033-379909 X-HE-Meta: U2FsdGVkX19rcJXN28F4jaGUo+3gOpHbzbo07i/K9UzIhrNERNFhpCixWiIMJk7Bd7eHMVIxlFH5XRGrIdbUE3oX6D1JrS69pX0JZzIrTNgyu8Ez8PDWuZRTBRpHq7w2XeJCyNmilmCe6v0ESrXwt8nsry3TVfd4vQTBBpM+VvFFNh5KuN44bJ5pC7szBLhjvOa8jqhpXefoPpwbEtW0/KU3RANPG5wMxwUIKKZtUXMewcuKDYendbkhbdS30geapTkfFOh8PaT04lgyCvO6xFLCs0DnAEAIRlTD4MinfdEN1BS2HMEHqb2CMi8mWRk0+ubeMbnx45/4yLBBBbMd3ZLFMADymYM/9eHlwGkiDkEvuDo+P9RbQC4eI+EieDKjXxuU7ukg5QDe3RwqBquNPiPOHXirXzwHCC0+4wKX/MyIn1A/MNEl51gu1kPi/0uAvqLLyaAYipy2tUjMjb9ZlgGwih8VIY7rKA8minvCnOVc0/ZBkDqPzzHJ+FdXuFuvtQZDgNGcIF8KxPUGTLPVjEvIYLPbB+g18K0xLY9b/TPhTtPk2NkT9fgEavKKZAQT+lLlRf/UYkc/AwxoGzK3hs96Vy9YTncjwfiJCONUgDUAMzWknhx3P5wI79HFwdqBA0QISudS+ZQ65oiCCEGZrvgcj5o4gDydIfz3pJMetk95/ZQJrL+J5wT/9zVOl6696RsQIDbbGENUKrAx2I3ajHIZNwlgpUVhjqE0ukBpxVcxKb70b2gE+Sq5r1ZgfHbwN7bJZdZ/dSPsfPrtbZakaCuEUDTUN6aDWLu5DZKSVdLyvNaFIQd1Vc01p2YH2LKU8WQMg60fFIwVSFA6/0pPArlaYq610mg7Wk7e5Jl75B4U6jUZA//sDDGJSIo25c3Txn8pDkdbVRY/mO4qzGhA8rtmp6WjuDUVGOVAJrx0rTX8pJr8eCcFB3xwZbB2MZ0B2ZwQWsKvdBiUs7nks9V mzlyTppp UrTrPp9m9VjwgIdgKEzK0YxwvNCyAeDSsIY3NqD1C0YP7N544QQ/kQBuJ9UCs8afY6xCulUl4skJoPEh6NAv7e/7siL6dnze2isXCVvh8esLag2xGJVhW0EQ2/7Efv8MlKJAoLacQje/U9g+nmTFnFgTcmZQ21uyZRq/Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 10:04:39PM -0500, Waiman Long wrote: > > On 12/18/23 20:46, Kent Overstreet wrote: > > On Mon, Dec 18, 2023 at 11:53:08AM -0500, Waiman Long wrote: > > > On 12/15/23 22:26, Kent Overstreet wrote: > > > > -#include > > > Including rtmutex.h here means that mutex_types.h is no longer a simple > > > header for types only. So unless you also break out a rtmutex_types.h, it is > > > inconsistent. > > good observation, I'll have to leave it for the next round of cleanups > > though since the merge window is approaching and I'll have to redo all > > the testing. > > > > > Besides, the kernel/sched code does use mutex_lock/unlock calls quite > > > frequently. With this patch, mutex.h will not be directly included. I > > > suspect that it is indirectly included via other header files. This may be > > > an issue with some configurations. > > I've now put it through randconfig testing on every arch that debian > > includes a compiler for (excluding sh and xtensa, which throw internal > > compiler errors) and that one hasn't come up yet. > > > > could still be included indirectly though - I haven't checked for that > > one specifically yet. > > If you are replacing mutex.h in include/linux/sched.h by mutex_types.h, I > would suggest you add mutex.h to kernel/sched/sched.h to ensure this header > file is included by the scheduler code. It already does, via mutex_api.h...