From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: shr@devkernel.io, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
joseph.qi@linux.alibaba.com, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: [PATCH v2 1/2] mm: fix arithmetic for bdi min_ratio
Date: Tue, 19 Dec 2023 10:42:45 +0800 [thread overview]
Message-ID: <20231219024246.65654-2-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20231219024246.65654-1-jefflexu@linux.alibaba.com>
Since now bdi->min_ratio is part per million, fix the wrong arithmetic.
Otherwise it will fail with -EINVAL when setting a reasonable min_ratio,
as it tries to set min_ratio to (min_ratio * BDI_RATIO_SCALE) in
percentage unit, which exceeds 100% anyway.
# cat /sys/class/bdi/253\:0/min_ratio
0
# cat /sys/class/bdi/253\:0/max_ratio
100
# echo 1 > /sys/class/bdi/253\:0/min_ratio
-bash: echo: write error: Invalid argument
Fixes: 8021fb3232f2 ("mm: split off __bdi_set_min_ratio() function")
Reported-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
mm/page-writeback.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index ee2fd6a6af40..2140382dd768 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -692,7 +692,6 @@ static int __bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ra
if (min_ratio > 100 * BDI_RATIO_SCALE)
return -EINVAL;
- min_ratio *= BDI_RATIO_SCALE;
spin_lock_bh(&bdi_lock);
if (min_ratio > bdi->max_ratio) {
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-12-19 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 2:42 [PATCH v2 0/2] mm: fix arithmetic for bdi min_ratio and Jingbo Xu
2023-12-19 2:42 ` Jingbo Xu [this message]
2023-12-19 2:42 ` [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting max_ratio Jingbo Xu
2023-12-19 4:06 ` Matthew Wilcox
2023-12-19 5:58 ` Jingbo Xu
2023-12-19 13:01 ` Matthew Wilcox
2023-12-19 14:07 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219024246.65654-2-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox