From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3B3C35274 for ; Tue, 19 Dec 2023 02:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEE476B0082; Mon, 18 Dec 2023 21:06:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9E616B0083; Mon, 18 Dec 2023 21:06:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9663C6B0085; Mon, 18 Dec 2023 21:06:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82E2A6B0082 for ; Mon, 18 Dec 2023 21:06:12 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5379114022F for ; Tue, 19 Dec 2023 02:06:12 +0000 (UTC) X-FDA: 81581927784.22.37C4F99 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf11.hostedemail.com (Postfix) with ESMTP id 841DD4000A for ; Tue, 19 Dec 2023 02:06:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aX8pVtcr; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702951570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4ZNMb7/jqAplkG+DzZrazJbBaTJxRG9mCYNQGQEEo8=; b=gSQxpIiLkSbT08mcMo6kIPdkqCB+rlp3WG1Vxk8QyoNP8Ef4DfzK3/aWz+hErGI1urtgyI 7A1H/71vOd8siBslYMjsFi76kYmrdS2xiDXcr4cHkfJKqJzU+B7Yy+dQv72B9upK0qq6RJ hYs3yv1P+Y61pxZxgntxm4z2zWhuj5M= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aX8pVtcr; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702951570; a=rsa-sha256; cv=none; b=URVS2IIimpgv6phmkUXrMlkMa71RXhthb4BG47ZWYmO9vfns+4xR2wUiXvmwpi7gxN8vsT U8yDhSxxb9+Rt1uD1T+G7ZRIbwrcx9NZCSDYW/r580EDCy9RXODvIqm4uxOnNTfHlPwoSx rH39tdT+W5wCJTOJOHJCE1syibtlMsM= Date: Mon, 18 Dec 2023 21:06:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702951569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R4ZNMb7/jqAplkG+DzZrazJbBaTJxRG9mCYNQGQEEo8=; b=aX8pVtcrce0Fe5hKWFw6wj2302wK8JYE2zDEyCVPWYqNH1aiFpO1CGRfW0WoqJdUQwQFS+ m/+JeAeq2fIlhH31dT/CG7ynpRUyPdbJ8jEgmMeijFGh01ycIWgOFW1jn3YlBXRgVUVNe6 h6njiVE+gTySe1IZ2OK4ex200Q2TvMI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Sohil Mehta Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include Message-ID: <20231219020605.edmlnz2hgjb4h4im@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216024834.3510073-4-kent.overstreet@linux.dev> <76af02dd-1f16-41ad-86c7-3202146d0085@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76af02dd-1f16-41ad-86c7-3202146d0085@intel.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 841DD4000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zq1yf7z5ne7s687c1wgc7ow14wqieeko X-HE-Tag: 1702951570-388136 X-HE-Meta: U2FsdGVkX1+ZW//JHY/I63YFNwHPW/iARSx8CxWTPM9fnxY0usbgQwL3NF3zt4CUKHyuJg1slkH689G3XK9CRjJSStjk5RaoBNStgShTXsuTjr0Mii4Ov69mD9ZJDMXuL0ObA2bSakay/nKPmpuDEXXJeWzgQgLWs1cfOxQrg4TySrqjUiEgDbZnjjtve/nJtjFl/bBl+FeGcU8SPzIAMGODIAFIJNSKIXuXbldgdxqhHYD6szcl6UaAXvF34Q7IRURp/g6QyUT8vI9+GOJubBBUWCaI7xKHKmWmNB+Aw/yp020FeHWvc95CsKSStAk+4qdfdxkymAYXf9hflehMX2hakZGFZn1fWYZ9hZfTC0q0T42K3iwgah7UlJ3H9596r2onbLQGwWoIvQROEpi0REHpvFS2BfAoCCL72ZbIRGkQAclmJXT2w4DoAkXDEnQXgw5MC68S13gXhVTePchGBuMEMbWgX6Z0x0fqjOi3wSi0G0oc4pB97LojjQYdjzr2FgjIL7yeRKAKkpaIVw9qRJ02sqPT3c8sYjNOIvXONMs9JA85JB3APuLfjer7fwjFO1IqfPM5oZI+CTpfxmEyfBcVekKyimL8MJMIRKlQIv5vEnypDo/eUKpOnVstg4t+xkkXK6pEAr40Poh5auNo1kHtZANTeL1F5TUta5sro3hSHlQlTsANzEnVrjGpiLxeCMbYnJsBGP0K7MFTukSsnE8KHP0CX8RX0CHGYVVspHkH+jXYPFqN3h6kAUIUACJn6mHFua78KnPeizRZ1wC86GGaHdp+KsgQNvwXcMxJAfwReAqabvFYMPUV0H4wpPYEVMXkDZtKfCdq5skcVpXU7d3OQcmGPSqgu/anVla7mR/8VQoeOWI8pmNJpCGTVARNVYLwBFlRl6nrN2URuCDTJaWlDIaEIpzY1e2d6KB6S92jfJOYxnNbdph/JjsriLVqe+NvUVpsgF/DbPJRlY9 kVH1qxzy TP0Ds5LYH2udvKACDKDQK67icUS6paDb5hWw/uc17E+BKERk2wj2wNd8lN+qWqvVfgco9bjryOIKieveOcXflvYWNW4GFaW5ZivWVA6mNY9h066GKFWEQtbJM2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 04:18:29PM +0530, Sohil Mehta wrote: > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > index 7c48ff4ae8d1..7af743bd3b13 100644 > > --- a/arch/x86/lib/cache-smp.c > > +++ b/arch/x86/lib/cache-smp.c > > @@ -1,4 +1,5 @@ > > // SPDX-License-Identifier: GPL-2.0 > > +#include > > #include > > #include > > > > I believe the norm is to have the linux/ includes first, followed by the > the asm/ ones. Shouldn't this case be the same? I haven't seen that? I generally do the reverse, simpler includes first, not that I have any reason for that...